Skip to content
Snippets Groups Projects

#471 - fix timeline fetch with since_id

Merged Jared Redford requested to merge jaredr/pleroma-fe:471-timeline-since-id into develop

Closes #471 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Maintainer

    looks good but i'm not exactly sure what problem is so I'll leave it up to @shpuld to test it to verify that problem is solved

  • Problem was comparing status id and default maxId which is 0 returned false.

  • Maintainer

    i'm talking about what perceived problem is, 'cuz i don't see anything weird on my side

  • I'm not sure if it's fixed in this yet, gonna try it a bit later, but the problem was BE always returning 20 statuses for every timeline fetch instead of just the roughly 0-2 new statutses, which is really heavy and was making my laptop choke

  • maxId of timelineData was always 0 and because of this since_id was null in the API request.

  • Yeah this works nicely for regular timelines, I noticed notifications still fails the same way though, I get 8 new notifications on every fetch. I'll still merge this in now and the notifications can be fixed separately.

  • mentioned in commit df366a58

Please register or sign in to reply
Loading