Fix Follow/Mute/Block not functional issue in the user search page

isn't this the same as !699 (closed)?

oh, thanks for referring. will check it out.

yes, it is. But not exactly same. This resolves more.

The prior MR does not fix a bug that "Follow" button is not synching with the global state.

LGTM

mentioned in merge request !699 (closed)

added 7 commits

5bb13abe...936eb23b - 5 commits from branch pleroma:develop
8e3c1eaa - refer searched user objects from the global user rep
3c0dc966 - fix follow button not updating bug in follow-card

Compare with previous version

added 25 commits

3c0dc966...55410c91 - 23 commits from branch pleroma:develop
09ecdf6d - refer searched user objects from the global user rep
86d4be70 - fix follow button not updating bug in follow-card

Compare with previous version

doesn't seem to be fixing anything to me

Well, the action buttons (follow/mute/block) are functional but don't change labels (states). This is because the page doesn't consume user objects from the global repository. The MR fixes this mess. Please let me know if this is not clear.

last time i tested it they still didn't change labels

Hmm, can you kindly retry? it must be working.

added 4 commits

86d4be70...e9f4244b - 2 commits from branch pleroma:develop
e717a12e - refer searched user objects from the global user rep
64fb21c9 - fix follow button not updating bug in follow-card

Compare with previous version

added 49 commits

64fb21c9...ed0f10e9 - 47 commits from branch pleroma:develop
8f5f61b7 - refer searched user objects from the global user rep
34e4b74f - fix follow button not updating bug in follow-card

Compare with previous version

added 49 commits

e4ec46d6 - fix mess in UserProfile component
1dbe15df - add checkbox component
50d6728b - add SelectableRow component
0726de6a - use reusable List vue component instead of withList hoc
43320ff6 - refactor using List component
749b0e1b - remove withList hoc
84d859c5 - remove unused yarn package
e8eccbb0 - rename selectable_row to selectable_list
9b1e5845 - use SelectableList for blocks/mutes list
fc9aa8aa - save selected items to the state
07d28c28 - use key properly
6270b656 - add some styling to the selectable-list component
ed459a67 - move border-bottom style to the list
e343ca0f - add border-bottom style to the list component as well
f026beeb - refactor selectable-list using list component
606febde - clean up
cf9510a5 - let not selectable-list know about getKey prop
ee0f8412 - show empty slot only if it has content
764a0ee5 - recover border between basic-user-card using list component
f6820d77 - remove border-bottom of the last list item
7fafd37f - add header to selectable-list component
66b14e19 - support header slot
5bbb50ff - add border-bottom to the header
3a0e6780 - replace scope attributes by slot-scope
22c557dc - add reusable progress-button cmoponent
4b6fdfbd - add bulk action buttons
1a6464f6 - make border of list header thicker
872385be - pass down empty slot
8c5078a3 - show list header only if there are items
b25f0508 - add a comment
f5be820e - wire up bulk action buttons to vuex
f1f14631 - add bulk mute/unmute buttons and wire up to vuex
c7fa56c5 - clean up
1e55d637 - ui improvements
0aa9b3a6 - support i18n
70c2524c - rewrite checkbox component as non-functional
604fbace - update checkbox importing path
0bb8483c - import scss variables
899b318c - update model and props properties
99592e32 - render span tag only if it has content
a1f0cfea - support indeterminate checkbox state
66052754 - make sure to use filtered selected keys
8772e4f4 - clean up
b57467a2 - fix typos
b990cd65 - code readability
fc3b8ffe - remove extra spacing
83df2830 - Revert "recover border between basic-user-card using list component"
f3a15e29 - refer searched user objects from the global user rep
12f7aa86 - fix follow button not updating bug in follow-card

Compare with previous version

added 53 commits

12f7aa86...61d04b88 - 51 commits from branch pleroma:develop
6732bafb - refer searched user objects from the global user rep
a794dcc7 - fix follow button not updating bug in follow-card

Compare with previous version

added 50 commits

55b14b14 - fix mess in UserProfile component
8a7cf87e - add checkbox component
43fe03cc - add SelectableRow component
7280cc08 - use reusable List vue component instead of withList hoc
a58c371f - refactor using List component
7099041c - remove withList hoc
6aecd302 - remove unused yarn package
84220391 - rename selectable_row to selectable_list
1fdee10c - use SelectableList for blocks/mutes list
f462c257 - save selected items to the state
8ff9a21e - use key properly
b56bbf8b - add some styling to the selectable-list component
1e090476 - move border-bottom style to the list
b9a03ffb - add border-bottom style to the list component as well
e254bf7c - refactor selectable-list using list component
0cef6b3f - clean up
6907eef8 - let not selectable-list know about getKey prop
22caf74c - show empty slot only if it has content
1a0cc2d3 - recover border between basic-user-card using list component
e3a674ab - remove border-bottom of the last list item
3cce365f - add header to selectable-list component
fbd2e0dd - support header slot
e3ac8337 - add border-bottom to the header
b04ec0dd - replace scope attributes by slot-scope
eb039238 - add reusable progress-button cmoponent
3c0c81ed - add bulk action buttons
8c008438 - make border of list header thicker
6c6dde43 - pass down empty slot
7baa73d0 - show list header only if there are items
f8ebd837 - add a comment
b328ba2c - wire up bulk action buttons to vuex
de464f98 - add bulk mute/unmute buttons and wire up to vuex
cc2cde0c - clean up
6163123f - ui improvements
a7c056ff - support i18n
a24931e0 - rewrite checkbox component as non-functional
80187a4e - update checkbox importing path
d46764f4 - import scss variables
80005638 - update model and props properties
e63a6bff - render span tag only if it has content
673812e7 - support indeterminate checkbox state
3e212ad6 - make sure to use filtered selected keys
eec2d7bc - clean up
67ecf2a3 - fix typos
fee8f057 - code readability
15e6bd3d - remove extra spacing
8cebffbf - Revert "recover border between basic-user-card using list component"
c3706ef3 - stop fetching user relationship when user is unauthorized
d91b1828 - refer searched user objects from the global user rep
4b1801db - fix follow button not updating bug in follow-card

Compare with previous version

added 53 commits

4b1801db...61d04b88 - 51 commits from branch pleroma:develop
b6aa78bc - refer searched user objects from the global user rep
1f8ad4b8 - fix follow button not updating bug in follow-card

Compare with previous version

added 18 commits

1f8ad4b8...c8f967d5 - 16 commits from branch pleroma:develop
f2f3fa81 - refer searched user objects from the global user rep
445b54c5 - fix follow button not updating bug in follow-card

Compare with previous version

It works for me, @hj still broken for you? I tried on firefox

i'll test tomorrow, too tired today sorry.

last time i tested it:

old develop on sgsgb: cards aren't updated
this MR: cards aren't updated

this time i'm testing it:

old develop on sgsgb: cards are updated
fresh local develop: cards are updated
this MR: cards are updated

I can however say that user cards (the collapsible ones) inside work better in this MR, so it fixes something.

It doesn't seem to be fixing the #492 (closed) but now i can't reproduce that bug now, so i guess issue is something else entirely?

@hj I'm not sure why your testings went wrong. So, I've tested this again on my end.

fresh local develop: 'Follow', 'Mute' and 'Block' buttons are not updated until refresh. video recording -> https://drive.google.com/open?id=1-1HWPXdJ9AoXsN6kru_F0FXMtFEu-qLS

this MR: The buttons are updated in real time. video recording -> https://drive.google.com/open?id=1cGG08mspM1uagSipOgAD9O64hYiyzP9D

oh so you mean THOSE cards, ok, sure.

mentioned in commit e351f863

merged

Fix Follow/Mute/Block not functional issue in the user search page

Merge request reports

Activity