Skip to content
Snippets Groups Projects

Display additional scope description above the status form for mobile users.

Merged Eugenij requested to merge eugenijm/pleroma-fe:mobile-scope into develop

Closes #505 (closed)

Edited by Eugenij

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eugenij changed the description

    changed the description

  • Eugenij added 1 commit

    added 1 commit

    • db16fda1 - Display additional scope description above the status form for mobile users.

    Compare with previous version

  • Author Contributor

    Ready for review code-wise. Not sure about the description in the title bar, I used the existing captions but it feels a bit wordy in this context:

    direct

    private

    unlisted

    public

    Maybe something like

    • Post new status (Public)
    • Post new status (Unlisted)
    • Post new status (Followers-only)
    • Post new status (Direct)
  • Eugenij unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Eugenij changed the description

    changed the description

  • Maintainer

    Can we have it for desktop too?

  • Maintainer

    Also putting it into title is a very bad idea because it will overflow easily on smaller screens

  • Author Contributor

    Can we have it for desktop too?

    Sure thing, I will add it in this MR.

    Also putting it into title is a very bad idea because it will overflow easily on smaller screens

    Would it be better to use the same approach as for direct message warning?

    public1

    unlisted2

    Edited by Eugenij
  • Maintainer

    yeah, but should definitely be dismissible. It would be annoying seeing that always.

  • Author Contributor

    Would it be okay to dismiss it when the user taps on the entire message? I'd imagine tapping on a small × sign would be rather inconvenient on mobile.

    Although the scope visibility selectors are also quite small, so maybe that's fine.

    Edited by Eugenij
  • Eugenij added 122 commits

    added 122 commits

    • db16fda1...4819009d - 121 commits from branch pleroma:develop
    • befaa477 - Display additional scope description above the status form for mobile users.

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • 4af34337 - Move scope visibility notice to the status form, make it dismissible

    Compare with previous version

  • Author Contributor

    It is dismissible now

    publicnotice

    Do we want this to be remembered on the backend?

    Edited by Eugenij
  • Been a bit out of loop with this one, not sure what the main idea behind this is. I think it's a bit weird to have something you can dismiss that will never come back, like as a new user you might have seen that popup and close it, forget what it said and want check it again to see how unlisted works for example, but simply can't. I still don't think this makes anything worse the way it is, it might help some new users so I guess I'm ok with it as it is.

  • Maintainer

    Technically all dismissible stuff like this should be stored in some array/map, and a button to reset hints probably. It needs more thought and stored in BE (like everything else) obviously, but this is better already.

  • HJ
  • HJ
  • Maintainer

    Maybe give it better and friendlier description?

    "This post will be visible to everyone" "This post will be visible to logged in users only" (???? needs confirmation) "This post will be visible to your followers only"

  • HJ
  • Eugenij added 1 commit

    added 1 commit

    • 760dbef3 - Use more clear explanation in the scope notice, make sure the hide button...

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading