Skip to content
Snippets Groups Projects

Implement ability to subscribe to a user

Merged Tae Hoon requested to merge tae/pleroma-fe:482-subscribe-user into develop

Closes #482 (closed)

Screenshot

Screenshot_at_Jul_11_12-53-59

Screenshot_at_Jul_11_12-54-40

Edited by Tae Hoon

Merge request reports

Pipeline #14599 passed

Pipeline passed for ff90d864 on tae:482-subscribe-user

Approval is optional

Merged by HJHJ 5 years ago (Jul 15, 2019 6:50am UTC)

Merge details

Pipeline #14693 passed

Pipeline passed for 0c064105 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ
  • HJ
  • HJ
  • Maintainer

    I feel like "Subscribe" button is confusing, since what's the difference between "following" someone and "subscribing" to someone. Bell icon is familiar if you used youtube and you can put a tooltip there like "Receive notifications when this user posts" or something.

  • Maintainer

    also, as i mentioned above

    "Following" works because it continuous action. You can stop following or "unfollow" at any time. "Subscribing" sounds like you're in process of adding subscription. It's probably a valid use but more often you'll see "subscribed" then "subscribing". Again, youtube says "subscribed".

  • Tae Hoon added 11 commits

    added 11 commits

    Compare with previous version

  • Author Contributor

    @hj I agree, "Subscribed" is more correct.

  • Tae Hoon added 2 commits

    added 2 commits

    Compare with previous version

  • Tae Hoon added 1 commit

    added 1 commit

    • 88c0b06d - no need to covert to boolean

    Compare with previous version

  • Tae Hoon resolved all discussions

    resolved all discussions

  • Author Contributor

    @hj Where do you suggest to put the "Bell" icon?

  • Author Contributor

    let's try to put the icon right next to the "external" icon in the upper right corner.

  • Maintainer

    image

    had something like this in mind. I'd make some better mockups for possible solutions and ask people around in #pleroma-dev-ux

  • Contributor

    agreed that the bell icon would be best

  • Tae Hoon added 1 commit

    added 1 commit

    Compare with previous version

  • Tae Hoon added 2 commits

    added 2 commits

    Compare with previous version

  • Tae Hoon added 3 commits

    added 3 commits

    • fcf0fb8d - clean up + add btn-group css class
    • 454f530f - add bell-off font icon
    • 72df58b5 - change subscribe button to icon button

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading