wire up notification settings

Add the notification settings in pleroma!988 (merged) and pleroma!1204 (merged).

added 1 commit

• 28ca5045 - wire up notification settings

Compare with previous version

?

I created a new tab for these settings, I can get rid of the tab and put them elsewhere, but I figure we will probably have more settings in the future that influence how interactions behave for an account.

there's already "notifications" section in "General" tab of just-settings, you probably should move that lone setting from there to this tab too.

Otherwise I don't think it should be called interactions because that's a little bit broader concept and blocking/muting kinda falls into that category too.

There's also this: #232

it's somewhat challenging because this controls what notifications BE generates at all. so these settings need to live with the account. I don't think having #232 as part of this makes sense in that regard as that has to do more with how FE presents the notifications. these settings ensure the notifications are disabled across all clients.

it all would be so much better when we'll have ability to save FE user-settings to BE, so that we can finally merge the two settings pages.

For now i think "notifications" would still be better for a tab label

changed this line in version 3 of the diff

there's if (data.pleroma) right above it

while true it seemed to me like they were grouped into concerns. I can collapse them if wanted.

someone was probably coding drunk, there are no separation of concerns, if is just made in case someone tries to use it on older/broken pleroma-be or different BE, so that it won't halt and catch fire just because of that

changed this line in version 3 of the diff

I feel like the opposite wording would be good. I.e. "don't get notifications from non-followers" or something like that instead of "show notifications from non-followers".

People would probably want to disable notifications from certain people, they would be looking for "Disable (something)" or "Don't (something)"

added 2 commits

• ac97cd3e - entity normalizer: collapse data.pleroma if blocks
• 855566f8 - notification controls: redesign entirely

Compare with previous version

Redesigned the notification controls entirely. Local and remote options were removed because they were deemed too complicated.

LGTM

mentioned in commit b4796ccb

merged