Move character counter into the input box (!848) · Merge requests · Pleroma / pleroma-fe · GitLab

Snippets Groups Projects

Merged Shpuld Shpludson requested to merge fix/move-character-counter into develop 5 years ago

2 unresolved threads

Screenshot of empty and non-empty inputs

Edited 5 years ago by Shpuld Shpludson

Activity

Shpuld Shpludson changed the description 5 years ago

changed the description
lain @lambadalambda 5 years ago

Owner

I like this idea, but it seems a bit too tight in the inline example with the text, at least to my eyes.

Shpuld Shpludson @shpuld 5 years ago

Author Maintainer

Ok, that will make the empty status box taller as well, and making the size change and the counter fade away on focus is not in scope for this

Shpuld Shpludson @shpuld 5 years ago

Author Maintainer

Well nevermind I can make it slightly smaller at least

Please register or sign in to reply
Shpuld Shpludson added 1 commit 5 years ago
added 1 commit

0da67a94 - fix bug with scaling the form, make padding larger

Compare with previous version
Shpuld Shpludson added 1 commit 5 years ago
added 1 commit

0d4fbf34 - thin the bottom a little bit

Compare with previous version
HJ @hj started a thread on an old version of the diff 5 years ago

src/components/post_status_form/post_status_form.vue

65	65	class="form-post-body"
66	66	>
67	67	</textarea>
	68	<p v-if="isOverLengthLimit" class="character-counter error">{{ charactersLeft }}</p>
HJ @hj 5 years ago Maintainer i always get the feel that probably we should actually use `:class=` instead of using `v-if` to change class... Shpuld Shpludson @shpuld 5 years ago Author Maintainer yeah you're right, didn't pay attention Shpuld Shpludson changed this line in version 4 of the diff 5 years ago changed this line in version 4 of the diff Please register or sign in to reply

Shpuld Shpludson added 1 commit 5 years ago

added 1 commit

64382b8b - use less v-if-else

Compare with previous version

Shpuld Shpludson merged 5 years ago

merged

Shpuld Shpludson mentioned in commit 5 years ago

mentioned in commit c2b48c32

Please register or sign in to reply