Skip to content
Snippets Groups Projects

Bookmarks

Merged Eugenij requested to merge eugenijm/pleroma-fe:bookmarks into develop

Revives the bookmarks MR (Closes #472 (closed)).

  • pagination needs to be updated to be compatible with the current BE implementation, which stores bookmarks in a separate table in the DB (ref: #667 (closed)).
Edited by Eugenij

Merge request reports

Pipeline #28043 passed

Pipeline passed for 4af6e610 on eugenijm:bookmarks

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 4 years ago (Jul 3, 2020 7:45pm UTC)

Merge details

Pipeline #28045 passed

Pipeline passed for 76de4a31 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ
  • HJ
  • HJ
  • HJ
  • HJ
  • Eugenij added 24 commits

    added 24 commits

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • 4b4c8b0e - Use link headers for pagination

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • e45ce387 - Use link headers for pagination

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • e00d94f9 - Use link headers for pagination

    Compare with previous version

  • Maintainer

    Are we bookmark ready yet?

  • Eugenij added 17 commits

    added 17 commits

    Compare with previous version

  • Eugenij added 66 commits

    added 66 commits

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • 6ae4a304 - Use link headers for pagination

    Compare with previous version

  • Eugenij added 7 commits

    added 7 commits

    Compare with previous version

  • Eugenij added 15 commits

    added 15 commits

    Compare with previous version

  • Eugenij added 12 commits

    added 12 commits

    Compare with previous version

  • Eugenij added 18 commits

    added 18 commits

    Compare with previous version

  • What's the status on this? May I take over and finish it?

  • Maintainer

    i need to re-check it and test it, basically

  • Now that there are emoji reactions, the UI probably needs to be changed a bit..

  • Eugenij added 1 commit

    added 1 commit

    • 8b85218f - Use link headers for pagination

    Compare with previous version

  • Eugenij added 27 commits

    added 27 commits

    Compare with previous version

  • Eugenij added 6 commits

    added 6 commits

    Compare with previous version

  • Eugenij added 12 commits

    added 12 commits

    Compare with previous version

  • Eugenij added 190 commits

    added 190 commits

    Compare with previous version

  • Eugenij added 322 commits

    added 322 commits

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • 9a30d1a4 - Use parse-link-header instead of http-link-header

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • 2ac9095f - Use parse-link-header instead of http-link-header

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • e95960b7 - Parse notification ids from link headers as integers

    Compare with previous version

    • Resolved by Shpuld Shpludson

      I did some more testing, just observing the same timeline on this branch and on my instance without it, for some reason in this branch it triggers the timeline "flush" much more often for no good reason. on my twkn it went from "Show new (6)" on both tabs to "Show new (8)" in one and "Show new" (flush queued) in this branch. 2 new posts should never trigger a flush

  • Eugenij added 10 commits

    added 10 commits

    • e95960b7...7bd89b57 - 7 commits from branch pleroma:develop
    • 475cd85d - Add bookmarks
    • 0edf26fa - Parse notification ids from link headers as integers
    • 7f02208e - Add unit test for parseLinkHeaderPagination, fix incorrect minId being set in...

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • 84c19dd3 - Add unit test for parseLinkHeaderPagination, fix incorrect minId being set in...

    Compare with previous version

  • Eugenij added 1 commit

    added 1 commit

    • 8c4be5d1 - Add unit test for parseLinkHeaderPagination, fix incorrect minId being set in...

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading