Skip to content
Snippets Groups Projects

Settings refactor

Merged HJ requested to merge settings-refactor into develop
1 unresolved thread
  • Greatly decreased overall verbosity of settings/config
    • New getter: mergedConfig - combines user config with instance-default config, no more need for instance.thing !== undefined ? instance.thing : user.thing
    • Settings page now automatically creates all needed computed properties with setters - no more need for optionSettingLocal and relevant watchers - only thing needed is to define settings in module.
  • Replaced most trivial checkboxes with <Checkbox> component, decreasing overall verbosity in user-settings/settings templates, streamlining other checkboxes.
    • Other checkboxes are deemed non-trivial and probably will be replaced later.
Edited by HJ

Merge request reports

Pipeline #19265 passed

Pipeline passed for b66564a3 on settings-refactor

Approval is optional

Merged by HJHJ 5 years ago (Oct 29, 2019 7:41am UTC)

Merge details

  • Changes merged into with 21989c67.
  • Deleted the source branch.

Pipeline #19266 passed

Pipeline passed for 21989c67 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1 1 <template>
2 <label class="checkbox">
2 <label
3 class="checkbox"
4 :class="{ disabled, indeterminate }"
5 >
  • Looks good, only nitpicks about wrong > indent in a few places

  • HJ added 112 commits

    added 112 commits

    Compare with previous version

  • HJ enabled an automatic merge when the pipeline for b66564a3 succeeds

    enabled an automatic merge when the pipeline for b66564a3 succeeds

  • HJ merged

    merged

  • HJ mentioned in commit 21989c67

    mentioned in commit 21989c67

  • Please register or sign in to reply
    Loading