Skip to content
Snippets Groups Projects

Improve gallery sizing logic

Merged Tae Hoon requested to merge tae/pleroma-fe:improve-gallery-sizing-logic into develop
1 unresolved thread
  • improve gallery height calculation logic without tracking its container width
  • fix a potential bug that doesn't show gallery attachments if the gallery (or timeline) was hidden at the mounting point
  • set ideal flexible length on the gallery attachments based on their original aspect ratio (the original issue - !863 (comment 35649), you will see the ideal firefox version in all major browsers now)
Edited by Tae Hoon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tae Hoon added 1 commit

    added 1 commit

    • 3e57eda1 - update flex-grow calculation logic

    Compare with previous version

  • Tae Hoon resolved all threads

    resolved all threads

    • Author Contributor

      updated

    • Maintainer

      Flex-basis is missing so we're back again.

      image

    • Maintainer

      just add flex-basis: 0 and flex-shrink: 1 to src/components/gallery/gallery.vue

    • Author Contributor

      The attachment component is messy and I can't find a proper selector for it. I set all of them as inline style since it is thought of as having the highest specificity.

      Edited by Tae Hoon
    • Please register or sign in to reply
  • Tae Hoon added 1 commit

    added 1 commit

    Compare with previous version

  • Tae Hoon added 27 commits

    added 27 commits

    • 0c917b65...cd956185 - 23 commits from branch pleroma:develop
    • 6c4d2371 - populate gallery row height without getting width
    • 0396c6f2 - keep image natural ratio in gallery row
    • ad045222 - update flex-grow calculation logic
    • b9c281c5 - set flex amount correctly

    Compare with previous version

  • HJ
  • Tae Hoon added 1 commit

    added 1 commit

    • d76b83ef - set flex-shrink and flex-basis explicitly

    Compare with previous version

  • HJ merged

    merged

  • HJ mentioned in commit f5c37231

    mentioned in commit f5c37231

  • Please register or sign in to reply
    Loading