pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

Better storage #1615

Closed
hj wants to merge 0 commits from gitlab-mr-iid-343 into develop
pull from: gitlab-mr-iid-343
merge into: pleroma:develop
Conversation 8 Commits - Files changed -
hj commented 2018-09-09 18:53:01 +00:00
Member
Copy link

See #144

What this does:

  1. Separates instance-related options (static/config.json, api-provided config, nodeinfo) into a separate module called instance. This cleans up a bit of confusion between user settings and instance settings, in this case it handles option collapseMessageWithSubject more gracefully, without temporarily renaming property name. This leaves more freedom for more options that admins may set for instance by default but user may change it nonetheless. Also leaves ground to separate instance options and backend features, however it's kinda messy right now so i did not dig into it.
  2. Removes 60s throttle. Currently nearly every action triggers persistent storage to store data into localstorage, the previous solution was to use throttle, but that causes the awkward "do not refresh page after changes or they will become lost". Removing it doesn't seem to harm the performance, but just in case I've added a whitelist of what actions do trigger persistent storage saving. Maybe i'll rework it into a one action that does trigger saving and use that in all that need saving.
  3. The newly introduced instance module also tries to keep all fields that are eventually get written into it to maintain some defaults, so it would also work without config.json which, in the future we'll change into config.sample.json
  4. Another module was introduced - interface - this is mainly for stuff not directly related to anything and mostly for UI's internal housekeeping. Currently setPageTitle is moved there and also stuff for giving feedback on whether settings were saved or not. I also wanted to move i18n stuff there but honestly couldn't figure out how to actually do that.
  5. Allows FE to work without static/config.json and api/statusnet/config.json, completely relying on built-in defaults. even without user settings
  6. Fixes some small things like mystical error when user isn't logged in and trying to fetch a friends timeline.

I'm currently testing it on SGSGB to see how it works.

See #144 What this does: 1. Separates instance-related options (static/config.json, api-provided config, nodeinfo) into a separate module called `instance`. This cleans up a bit of confusion between user settings and instance settings, in this case it handles option `collapseMessageWithSubject` more gracefully, without temporarily renaming property name. This leaves more freedom for more options that admins may set for instance by default but user may change it nonetheless. Also leaves ground to separate instance _options_ and backend _features_, however it's kinda messy right now so i did not dig into it. 2. Removes 60s throttle. Currently nearly every action triggers persistent storage to store data into localstorage, the previous solution was to use throttle, but that causes the awkward "do not refresh page after changes or they will become lost". Removing it doesn't seem to harm the performance, but just in case I've added a whitelist of what actions do trigger persistent storage saving. Maybe i'll rework it into a one action that does trigger saving and use that in all that need saving. 3. The newly introduced `instance` module also tries to keep all fields that are eventually get written into it to maintain some defaults, so it would also work without `config.json` which, in the future we'll change into `config.sample.json` 4. Another module was introduced - `interface` - this is mainly for stuff not directly related to anything and mostly for UI's internal housekeeping. Currently `setPageTitle` is moved there and also stuff for giving feedback on whether settings were saved or not. I also wanted to move i18n stuff there but honestly couldn't figure out how to actually do that. 5. Allows FE to work without `static/config.json` and `api/statusnet/config.json`, completely relying on built-in defaults. even without user settings 6. Fixes some small things like mystical error when user isn't logged in and trying to fetch a friends timeline. I'm currently testing it on SGSGB to see how it works.
hj commented 2018-09-12 23:58:39 +00:00
Author
Member
Copy link

3 days in and it works pretty well. I want to improve code tho.

3 days in and it works pretty well. I want to improve code tho.
lanodan commented 2018-09-13 00:04:52 +00:00
First-time contributor
Copy link

Why did you move the russian i18n file in this MR?
Shouldn’t it be already done in #1609 ?

Why did you move the russian i18n file in this MR? Shouldn’t it be already done in https://git.pleroma.social/pleroma/pleroma-fe/pulls/1609 ?
hj commented 2018-09-13 00:14:05 +00:00
Author
Member
Copy link

Probably just started branch on a wrong commit, i'll rebase when i get to it.

Probably just started branch on a wrong commit, i'll rebase when i get to it.
hj commented 2018-09-13 00:14:47 +00:00
Author
Member
Copy link

yeah, 9f84f4ea05 should not be in this MR.

yeah, 9f84f4ea052bd64e4989c1842736f956c149d18c should not be in this MR.
hj commented 2018-09-17 16:01:43 +00:00
Author
Member
Copy link

ok i wanted to change the way storage is saved - instead of having a whitelist of mutations that trigger saving actually triggering it programmatically by emitting some event but that would've involved either an empty mutation or rewriting persistent storage entirely and i don't want to do that yet.

Yes in the end there are two whitelists now instead of one, but one of the whitelists is much shorter now and other one doesn't really need to be touched that often so i think in the end it does resolve issues with "oh shit this setting doesn't save" and "oh shit this setting gets overwritten by instance's config"

On top of that, getting rid of throttling allows debugging these issues much better.

ok i wanted to change the way storage is saved - instead of having a whitelist of mutations that trigger saving actually triggering it programmatically by emitting some event but that would've involved either an empty mutation or rewriting persistent storage entirely and i don't want to do that yet. Yes in the end there are two whitelists now instead of one, but one of the whitelists is much shorter now and other one doesn't really need to be touched that often so i think in the end it does resolve issues with "oh shit this setting doesn't save" and "oh shit this setting gets overwritten by instance's config" On top of that, getting rid of throttling allows debugging these issues much better.
hj commented 2018-09-17 16:32:56 +00:00
Author
Member
Copy link

Seems to be working fine with latest changes...

Seems to be working fine with latest changes...
hj commented 2018-09-20 14:24:52 +00:00
Author
Member
Copy link

Added a display for instance default. Probably should make that somewhat universal in the future.
image

Added a display for instance default. Probably should make that somewhat universal in the future. ![image](/attachments/313b5741-62a4-412f-9ac0-6de61e86289c)
image.png
10 KiB
hj commented 2018-09-21 09:19:47 +00:00
Author
Member
Copy link

image
lgtm by shp on irc

![image](/attachments/f65f8fe7-159c-4b00-b6fe-90fdb7b4d26e) lgtm by shp on irc
image.png
4.2 KiB

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!1615
No description provided.