Fix Follow/Mute/Block not functional issue in the user search page #2023

Closed
tae wants to merge 0 commits from gitlab-mr-iid-754 into develop
Member

closes #492

closes #492

isn't this the same as #1969?

isn't this the same as https://git.pleroma.social/pleroma/pleroma-fe/pulls/1969?
Author
Member

oh, thanks for referring. will check it out.

oh, thanks for referring. will check it out.
Author
Member

yes, it is. But not exactly same. This resolves more. 😄

The prior MR does not fix a bug that "Follow" button is not synching with the global state.

Screenshot_at_Apr_12_08-05-54

yes, it is. But not exactly same. This resolves more. :smile: The prior MR does not fix a bug that "Follow" button is not synching with the global state. ![Screenshot_at_Apr_12_08-05-54](/attachments/a04c6c4c-82ca-424b-8400-026aa9a4f1a0)

LGTM

LGTM
Member

doesn't seem to be fixing anything to me

doesn't seem to be fixing anything to me
Author
Member

Well, the action buttons (follow/mute/block) are functional but don't change labels (states). This is because the page doesn't consume user objects from the global repository. The MR fixes this mess. Please let me know if this is not clear.

Well, the action buttons (follow/mute/block) are functional but don't change labels (states). This is because the page doesn't consume user objects from the global repository. The MR fixes this mess. Please let me know if this is not clear.
Member

last time i tested it they still didn't change labels

last time i tested it they still didn't change labels
Author
Member

Hmm, can you kindly retry? it must be working.

Hmm, can you kindly retry? it must be working.
Member

It works for me, @hj still broken for you? I tried on firefox

It works for me, @hj still broken for you? I tried on firefox
Member

i'll test tomorrow, too tired today sorry.

i'll test tomorrow, too tired today sorry.
Member

last time i tested it:

old develop on sgsgb: cards aren't updated
this MR: cards aren't updated

this time i'm testing it:

old develop on sgsgb: cards are updated
fresh local develop: cards are updated
this MR: cards are updated

last time i tested it: old develop on sgsgb: cards aren't updated this MR: cards aren't updated this time i'm testing it: old develop on sgsgb: cards are updated fresh local develop: cards are updated this MR: cards are updated
Member

I can however say that user cards (the collapsible ones) inside work better in this MR, so it fixes something.

It doesn't seem to be fixing the #492 but now i can't reproduce that bug now, so i guess issue is something else entirely?

I can however say that user cards (the collapsible ones) inside work better in this MR, so it fixes **something**. It doesn't seem to be fixing the #492 but now i can't reproduce that bug now, so i guess issue is something else entirely?
Author
Member

@hj I'm not sure why your testings went wrong. 🤷 So, I've tested this again on my end.

fresh local develop: 'Follow', 'Mute' and 'Block' buttons are not updated until refresh. video recording -> https://drive.google.com/open?id=1-1HWPXdJ9AoXsN6kru_F0FXMtFEu-qLS

this MR: The buttons are updated in real time. video recording -> https://drive.google.com/open?id=1cGG08mspM1uagSipOgAD9O64hYiyzP9D

@hj I'm not sure why your testings went wrong. :shrug: So, I've tested this again on my end. **fresh local develop:** 'Follow', 'Mute' and 'Block' buttons are not updated until refresh. video recording -> https://drive.google.com/open?id=1-1HWPXdJ9AoXsN6kru_F0FXMtFEu-qLS **this MR:** The buttons are updated in real time. video recording -> https://drive.google.com/open?id=1cGG08mspM1uagSipOgAD9O64hYiyzP9D
Member

oh so you mean THOSE cards, ok, sure.

oh so you mean THOSE cards, ok, sure.

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2023
No description provided.