Always show fresh relationship status in search, better error handling. #1969

Closed
lambadalambda wants to merge 2 commits from gitlab-mr-iid-699 into develop

This will no properly handle timeouts as well (it would just spin forever before)

Mass fetching ids did not work, i guess because the query array syntax is wrong.

This will no properly handle timeouts as well (it would just spin forever before) Mass fetching ids did not work, i guess because the query array syntax is wrong.
Member

I do not like the try/catch pattern, switching a promise to an async/await is good if it stays simple but here it's a tradeoff for the worse as we need a try/catch/finally too

I do not like the try/catch pattern, switching a promise to an async/await is good if it stays simple but here it's a tradeoff for the worse as we need a try/catch/finally too
Member

This seems unnecessary since the userSearch API returns "relationship" as well.

This seems unnecessary since the userSearch API returns "relationship" as well.
Author
Owner

I thought it didn't when I wrote it :) I'll check and remove it.

I thought it didn't when I wrote it :) I'll check and remove it.
Author
Owner

Solved in #2023 so closing here.

Solved in #2023 so closing here.
Member

@lambadalambda thank you for choosing my solution. 🌮

@lambadalambda thank you for choosing my solution. :taco:

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!1969
No description provided.