pleroma/pleroma-fe
2
2
Fork 4
Code Issues 344 Pull requests 27 Projects Releases Packages Wiki Activity

i18n/Add Japanese with kanji (2) #2085

Closed
hakabahitoyo wants to merge 2 commits from gitlab-mr-iid-816 into develop
pull from: gitlab-mr-iid-816
merge into: pleroma:develop
Conversation 7 Commits 2 Files changed 3 +405 -1
hakabahitoyo commented 2019-05-28 14:43:54 +00:00
Member
Copy link

Resolves #522.

Update version of #2079.

image

Resolves #522. Update version of #2079. ![image](/attachments/6be46dc2-a552-4113-86a1-1f4757e96a03)
image.png
2.4 MiB
hj commented 2019-05-28 15:11:07 +00:00
Owner
Copy link

no need for this.

The core idea is: ja.json has everything, ja_pedantic.json only has things that should be changed. For example both files have "title": "チャット" so it could be deleted from ja_pedantic.json, same goes for everything that's identical for both files. This would remove the need to update both files every time something is changed or added, less chance that someone forgets to update the other file, and also it would save space.

What this line does - it takes ja_pedantic.json and overrides things from it with everything in ja.json which is pointless.

I hope my explanation was easy to understand.

no need for this. The core idea is: `ja.json` has everything, `ja_pedantic.json` only has things that should be changed. For example both files have `"title": "チャット"` so it could be deleted from `ja_pedantic.json`, same goes for everything that's identical for both files. This would remove the need to update both files every time something is changed or added, less chance that someone forgets to update the other file, and also it would save space. What this line does - it takes `ja_pedantic.json` and overrides things from it with everything in `ja.json` which is pointless. I hope my explanation was easy to understand.
hakabahitoyo commented 2019-05-28 18:08:43 +00:00
Author
Member
Copy link

There are some concerns about that:

  1. The /src/i18n/compare tool does not suit for the partial (removing duplicates) resource.
  2. Duplicates between ja.json and js_pedantic.json are not so much. チッャト or all-katakana messages are less than 25 % of all.
  3. Fallbacking ja.json and ja_pedantic.json each other may better than fallbacking into English.
There are some concerns about that: 1. The `/src/i18n/compare` tool does not suit for the partial (removing duplicates) resource. 1. Duplicates between `ja.json` and `js_pedantic.json` are not so much. `チッャト` or all-katakana messages are less than 25 % of all. 1. Fallbacking `ja.json` and `ja_pedantic.json` each other may better than fallbacking into English.
hj commented 2019-05-28 18:17:16 +00:00
Owner
Copy link
  1. compare tool will be updated later to handle this case.
  2. still worth de-duplicating it imo
  3. it will fall back to english anyway if string is missing from both.

keeping strings duplicated it would lead to a messy state imo

1. compare tool will be updated later to handle this case. 2. still worth de-duplicating it imo 3. it will fall back to english anyway if string is missing from both. keeping strings duplicated it would lead to a messy state imo
hj commented 2019-05-28 19:00:32 +00:00
Owner
Copy link

And ja.json and ja_pedantic.json must be maintained separately. Removing duplicates forces extra work of us. Further I have no assumption about which of ja.json and ja_pedantic.json is mainline and is optional for future developers, symmetric fallbacking may be a good compromise.

dunno where gitlab shoved your comment but i got the email at least

>And ja.json and ja_pedantic.json must be maintained separately. Removing duplicates forces extra work of us. Further I have no assumption about which of ja.json and ja_pedantic.json is mainline and is optional for future developers, symmetric fallbacking may be a good compromise. dunno where gitlab shoved your comment but i got the email at least
hj commented 2019-05-28 19:01:21 +00:00
Owner
Copy link

ja.json is the "main" one because it will be used by default if user hasn't selected locale and his system locale is japanese.

ja.json is the "main" one because it will be used by default if user hasn't selected locale and his system locale is japanese.
hj commented 2019-05-28 19:02:26 +00:00
Owner
Copy link

if you want, i can remove duplicates for you after the merge if it's that hard. however falling back this way is still pointless imo - either there are duplicates and no fallback or no duplicates and one-way fallback

if you want, i can remove duplicates for you after the merge if it's that hard. however falling back this way is still pointless imo - either there are duplicates and no fallback or no duplicates and one-way fallback
hakabahitoyo commented 2019-05-29 00:49:36 +00:00
Author
Member
Copy link

Now I prefer there are duplicates and no fallback.

Now I prefer _there are duplicates and no fallback_.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2085
No description provided.