Overhaul user profile display. One task to rule them all. #215

Closed
opened 2018-12-13 15:19:13 +00:00 by hj · 4 comments
Owner

This is just one task that ecompasses all of these: #65 #111 #198 #199

Steps:

  • Change current display and switcher from two panel to one panel, use tab-switcher instead of whatever is there right now. All the refactoring that needs to be done goes in this step. #1699
    • Add posts without replies
    • Add favorites
    • Add media
      • Make media tab display images/videos/audio somewhat similar to how tusky handles it instead of showing posts
    • Add ability to hide followers/following/favorites depending on users's relevant privacy settings.

Overview

Several key points:

  • Right now user profile allows you to see:
  • All of the user's posts
  • Followers
  • Who user Follows
  • We also needs to add:
  • User's posts without replies
  • User's media (only posts containing media)
  • User's favorites/liked posts
  • ability to filter out repeats
  • Code regarding user timeline seems scattered all over the place, like some stuff related to switching between statuses/followers/follows is in modules/statuses.js, looks like it needs refactoring.

Mastodon shows "Posts/Posts with replies/media" under "Posts". Tusky also shows media in a different way than mastodon's profile page. Neither of those have "favorites" display, it's a bit of challenge to fit it in somewhere (esp if we don't have counter for it)

In addition, current switcher posts/following/followers confused some people. And honestly it feels very disconnected visually.

And finally with hide_network option we need to do something about not allowing users to view followers/follows or show some kind of error.

My proposition is to use single-level-depth switcher. Just a tab bar that has:

  • Posts
  • Posts with replies
  • Media
  • Following (if allowed)
  • Followers (if allowed)
  • Favorites (if allowed?)

Visually it should probably look something like this (artist rendition):
image

This is just one task that ecompasses all of these: #65 #111 #198 #199 ## Steps: * [x] Change current display and switcher from two panel to one panel, use `tab-switcher` instead of whatever is there right now. All the refactoring that needs to be done goes in this step. #1699 * [ ] Add posts without replies * [x] Add favorites * [x] Add media * [ ] Make media tab display images/videos/audio somewhat similar to how tusky handles it instead of showing posts * [x] Add ability to hide followers/following/favorites depending on users's relevant privacy settings. ## Overview Several key points: * Right now user profile allows you to see: * All of the user's posts * Followers * Who user Follows * We also needs to add: * User's posts without replies * User's media (only posts containing media) * User's favorites/liked posts * ability to filter out repeats * Code regarding user timeline seems scattered all over the place, like some stuff related to switching between statuses/followers/follows is in `modules/statuses.js`, looks like it needs refactoring. Mastodon shows "Posts/Posts with replies/media" under "Posts". Tusky also shows media in a different way than mastodon's profile page. Neither of those have "favorites" display, it's a bit of challenge to fit it in somewhere (esp if we don't have counter for it) In addition, current switcher posts/following/followers confused *some* people. And honestly it feels very disconnected visually. And finally with `hide_network` option we need to do something about not allowing users to view followers/follows or show some kind of error. My proposition is to use single-level-depth switcher. Just a tab bar that has: * Posts * Posts with replies * Media * Following (if allowed) * Followers (if allowed) * Favorites (if allowed?) Visually it should probably look something like this (artist rendition): ![image](/uploads/2bed89fdf911c92dce06ea86018c668b/image.png)
Author
Owner

@shpuld i need your opinion on this

@shpuld i need your opinion on this
Owner

No objections to anything

No objections to anything
Member

I've proposed a server-side filter for reposts in pleroma/pleroma#3991 that may be helpful in filtering out repeats.

I've proposed a server-side filter for reposts in pleroma/pleroma#3991 that may be helpful in filtering out repeats.
Author
Owner

Gonna close this now since most of it got implemented.

Gonna close this now since most of it got implemented.
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe#215
No description provided.