Small refactor for followers/friends, change display to use tabs instead of "leaky brains" #1699

Closed
hj wants to merge 0 commits from gitlab-mr-iid-427 into develop
Owner

Closes #111

First and foremost checkbox in #215

  • Friends/Followers-related code removed from Timeline component/statuses module and moved to User Profile component/users module.

  • Stores follows/followers in user object instead of timeline. Currently doesn't clean up on exit, but checks if there already fetched data available.

  • Timeline now has another property embedded which disables panel classes, making timeline easily embeddable within other components.

  • Small display fixes for relevant parts.

Closes #111 First and foremost checkbox in #215 * Friends/Followers-related code removed from Timeline component/statuses module and moved to User Profile component/users module. * Stores follows/followers in user object instead of timeline. Currently doesn't clean up on exit, but checks if there already fetched data available. * Timeline now has another property `embedded` which disables `panel` classes, making timeline easily embeddable within other components. * Small display fixes for relevant parts.
Owner

I don't get what's going on in here, you make a const, mutate it, and then don't do anything with it?

I don't get what's going on in here, you make a const, mutate it, and then don't do anything with it?
Author
Owner

This could be inlined as state.usersObject[id].friends = friends

This could be inlined as `state.usersObject[id].friends = friends`
Owner

then I would keep it inlined, still it's super weird to modify the state like that, even if it works. is there no way to do it via a dispatch or something?

then I would keep it inlined, still it's super weird to modify the state like that, even if it works. is there no way to do it via a dispatch or something?
Author
Owner

Um... this IS mutations object...

Um... this IS `mutations` object...
Owner

wait my bad, shouldn't read through stuff when sick, all good then

wait my bad, shouldn't read through stuff when sick, all good then

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1699
No description provided.