pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Display profile fields #2271

Closed
kphrx wants to merge 0 commits from gitlab-mr-iid-1004 into develop
pull from: gitlab-mr-iid-1004
merge into: pleroma:develop
Conversation 56 Commits - Files changed -
kphrx commented 2019-11-17 17:26:29 +00:00
Member
Copy link

refs #149

  • Rebasing after merge the #2262.
refs #149 * [x] Rebasing after merge the #2262.
hj commented 2019-11-19 16:53:53 +00:00
Owner
Copy link

please use classnames instead of tags

please use classnames instead of tags
hj commented 2019-11-19 16:55:18 +00:00
Owner
Copy link

this could use a text-align: right, some users have field names set to single emoji which makes whole thing ugly.

this could use a `text-align: right`, some users have field names set to single emoji which makes whole thing ugly.
hj commented 2019-11-19 16:57:33 +00:00
Owner
Copy link

i feel like this is superfluous, just leave fields_html one

i feel like this is superfluous, just leave `fields_html` one
hj commented 2019-11-19 17:00:40 +00:00
Owner
Copy link

both of them could use a :title="user.fields[index].name (or .value obviously) if field data overflows there's no way to read it fully.

otherwise might make text use multiple lines instead of eliding it.

both of them could use a `:title="user.fields[index].name` (or `.value` obviously) if field data overflows there's no way to read it fully. otherwise might make text use multiple lines instead of eliding it.
kphrx commented 2019-11-20 10:28:16 +00:00
Author
Member
Copy link

Added d2e334da

Added d2e334da
kphrx commented 2019-11-20 10:28:33 +00:00
Author
Member
Copy link

a15baa89

a15baa89
kphrx commented 2019-11-20 10:28:50 +00:00
Author
Member
Copy link

Added bfdf7c87

Added bfdf7c87
kphrx commented 2019-11-20 10:29:06 +00:00
Author
Member
Copy link

Replaced 87940ead

Replaced 87940ead
feld commented 2019-11-27 15:40:06 +00:00
Owner
Copy link

checking in on this

checking in on this
shpuld commented 2019-12-02 11:58:59 +00:00
Owner
Copy link

looks fine to me, ready to merge @kPherox ? I'm a bit lost with what the merge order should be with many profile field related things

looks fine to me, ready to merge @kPherox ? I'm a bit lost with what the merge order should be with many profile field related things
kphrx commented 2019-12-02 12:23:22 +00:00
Author
Member
Copy link

#2271 and #2264 should not affect each other. So I think any merge order is okey.

#2271 and #2264 should not affect each other. So I think any merge order is okey.
kphrx commented 2020-02-10 16:15:44 +00:00
Author
Member
Copy link

TypeError is thrown because remote account's source fields is empty array. Need to convert fields to plain text in frontend or backend.

`TypeError` is thrown because remote account's source fields is empty array. Need to convert fields to plain text in frontend or backend.
kphrx commented 2020-02-19 12:20:56 +00:00
Author
Member
Copy link

Fixed 064b5981

Fixed 064b5981
hj commented 2020-03-11 17:21:05 +00:00
Owner
Copy link

what's this, again?

what's this, again?
hj commented 2020-03-11 17:21:40 +00:00
Owner
Copy link

i think we already have an html sanitizer in place

i think we already have an html sanitizer in place
kphrx commented 2020-03-11 18:30:44 +00:00
Author
Member
Copy link

fields_text for tooltip of fields.

Currently, pleroma backend doesn't have source fields for remote users, and local users can use html tags in fields. So I thought it was necessary for plain text.

`fields_text` for tooltip of fields. Currently, pleroma backend doesn't have source fields for remote users, and local users can use html tags in fields. So I thought it was necessary for plain text.
hj commented 2020-03-11 18:46:45 +00:00
Owner
Copy link

use escape-html, it should be used elsewhere in the file

use `escape-html`, it should be used elsewhere in the file
lambadalambda commented 2020-06-15 12:50:23 +00:00
Owner
Copy link

Don't know if this is a problem of recent changes in the frontend, but this looks a bit weird / out of place at them moment with develop merged in.

Screenshot_2020-06-15_dontbulling_me

Don't know if this is a problem of recent changes in the frontend, but this looks a bit weird / out of place at them moment with develop merged in. ![Screenshot_2020-06-15_dontbulling_me](/attachments/d78db264-a30a-46ed-abd4-88a3b256f75d)
Screenshot_2020-06-15_dontbulling_me.png
303 KiB
shpuld commented 2020-06-17 08:27:59 +00:00
Owner
Copy link

does a completely different thing, what we want is <a>shpposter.club</a> becoming shpposter.club and not &lt;a&gt;shpposter.club&lt;/a&gt;

does a completely different thing, what we want is `<a>shpposter.club</a>` becoming `shpposter.club` and not `&lt;a&gt;shpposter.club&lt;/a&gt;`
shpuld commented 2020-06-17 08:38:03 +00:00
Owner
Copy link

doesn't look like it, we have unescape and escape and html processor, but not something that just strips the tags

doesn't look like it, we have unescape and escape and html processor, but not something that just strips the tags
shpuld commented 2020-06-17 08:46:36 +00:00
Owner
Copy link

it's not really a problem, that's just how it looks like when you have shorter entries. here's what it looks like "in the wild"

image

it's not really a problem, that's just how it looks like when you have shorter entries. here's what it looks like "in the wild" ![image](/attachments/75b38615-852b-424a-947f-649816a99e6c)
image.png
132 KiB
lambadalambda commented 2020-06-17 12:41:35 +00:00
Owner
Copy link

True, looks more sensible with longer entries.

True, looks more sensible with longer entries.
lambadalambda commented 2020-06-17 12:42:11 +00:00
Owner
Copy link

Why does this need to be stripped anyway?

Why does this need to be stripped anyway?
shpuld commented 2020-06-17 12:47:23 +00:00
Owner
Copy link

the title attribute wants a plaintext version of it, the actual field value will still use emojified html

the title attribute wants a plaintext version of it, the actual field value will still use emojified html
shpuld commented 2020-06-17 12:55:30 +00:00
Owner
Copy link

I'm looking into it a bit to see if it can be made nicer, it's a bit awkward on mobile

I'm looking into it a bit to see if it can be made nicer, it's a bit awkward on mobile
shpuld commented 2020-06-17 15:03:01 +00:00
Owner
Copy link

image

what do you think of this?

![image](/attachments/ac3e1263-08dc-4ef0-b05f-919a6129ad88) what do you think of this?
image.png
214 KiB
lambadalambda commented 2020-06-17 15:05:58 +00:00
Owner
Copy link

I like it more than the original, makes it clearer that these are profile fields and not just some random text floating around

I like it more than the original, makes it clearer that these are profile fields and not just some random text floating around
shpuld commented 2020-06-17 15:09:15 +00:00
Owner
Copy link

works decent on mobile too I guess, picture with longer fields

localhost_8080_users_9gOkLxPxM19NQGrII4_iPhone_5_SE_

works decent on mobile too I guess, picture with longer fields ![localhost_8080_users_9gOkLxPxM19NQGrII4_iPhone_5_SE_](/attachments/b9c6cbe4-6343-47c6-b313-6443677020d7)
localhost_8080_users_9gOkLxPxM19NQGrII4_iPhone_5_SE_.png
354 KiB
shpuld commented 2020-06-17 15:13:58 +00:00
Owner
Copy link

I'll make a new MR with the modifications, since I can't push into @kPherox's branches, but I think it should be just about done

I'll make a new MR with the modifications, since I can't push into @kPherox's branches, but I think it should be just about done
kphrx commented 2020-06-17 15:23:48 +00:00
Author
Member
Copy link

I has set to allow commits from members who can merge into the target branch, but doesn't work it?

I has set to allow commits from members who can merge into the target branch, but doesn't work it?
shpuld commented 2020-06-17 15:24:27 +00:00
Owner
Copy link

ah, I didn't know that's possible! no need for that then

ah, I didn't know that's possible! no need for that then
hj commented 2020-06-17 15:35:42 +00:00
Owner
Copy link

it kinda looks bad but then again the feature itself is kinda shit anyway, can't win.

it kinda looks bad but then again the feature itself is kinda shit anyway, can't win.
shpuld commented 2020-06-17 15:36:09 +00:00
Owner
Copy link

very constructive thank you

very constructive thank you
lambadalambda commented 2020-06-17 15:51:21 +00:00
Owner
Copy link

The 'allow commits form members' thing does work, but it's a bit annoying to use. I gave you developer access, @kPherox, so you can just branch in the main repo next time so this is easier.

The 'allow commits form members' thing does work, but it's a bit annoying to use. I gave you developer access, @kPherox, so you can just branch in the main repo next time so this is easier.
shpuld commented 2020-06-17 15:53:35 +00:00
Owner
Copy link

somehow figured out how to push local changes to remote branch, I'm a git pro now

somehow figured out how to push local changes to remote branch, I'm a git pro now
shpuld commented 2020-06-17 15:54:33 +00:00
Owner
Copy link

added unescape so that &gt; will be > in the text fields like it should

added unescape so that `&gt;` will be `>` in the text fields like it should
lambadalambda commented 2020-06-17 15:58:51 +00:00
Owner
Copy link

LGTM

LGTM
hj commented 2020-06-17 21:00:42 +00:00
Owner
Copy link

sorry i really don't have much to add right now, i am however thinking about full profile redesign and how to make it more consistent and eye-pleasing overall. More presentable.

Fields don't really fit in there but then barely anything fits. I can at least say that frames are somewhat better than what was before

sorry i really don't have much to add right now, i am however thinking about full profile redesign and how to make it more consistent and eye-pleasing overall. More presentable. Fields don't really fit in there but then barely anything fits. I can at least say that frames are somewhat better than what was before
hj commented 2020-06-17 21:01:19 +00:00
Owner
Copy link

LGTM too

LGTM too
gitlab-ghost-3733 commented 2020-06-17 22:00:25 +00:00
Member
Copy link

yay

yay
lanodan commented 2020-06-17 22:30:30 +00:00
Owner
Copy link

Kind of a nitpick: I think it's a bit weird to have this kind of separation between the key and the value, I think joining the border between the key and value would be better, I guess this would mean a table instead of a definition list.

Kind of a nitpick: I think it's a bit weird to have this kind of separation between the key and the value, I think joining the border between the key and value would be better, I guess this would mean a table instead of a definition list.
kphrx commented 2020-06-18 03:18:55 +00:00
Author
Member
Copy link

I think a definition list is a better way to express a profile fields, so I'll try adjusting the css so that the key-value looks like one.

I think a definition list is a better way to express a profile fields, so I'll try adjusting the css so that the key-value looks like one.
shpuld commented 2020-06-18 05:49:10 +00:00
Owner
Copy link

I started doing that originally but the css was getting ugly, figured it's clear enough when you never have more than two columns and with the text alignment it'd still be clear as day

I started doing that originally but the css was getting ugly, figured it's clear enough when you never have more than two columns and with the text alignment it'd still be clear as day
lambadalambda commented 2020-06-18 10:36:41 +00:00
Owner
Copy link

I'd rather get this in now and play with the css later, otherwise this will wait around for another 6 months...

I'd rather get this in now and play with the css later, otherwise this will wait around for another 6 months...
kphrx commented 2020-06-18 11:15:54 +00:00
Author
Member
Copy link

before: 632f62ee
Screen_Shot_2020-06-18_at_20.01.37

after: eed58a7b
image

before: 632f62ee ![Screen_Shot_2020-06-18_at_20.01.37](/attachments/05d402be-0471-46a9-bf00-85106748e5a3) after: eed58a7b ![image](/attachments/dba969ec-70d0-4854-8297-ca576243286c)
Screen_Shot_2020-06-18_at_20.01.37.png
56 KiB
image.png
52 KiB
shpuld commented 2020-06-18 11:25:40 +00:00
Owner
Copy link

looks better in 99% cases, but on chrome it creates 1px gaps between the separating line and top/bottom lines on some zoom levels which is the issue I encountered with the approach when trying it out

however I don't think it's big enough of a deal to block the merge request if people prefer this look

image

looks better in 99% cases, but on chrome it creates 1px gaps between the separating line and top/bottom lines on some zoom levels which is the issue I encountered with the approach when trying it out however I don't think it's big enough of a deal to block the merge request if people prefer this look ![image](/attachments/8bdf8a14-9ce7-4667-9de5-4246ae6dc079)
image.png
32 KiB
lambadalambda commented 2020-06-18 11:33:46 +00:00
Owner
Copy link

The new one does indeed look better. I only noticed the gap because i knew where to look :) I think this is ready.

The new one does indeed look better. I only noticed the gap because i knew where to look :) I think this is ready.
hj commented 2020-06-18 12:48:39 +00:00
Owner
Copy link

random idea: how about this layout:
image

random idea: how about this layout: ![image](/attachments/8c6c8941-09dd-49b8-ad1c-07566113a1e7)
image.png
20 KiB
shpuld commented 2020-06-18 12:51:14 +00:00
Owner
Copy link

don't bother I'd say, it'd be a way to make it look even more one sided and cramped

don't bother I'd say, it'd be a way to make it look even more one sided and cramped
hj commented 2020-06-18 12:51:54 +00:00
Owner
Copy link

at least it won't cut off the the field "key"

at least it won't cut off the the field "key"
lambadalambda commented 2020-06-18 13:01:06 +00:00
Owner
Copy link

Just for comparison, here is how soapbox and mastodon do it:

###Soapbox:

Screenshot_2020-06-18__1__lain_mastodon_online_lain_com_1_

###Mastodon:

Screenshot_2020-06-18_Mastodon

Just for comparison, here is how soapbox and mastodon do it: ###Soapbox: ![Screenshot_2020-06-18__1__lain_mastodon_online_lain_com_1_](/attachments/e457dbf9-c882-43c7-957f-edf164c03d21) ###Mastodon: ![Screenshot_2020-06-18_Mastodon](/attachments/2ff865d9-f973-4561-93dd-62b4fe938ebb)
Screenshot_2020-06-18__1__lain_mastodon_online_lain_com_1_.png
180 KiB
Screenshot_2020-06-18_Mastodon.png
238 KiB
shpuld commented 2020-06-18 13:02:10 +00:00
Owner
Copy link

keeping them short is a good idea regardless, unless you want to encourage people to set them to lengths that are cut off in mastodon. the min width of the key column is set to this width consciously

keeping them short is a good idea regardless, unless you want to encourage people to set them to lengths that are cut off in mastodon. the min width of the key column is set to this width consciously
lambadalambda commented 2020-06-18 13:02:48 +00:00
Owner
Copy link

yeah, long keys are possible but lead to display problems on pretty much every client

yeah, long keys are possible but lead to display problems on pretty much every client
lanodan commented 2020-06-18 15:34:06 +00:00
Owner
Copy link

Well, looks good to me 👍

Well, looks good to me 👍
gitlab-ghost-3733 commented 2020-06-18 15:51:25 +00:00
Member
Copy link

I like!

I like!
shpuld commented 2020-06-19 08:04:31 +00:00
Owner
Copy link

merging it finally, further improvements in further MRs mmkay

merging it finally, further improvements in further MRs mmkay

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
7 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2271
No description provided.