Can't clear avatar, profile banner or profile background #353

Closed
opened 2019-02-12 19:45:25 +00:00 by mfashby · 16 comments
Member

Actual behaviour:
Once you have set any of the above in user settings, you can't unset them.

Desired behaviour:
I should be able to change my mind about having a profile banner or background.

Actual behaviour: Once you have set any of the above in user settings, you can't unset them. Desired behaviour: I should be able to change my mind about having a profile banner or background.
Member

Dupe of #273 . I'm working on it.

Dupe of #273 . I'm working on it.
Member

There is no way to get their defaults for now.

There is no way to get their defaults for now.
Member

I'm researching what the best way would be. Do you have any idea?

I'm researching what the best way would be. Do you have any idea?
Member

Avatar default : /images/avi.png
Banner default : /images/banner.png

I'm wondering if I can use these static urls as default.

Avatar default : /images/avi.png Banner default : /images/banner.png I'm wondering if I can use these static urls as default.

we actually need a way to set a nil avatar back, so the default will come back up. we can not just use some static url.

we actually need a way to set a nil avatar back, so the default will come back up. we can not just use some static url.
Owner

yeah, is it possible to update avatar/banner/background to undefined or null?

yeah, is it possible to update avatar/banner/background to `undefined` or `null`?
Member

We need to update the BE to reset avatar, banner, and background images to nil.

We need to update the BE to reset avatar, banner, and background images to nil.
Member

Maybe a new endpoint. @lambadalambda if you approve, I will update the back-end.

Maybe a new endpoint. @lambadalambda if you approve, I will update the back-end.

I'd suggest to switch to the mastoapi 'update_credentials' endpoint for at least banner and avatar and allow those endpoints to remove the banner / avatar by sending a nil.

I'd suggest to switch to the mastoapi 'update_credentials' endpoint for at least banner and avatar and allow those endpoints to remove the banner / avatar by sending a nil.
Member

makes sense.

makes sense.
Member

Good suggestion. I'll try with the way.

Good suggestion. I'll try with the way.
Owner

We just merged support for this in the backend

pleroma/pleroma#4572

We just merged support for this in the backend https://git.pleroma.social/pleroma/pleroma/pulls/4572
Member

pushed FE support for this. Took some ideas from the old branch that was trying to do this.

pushed FE support for this. Took some ideas from the old branch that was trying to do this.
Member

BE returns different things for /api/v1/accounts/update_credentials and /api/v1/accounts/update_avatar. The later seems to return a user with all fields set to undefined.

BE returns different things for `/api/v1/accounts/update_credentials` and `/api/v1/accounts/update_avatar`. The later seems to return a user with all fields set to undefined.
Member

@feld added my notes on BE here pleroma#899.
The FE MR works properly, I think that is the one last issue.

@feld added my notes on BE here [pleroma#899](https://git.pleroma.social/pleroma/pleroma/issues/899). The FE MR works properly, I think that is the one last issue.
Owner

done

done
Sign in to join this conversation.
No milestone
No project
No assignees
8 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe#353
No description provided.