pleroma/pleroma-fe
2
1
Fork 2
Code Issues 345 Pull requests 30 Projects Releases Packages Wiki Activity

WIP: #353 - add reset button for avatar, banner, profile images #1855

Closed
Dave wants to merge 13 commits from gitlab-mr-iid-585 into develop
pull from: gitlab-mr-iid-585
merge into: pleroma:develop
Conversation 11 Commits 13 Files changed 6 +1139 -23
Dave commented 2019-02-15 04:04:06 +00:00
Member
Copy link

Issue #353 - Add reset buttons for avatar, banner, and profile images

no_reset_with_default

reset

Issue #353 - Add reset buttons for avatar, banner, and profile images ![no_reset_with_default](/attachments/875fefe4-82f1-49f6-8811-a3bba115055c) ![reset](/attachments/74d18ba0-1ed8-4111-ac8f-a96af677e9fc)
reset.png
51 KiB
no_reset_with_default.png
26 KiB
tae commented 2019-02-17 19:53:37 +00:00
Member
Copy link

I think it is more clear to check the existence of params.banner rather than this. And for a long-term solution, we need to get is_default_banner as the API response.

I think it is more clear to check the existence of `params.banner` rather than this. And for a long-term solution, we need to get `is_default_banner` as the API response.
tae commented 2019-02-17 20:19:25 +00:00
Member
Copy link

Naming of these function submitAvatar and uploadAvatar makes me confused in the perspective of view.
I suggest submitAvatar, resetAvatar (for the view), and updateAvatar (which is commonly used internally by the prior functions) 😄
Same for the other subjects.

Naming of these function `submitAvatar` and `uploadAvatar` makes me confused in the perspective of view. I suggest `submitAvatar`, `resetAvatar` (for the view), and `updateAvatar` (which is commonly used internally by the prior functions) :smile: Same for the other subjects.
Dave commented 2019-02-18 14:38:26 +00:00
Author
Member
Copy link

Good point. I update the BE and FE.

Good point. I update the BE and FE.
Dave commented 2019-02-18 14:42:21 +00:00
Author
Member
Copy link

I agree. At first, I added these 3 functions - submit, reset, and update. But reset and submit were almost identical. And I tried to remove the unnecessary ones.

If it makes the ease of understanding, I will update that.

I agree. At first, I added these 3 functions - submit, reset, and update. But reset and submit were almost identical. And I tried to remove the unnecessary ones. If it makes the ease of understanding, I will update that.
tae commented 2019-02-18 15:21:14 +00:00
Member
Copy link

Awesome! One more thing, I believe we need to show a confirm modal before resetting them.

Awesome! One more thing, I believe we need to show a `confirm` modal before resetting them.
shpuld commented 2019-02-20 14:38:33 +00:00
Owner
Copy link

Resetting banner doesn't work for me, on firefox

Resetting banner doesn't work for me, on firefox
Dave commented 2019-02-20 14:40:38 +00:00
Author
Member
Copy link

It won't work unless you run the back-end locally.

I also updated the BE and it needs to be merged prior to this one.

It won't work unless you run the back-end locally. I also updated the BE and it needs to be merged prior to this one.
shpuld commented 2019-02-20 14:43:08 +00:00
Owner
Copy link

oh, would be nice to put that sort of information in the descrption :p

oh, would be nice to put that sort of information in the descrption :p
Dave commented 2019-02-20 14:44:06 +00:00
Author
Member
Copy link

;) sorry about that. will try to add more details from the next time.

;) sorry about that. will try to add more details from the next time.
shpuld commented 2019-02-28 17:05:22 +00:00
Owner
Copy link

Is the BE part merged?

Is the BE part merged?
Dave commented 2019-02-28 17:06:38 +00:00
Author
Member
Copy link

@shpuld not yet. It's still pending.

@shpuld not yet. It's still pending.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1855
No description provided.