Web Push Notifications setting not synced with FE default #400

Closed
opened 2019-02-26 21:35:05 +00:00 by feld · 9 comments
Owner

I deploy the FE with the Web Push Notifications enabled by default, but the checkbox in user settings is unchecked even though it works and is enabled.

I deploy the FE with the Web Push Notifications enabled by default, but the checkbox in user settings is unchecked even though it works and is enabled.
Owner

@feld web push notifications is a user setting, not a instance setting, it's there if user wants to opt out of terrible and uselesess web push notifications. Not everyone wants web push. Currently they are off by default because there are some problems with them and specifically problems when using local dev environment (double push notifications!)

@feld web push notifications is a user setting, not a instance setting, it's there if user wants to opt out of ~~terrible and uselesess~~ web push notifications. Not everyone wants web push. Currently they are off by default because there are some problems with them and specifically problems when using local dev environment (double push notifications!)
Author
Owner

I changed it in the FE code before compiling it so it's enabled by default. We want it on by default. They actually work, whereas we saw no notifications without.

When enabled in the FE code by default, the checkbox doesn't seem aware

I changed it in the FE code before compiling it so it's enabled by default. We want it on by default. They actually work, whereas we saw no notifications without. When enabled in the FE code by default, the checkbox doesn't seem aware
Owner

no we don't want it on by default, it causes troubles and its usefullness is limited. #1893 is however adding admin control so you can enable it if you want half-baked notifications enabled by default.

no we don't want it on by default, it causes troubles and its usefullness is limited. #1893 is however adding admin control so you can enable it if you want half-baked notifications enabled by default.
Owner

also what do you mean "changed it in the FE code"?

also what do you mean "changed it in the FE code"?
Author
Owner

image

Our users wanted notifications in their browsers. I made this change. Everyone is happy. We do not have duplicate notifications. Nothing is broken. I don't know what it is that you're referring to about things being half-baked or broken.

![image](/attachments/9adecb21-e3f4-42a4-b161-e8ed7c2abe13) Our users wanted notifications in their browsers. I made this change. Everyone is happy. We do not have duplicate notifications. Nothing is broken. I don't know what it is that you're referring to about things being half-baked or broken.
Owner

web push titles and contents are not syncd with FE-provided ones.
web push mentions only show useless @xxx mentioned you and no actual title.

also changing it there will change default for users who didn't touch that setting yet, but if they did it will change nothing.

web push titles and contents are not syncd with FE-provided ones. web push mentions only show useless `@xxx mentioned you` and no actual title. also changing it there ***will*** change default for users who didn't touch that setting yet, but if they did it will change nothing.
Author
Owner

I've already got that fix in progress in the BE. Web push notifications are going to be much more useful soon.

Yes, we did want to change the default for users that didn't touch the setting yet.

This issue is about that checkbox not being displayed as checked by default, so the value is assumed to be off by default instead of verifying the default value provided by the FE.

I've already got that fix in progress in the BE. Web push notifications are going to be much more useful soon. Yes, we did want to change the default for users that didn't touch the setting yet. This issue is about that checkbox not being displayed as checked by default, so the value is assumed to be off by default instead of verifying the default value provided by the FE.
Owner

if checkbox is off that means it's off and user touched the setting

if checkbox is off that means it's off and user touched the setting

@feld have you still experienced this?

@feld have you still experienced this?
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe#400
No description provided.