pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Notifications tab #1893

Closed
edijs wants to merge 11 commits from gitlab-mr-iid-623 into develop
pull from: gitlab-mr-iid-623
merge into: pleroma:develop
Conversation 20 Commits 11 Files changed 26 +318 -177
edijs commented 2019-02-28 03:03:37 +00:00
Member
Copy link

Closes #401 and #400

Closes #401 and #400
shpuld commented 2019-02-28 17:57:23 +00:00
Owner
Copy link

@hj care to double check if the config/instance stuff is correct and the way we want it? it always confuses me and I'm unsure.

@hj care to double check if the config/instance stuff is correct and the way we want it? it always confuses me and I'm unsure.
hj commented 2019-02-28 18:11:14 +00:00
Owner
Copy link

why?

why?
hj commented 2019-02-28 18:12:27 +00:00
Owner
Copy link

removed and not added anywhere

removed and not added anywhere
hj commented 2019-02-28 18:19:09 +00:00
Owner
Copy link
  1. Does not resolve #401:
  • No granular control over web-push
  • Granular control over notifications still affects everything, not just notifications panel. See also: #232
  1. Adding admin control is good, but I'd love to see that option grayed out of web push notifications are disabled on BE if it's even possible.
1. Does not resolve #401: * No granular control over web-push * Granular control over notifications still affects everything, not just notifications panel. See also: #232 2. Adding admin control is good, but I'd love to see that option grayed out of web push notifications are disabled on BE if it's even possible.
edijs commented 2019-02-28 18:30:37 +00:00
Author
Member
Copy link

Added here.

#1893/diffs

Added here. https://git.pleroma.social/pleroma/pleroma-fe/pulls/1893/diffs#7e3833351c390d6674187f2cf39005b92ca25aba_272_233
edijs commented 2019-02-28 18:37:09 +00:00
Author
Member
Copy link

Moving web push notification setting to instance setting by default. User can update this setting as well.

Moving web push notification setting to instance setting by default. User can update this setting as well.
hj commented 2019-02-28 18:41:21 +00:00
Owner
Copy link

ok, i see now

ok, i see now
hj commented 2019-02-28 18:41:53 +00:00
Owner
Copy link

you're not moving, you're adding so keep it in, and change it to undefined

you're not *moving*, you're *adding* so keep it in, and change it to `undefined`
hj commented 2019-02-28 18:42:11 +00:00
Owner
Copy link

like other one with // instance default

like other one with // instance default
edijs commented 2019-03-01 22:02:12 +00:00
Author
Member
Copy link

@feld , @hj do you think this notification control table is correct? ^

@feld , @hj do you think this notification control table is correct? ^
hj commented 2019-03-02 15:48:55 +00:00
Owner
Copy link

what "always/optional" means?

what "always/optional" means?
edijs commented 2019-03-03 23:31:42 +00:00
Author
Member
Copy link

Mention will Always be visible in notifications column regardless of mention option is toggled in settings panel for example.

Optional means the status notification will be displayed if the option is active in settings panel.

Mention will `Always` be visible in notifications column regardless of mention option is toggled in settings panel for example. `Optional` means the status notification will be displayed if the option is active in settings panel.
shpuld commented 2019-03-07 16:30:38 +00:00
Owner
Copy link

why are these gone?

why are these gone?
shpuld commented 2019-03-07 16:31:45 +00:00
Owner
Copy link

I don't think notifications column should show things you don't want to see either, we don't want to remove the functionality to not see certain types of notifications if that's what the user wants

I don't think notifications column should show things you don't want to see either, we don't want to remove the functionality to not see certain types of notifications if that's what the user wants
edijs commented 2019-03-07 16:34:01 +00:00
Author
Member
Copy link

This is what @feld requested in issue #401

Additionally, when you disable the Favorites notifications, they disappear from the Notifications panel. This is confusing behavior. The Notifications Panel should not have items removed simply because you want to stop the Web Push Notifications for a specific type of activity.

This is what @feld requested in issue #401 > Additionally, when you disable the Favorites notifications, they disappear from the Notifications panel. This is confusing behavior. The Notifications Panel should not have items removed simply because you want to stop the Web Push Notifications for a specific type of activity.
edijs commented 2019-03-07 16:36:29 +00:00
Author
Member
Copy link

@shpuld should we add new settings for notifications panel?

@shpuld should we add new settings for notifications panel?
shpuld commented 2019-03-07 16:43:27 +00:00
Owner
Copy link

Yeah maybe it'd be better to have a tick box matrix that lets you individually enable notifications for the web UI and push

Yeah maybe it'd be better to have a tick box matrix that lets you individually enable notifications for the web UI and push
hj commented 2019-03-07 17:34:13 +00:00
Owner
Copy link

also i still don't understand the optional/always means, can't it be less confusing? also no need for auto-read since it's just an example of possible new feature

also i still don't understand the optional/always means, can't it be less confusing? also no need for auto-read since it's just an example of possible new feature
edijs commented 2019-03-07 17:44:15 +00:00
Author
Member
Copy link

You can ignore it.

You can ignore it.
edijs commented 2019-03-12 02:26:31 +00:00
Author
Member
Copy link

@hj please check again

@hj please check again

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1893
No description provided.