pleroma/pleroma-fe
3
2
Fork 5
Code Issues 345 Pull requests 27 Projects Releases Packages Wiki Activity

Show admin or moderator box if user has that role #1523

Closed
andrewzah wants to merge 1 commit from gitlab-mr-iid-250 into develop
pull from: gitlab-mr-iid-250
merge into: pleroma:develop
Conversation 5 Commits 1 Files changed 2 +19 -1
andrewzah commented 2018-04-26 21:03:38 +00:00
Member
Copy link

The user card now shows if they are an admin or moderator.
Admin supercedes moderator, and only one is shown.

box_with_admin
box_with_moderator

Closes #94

This MR depends on pleroma/pleroma#3529, in order to get the new is_admin and is_moderator JSON fields.

The user card now shows if they are an `admin` or `moderator`. Admin supercedes moderator, and only one is shown. ![box_with_admin](/attachments/d1cd9e90-8c82-44e5-b739-9ae8685856a1) ![box_with_moderator](/attachments/99fdd61d-5419-48be-9d53-1af5d28f3a7a) Closes #94 This MR depends on https://git.pleroma.social/pleroma/pleroma/pulls/3529, in order to get the new `is_admin` and `is_moderator` JSON fields.
box_with_admin.png
134 KiB
box_with_moderator.png
138 KiB
shpuld commented 2018-12-13 15:01:54 +00:00
Owner
Copy link

Code itself looks fine, but is this something that should be configurable? I can imagine not every admin/moderator wants to advertise this fact.

Code itself looks fine, but is this something that should be configurable? I can imagine not every admin/moderator wants to advertise this fact.
andrewzah commented 2018-12-13 15:58:35 +00:00
Author
Member
Copy link

Yeah it should probably be configurable somewhere. Either in pleroma's config or on a per-user basis otherwise.

It's been 7 months since I've looked at this codebase; feel free to take ownership of this code. I don't have the time right now to work on it.

Yeah it should probably be configurable somewhere. Either in pleroma's config or on a per-user basis otherwise. It's been 7 months since I've looked at this codebase; feel free to take ownership of this code. I don't have the time right now to work on it.
feld commented 2018-12-18 15:38:02 +00:00
Owner
Copy link

Can we revive this and make it display the different tags a user has?

Can we revive this and make it display the different tags a user has?
hj commented 2018-12-18 15:42:29 +00:00
Owner
Copy link

sure

sure
hj commented 2018-12-20 05:24:05 +00:00
Owner
Copy link

This depends on nonexistent API. BE MR it references didn't get merged in, and the one that did get merged in seem to be missing is_admin and is_moderator fields.

This depends on nonexistent API. BE MR it references didn't get merged in, and the one that did get merged in seem to be missing `is_admin` and `is_moderator` fields.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1523
No description provided.