WIP:Automatically switch to timeline-view when clicking on a notification #1678

Closed
succfemboi wants to merge 1 commit from gitlab-mr-iid-406 into develop
Member

At my phone on the notifications-panel, if I try to click on the top-right number a on a notification, I then need to scroll up and click on the "Timeline"-button to view the whole post-thread, associated with the notification.

With this change, clicking on the timeago-anchor should automatically jump to the post thread.

At my phone on the notifications-panel, if I try to click on the top-right number a on a notification, I then need to scroll up and click on the "Timeline"-button to view the whole post-thread, associated with the notification. With this change, clicking on the timeago-anchor should automatically jump to the post thread.
Author
Member

Please check if this actually works

Please check if this actually works
Owner

Thank you! This is another bug in mobile we need to squash. We fixed several of the others to auto focus on the timeline view, but this one was not yet noticed.

Thank you! This is another bug in mobile we need to squash. We fixed several of the others to auto focus on the timeline view, but this one was not yet noticed.
Member

It won't work, you need to pass activatePanel to notifications somehow (I did it via props for the other elements).

There are instructions in the README to run the frontend on your local computer.

It won't work, you need to pass activatePanel to notifications somehow (I did it via props for the other elements). There are instructions in the README to run the frontend on your local computer.
Author
Member

This is probably one of the first lines of javascript I've ever written, but I'll try maybe tomorrow

This is probably one of the first lines of javascript I've ever written, but I'll try maybe tomorrow
Author
Member

Actually, I'm unable to configure nginx for pleroma-fe to work. Can someone else fix this?

Actually, I'm unable to configure nginx for pleroma-fe to work. Can someone else fix this?
Author
Member

Wait I'll try this again later

Wait I'll try this again later
Owner

Pasting image to clarify for those watching at home

image

Pasting image to clarify for those watching at home ![image](/attachments/f7afb502-cba4-4138-aa74-ee490236460c)
195 KiB
Member

Reproducing this behavior locally to understand how to solve it

Reproducing this behavior locally to understand how to solve it
Member

was able to reproduce the behaviour locally, now trying to resolve it

was able to reproduce the behaviour locally, now trying to resolve it
Member

opening a different PR for this as the changes are totally unrelated to whats done here

opening a different PR for this as the changes are totally unrelated to whats done here
Member

Opened a PR with working timeago button #1679 @feld

Opened a PR with working `timeago` button https://git.pleroma.social/pleroma/pleroma-fe/pulls/1679 @feld
Owner

As I understand this MR can be closed now?

As I understand this MR can be closed now?
Owner

yea

yea
Author
Member

oof

oof

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1678
No description provided.