pleroma/pleroma-fe
2
2
Fork 4
Code Issues 344 Pull requests 27 Projects Releases Packages Wiki Activity

#330 Remove posts immediately by blocking someone #1859

Closed
jasper wants to merge 0 commits from gitlab-mr-iid-589 into develop
pull from: gitlab-mr-iid-589
merge into: pleroma:develop
Conversation 9 Commits - Files changed -
jasper commented 2019-02-15 15:58:33 +00:00
Member
Copy link

#330

#330
lambadalambda commented 2019-02-16 16:05:04 +00:00
Owner
Copy link

Too nuclear. Add a new mutation that removes just the posts by that users, not clear all timelines.

Too nuclear. Add a new mutation that removes just the posts by that users, not clear all timelines.
jasper commented 2019-02-18 13:26:43 +00:00
Author
Member
Copy link

I also think it's too nuclear. but please note the fact that when follow or unblock someone, it's hard to fetch/display his posts added while he was blocked, because posts are fetched by using max_id/min_id of timelines existing in the store.
Anyway, I will add a new mutation according to your opinion.

I also think it's too nuclear. but please note the fact that when follow or unblock someone, it's hard to fetch/display his posts added while he was blocked, because posts are fetched by using max_id/min_id of timelines existing in the store. Anyway, I will add a new mutation according to your opinion.
jasper commented 2019-02-18 14:15:54 +00:00
Author
Member
Copy link

Sorry for my stupid comment. :) I've found a solution that can add missing posts by following or unblocking.

Sorry for my stupid comment. :) I've found a solution that can add missing posts by following or unblocking.
jasper commented 2019-02-18 19:55:21 +00:00
Author
Member
Copy link

I've updated. please review and let me know if there is any thing I need to change.

I've updated. please review and let me know if there is any thing I need to change.
shpuld commented 2019-02-19 17:24:09 +00:00
Owner
Copy link

I'm not sure if this does anything, I think if count isn't provided then the count defaults to 20. at least this is how it used to be

I'm not sure if this does anything, I think if count isn't provided then the count defaults to 20. at least this is how it used to be
jasper commented 2019-02-19 17:50:26 +00:00
Author
Member
Copy link

yes, if count isn't provided then, it's still set to 20.
const fetchTimeline = ({timeline, credentials, since = false, until = false, between = false, count = 20, userId = false, tag = false}) => {

I just wanted to fetch all statuses (over 20) between max-id and min-id after unblock/follow someone.

yes, if count isn't provided then, it's still set to 20. `const fetchTimeline = ({timeline, credentials, since = false, until = false, between = false, count = 20, userId = false, tag = false}) => {` I just wanted to fetch all statuses (over 20) between max-id and min-id after unblock/follow someone.
shpuld commented 2019-02-19 18:01:16 +00:00
Owner
Copy link

I mean, the backend defaults it to 20 if you don't give it the param

I mean, the backend defaults it to 20 if you don't give it the param
jasper commented 2019-02-19 18:55:52 +00:00
Author
Member
Copy link

oh, I hadn't checked backend.
I think we need to add a case to fetch all statuses between max_id and since_id in the backend.

Just so you know, the backend uses "limit" parameter, not "count". The "count" from FE isn't used at all. I will change it to "limit" in FE.

oh, I hadn't checked backend. I think we need to add a case to fetch all statuses between max_id and since_id in the backend. Just so you know, the backend uses "limit" parameter, not "count". The "count" from FE isn't used at all. I will change it to "limit" in FE.
jasper commented 2019-02-25 22:42:57 +00:00
Author
Member
Copy link

@shpuld I've updated, so you can merge.
This MR have a functionality only to remove statuses by blocking/unfollowing.

@shpuld I've updated, so you can merge. This MR have a functionality only to remove statuses by blocking/unfollowing.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1859
No description provided.