pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Use self-background image on someone's profile #1861

Closed
edijs wants to merge 3 commits from gitlab-mr-iid-591 into develop
pull from: gitlab-mr-iid-591
merge into: pleroma:develop
Conversation 17 Commits 3 Files changed 2 +19 -2
edijs commented 2019-02-17 19:16:56 +00:00
Member
Copy link

Closes #366

Closes #366
edijs commented 2019-02-17 19:20:26 +00:00
Author
Member
Copy link

code refactoring

code refactoring
tae commented 2019-02-17 20:35:42 +00:00
Member
Copy link

I think we need to check first if user is viewing the profile page before using this.$route.params.

I think we need to check first if user is viewing the profile page before using `this.$route.params`.
edijs commented 2019-02-17 20:39:01 +00:00
Author
Member
Copy link

True, isExternal & isLocal methods do it

True, `isExternal` & `isLocal` methods do it
tae commented 2019-02-18 01:10:19 +00:00
Member
Copy link

Looks good to me 👍

Looks good to me :thumbsup:
shpuld commented 2019-02-20 14:44:18 +00:00
Owner
Copy link

This wouldn't be enough to close that issue which is about entire themes (not in backend yet so not possible to do yet)

This wouldn't be enough to close that issue which is about entire themes (not in backend yet so not possible to do yet)
feld commented 2019-02-20 16:40:02 +00:00
Owner
Copy link

This doesn't do the instance theme but it does the background image which is a huge improvement for some users. Does it make merge this part while we figure out how or if it's appropriate to do entire theme changes for a user profile?

This doesn't do the instance theme but it does the background image which is a huge improvement for some users. Does it make merge this part while we figure out how or if it's appropriate to do entire theme changes for a user profile?
edijs commented 2019-02-20 16:45:08 +00:00
Author
Member
Copy link

@shpuld entire theme settings are being saved in user's browser localstorage, not backend.

@shpuld entire theme settings are being saved in user's browser localstorage, not backend.
succfemboi commented 2019-02-20 18:05:57 +00:00
Member
Copy link

Wait, this MR is only about displaying the background-image of a remote-user, not theme. Will that still come?

Wait, this MR is only about displaying the background-image of a remote-user, not theme. Will that still come?
edijs commented 2019-02-20 18:08:53 +00:00
Author
Member
Copy link

Right, Pleroma-FE can't fetch the theme of remote-user from backend because theme configs are stored in web browser localstorage.

Right, Pleroma-FE can't fetch the theme of remote-user from backend because theme configs are stored in web browser localstorage.
hj commented 2019-02-20 19:26:44 +00:00
Owner
Copy link

there's still no setting to expose or not your background image, we need that first

there's still no setting to expose or not your background image, we need that first
feld commented 2019-02-20 19:32:42 +00:00
Owner
Copy link

Is that something we want to be user configurable? I wouldn't consider it a privacy issue, and as a user I would already expect a background customization to be viewable by all users who visit my profile much like how they can see my banner image.

Just want to make sure we don't go too far down the path of a thousand configuration knobs that only make users more confused when they look at the settings panels.

Is that something we want to be user configurable? I wouldn't consider it a privacy issue, and as a user I would already expect a background customization to be viewable by all users who visit my profile much like how they can see my banner image. Just want to make sure we don't go too far down the path of a thousand configuration knobs that only make users more confused when they look at the settings panels.
hj commented 2019-02-20 19:38:57 +00:00
Owner
Copy link

yes. I tune my instance (well, tuned it at some point, it's a bit broken now) to have a certain style and aesthetic to it. But I myself use a bit more easy-on-eyes theme and whatever not-really-matching wallpaper. I'd still want people to see instance's default theme/wallpaper when they visit my profile.

Ideally I'd love to see separate themes/background "what people see my profile as" and "how I see interface".

yes. I tune my instance (well, tuned it at some point, it's a bit broken now) to have a certain style and aesthetic to it. But I myself use a bit more easy-on-eyes theme and whatever not-really-matching wallpaper. I'd still want people to see instance's default theme/wallpaper when they visit my profile. Ideally I'd love to see separate themes/background "what people see my profile as" and "how I see interface".
feld commented 2019-02-20 19:41:25 +00:00
Owner
Copy link

Understood. Thanks for sharing. I am just being cautious to make sure we are mindful of the boundary between configurability and overkill.

We can tackle that as well if you open an issue and describe how you'd like that done.

Understood. Thanks for sharing. I am just being cautious to make sure we are mindful of the boundary between configurability and overkill. We can tackle that as well if you open an issue and describe how you'd like that done.
hj commented 2019-02-20 20:02:35 +00:00
Owner
Copy link

the boundary between configurability and overkill.

t. made themes v2

:DDDDDDDDDD

>the boundary between configurability and overkill. t. made themes v2 :DDDDDDDDDD
shpuld commented 2019-02-22 15:16:59 +00:00
Owner
Copy link

I don't think having wallpapers show up without "permission" is that bad, considering qvitter and twitter already displayed them to visitors so it's kinda to be expected, it's set together with 2 other images that are also public, and the url to the wallpaper is already sent over so it's not "private" in any real way. It would still be better if it was a part of a bigger "feature" that is worth announcing and caring about, so people can form their opinions about it before it happens, it's not a thing we'd want to "sneak in" silently.

I know I'd be super interested in seeing how others configure their own stuff and I think having user profiles automatically use the theme of that user would be a killer feature. it can't be done right now but it could be done if we want it. I'd really hate it if a big feature would be disabled by default as well, we already hide so many features.

I don't think having wallpapers show up without "permission" is that bad, considering qvitter and twitter already displayed them to visitors so it's kinda to be expected, it's set together with 2 other images that are also public, and the url to the wallpaper is already sent over so it's not "private" in any real way. It would still be better if it was a part of a bigger "feature" that is worth announcing and caring about, so people can form their opinions about it before it happens, it's not a thing we'd want to "sneak in" silently. I know I'd be super interested in seeing how others configure their own stuff and I think having user profiles automatically use the theme of that user would be a killer feature. it can't be done right now but it could be done if we want it. I'd really hate it if a big feature would be disabled by default as well, we already hide so many features.
edijs commented 2019-03-01 04:00:53 +00:00
Author
Member
Copy link

can we make this feature as optional? add this option as user settings.

can we make this feature as optional? add this option as user settings.
succfemboi commented 2019-05-02 17:35:18 +00:00
Member
Copy link

Why has this MR been closed?

Why has this MR been closed?

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1861
No description provided.