pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Keyboard binding #1863

Closed
edijs wants to merge 0 commits from gitlab-mr-iid-593 into develop
pull from: gitlab-mr-iid-593
merge into: pleroma:develop
Conversation 12 Commits - Files changed -
edijs commented 2019-02-17 21:40:11 +00:00
Member
Copy link

Closes #369

Pressing . keyboard button will show new status.

This is prototype of keyboard binding feature (#148).

Closes #369 Pressing `.` keyboard button will show new status. This is prototype of keyboard binding feature (#148).
tae commented 2019-02-18 01:57:38 +00:00
Member
Copy link

If I try this on Mentions and Direct messages pages, I get this console error. 😞

Uncaught TypeError: Cannot read property 'id' of undefined

Screenshot_at_Feb_17_20-54-39

If I try this on `Mentions` and `Direct messages` pages, I get this console error. :disappointed: ```Uncaught TypeError: Cannot read property 'id' of undefined``` ![Screenshot_at_Feb_17_20-54-39](/attachments/eaf240cf-5fda-4e5c-a47c-a7e3117f5b2c)
Screenshot_at_Feb_17_20-54-39.png
1.9 MiB
tae commented 2019-02-18 01:59:17 +00:00
Member
Copy link

I think we need to use keyup instead of keydown.

I think we need to use `keyup` instead of `keydown`.
edijs commented 2019-02-18 04:40:40 +00:00
Author
Member
Copy link

I can't reproduce your issue on my end. Are these errors related to the PR?

I can't reproduce your issue on my end. Are these errors related to the PR?
tae commented 2019-02-18 07:14:12 +00:00
Member
Copy link

Yes, since I get the errors whenever press down on . key.

Yes, since I get the errors whenever press down on `.` key.
hj commented 2019-02-18 20:02:00 +00:00
Owner
Copy link

disagree. this isn't a mouse click.

disagree. this isn't a mouse click.
hj commented 2019-02-18 20:04:36 +00:00
Owner
Copy link

error occurs because you need to validate if there's any new statuses to show. Since there's no statuses at all in TL, it breaks.

Or something like that.

error occurs because you need to validate if there's any new statuses to show. Since there's no statuses at all in TL, it breaks. Or something like that.
edijs commented 2019-02-18 21:31:09 +00:00
Author
Member
Copy link

Got it, let me fix it. Thanks @hj

Got it, let me fix it. Thanks @hj
shpuld commented 2019-02-22 15:03:30 +00:00
Owner
Copy link

feels a bit scary putting non-configurable always-on hotkeys that are being listened to at all times in the application. we currently do stuff like arrows, tab, esc, but only in very specific situations (text input, or with a modal open). I do agree that hotkeys are very useful and we'd want them, but we also don't want to step on the shoes of people who use browser plugins for keyboard navigation by not having ours configurable.

feels a bit scary putting non-configurable always-on hotkeys that are being listened to at all times in the application. we currently do stuff like arrows, tab, esc, but only in very specific situations (text input, or with a modal open). I do agree that hotkeys are very useful and we'd want them, but we also don't want to step on the shoes of people who use browser plugins for keyboard navigation by not having ours configurable.
edijs commented 2019-02-22 18:03:29 +00:00
Author
Member
Copy link

Are we going to add this feature? #148

Are we going to add this feature? https://git.pleroma.social/pleroma/pleroma-fe/issues/148
hj commented 2019-02-25 20:16:59 +00:00
Owner
Copy link

I agree that keybindings should be configurable. People using keyboard navigation (Sakakey, VimFX (yeah, rip)) can temporarily disable them. At least I do with websites with decent hotkeys (TT-RSS). Websites' hotkeys could interfere with extensions but I think most of them can suppress websites' hotkeys, at least sakakey does. Sakakey also fails to enter "ignore" mode correctly and still suppresses esc making it impossible to exit lighbox without putting site to blacklist.

I agree that keybindings should be configurable. People using keyboard navigation (Sakakey, VimFX (yeah, rip)) can temporarily disable them. At least I do with websites with decent hotkeys (TT-RSS). Websites' hotkeys could interfere with extensions but I think most of them can suppress websites' hotkeys, at least sakakey does. Sakakey also fails to enter "ignore" mode correctly and still suppresses `esc` making it impossible to exit lighbox without putting site to blacklist.
hj commented 2019-02-25 20:18:44 +00:00
Owner
Copy link

I don't think keybinds should necessarily be configurable at this early stage, but we do need to add them asap since we're adding them, so making some sort of framework/reusable base for them would be great.

I don't think keybinds should necessarily be configurable at this early stage, but we do need to add them asap since we're adding them, so making some sort of framework/reusable base for them would be great.
shpuld commented 2019-02-28 17:09:36 +00:00
Owner
Copy link

I'll take your word for it that they won't get in the way of different plugins (that I don't use) and we're fine with this for now.

I'll take your word for it that they won't get in the way of different plugins (that I don't use) and we're fine with this for now.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1863
No description provided.