Use carousel for media viewer #1870

Closed
edijs wants to merge 2 commits from gitlab-mr-iid-600 into develop
Member

Closes #381

Closes #381
Member

Please don't use jquery

Please don't use jquery
Author
Member

jQuery isn't used in code actually. It is dependency module of vue-slick. Let me figure it out.

jQuery isn't used in code actually. It is dependency module of vue-slick. Let me figure it out.
Author
Member

@hj , replaced vue-slick npm with vue-agile without jQuery.

@hj , replaced vue-slick npm with vue-agile without jQuery.
Member

I thought this is already kinda done in one of the recent merges?

I thought this is already kinda done in one of the recent merges?
Author
Member

Hmm, I haven't seen any updates for carousel in recent merges. This MR is from what I branched off latest develop branch.

Hmm, I haven't seen any updates for carousel in recent merges. This MR is from what I branched off latest develop branch.
Member

do we really need extra dependencies for just switching between images while in lightbox?

do we really need extra dependencies for just switching between images while in lightbox?
Author
Member

I think we need it.

Unless it requires a lot of hard coding to implement switching images with animation and dragging events.

I think we need it. Unless it requires a lot of hard coding to implement switching images with animation and dragging events.
Member

right, we already have the arrow buttons on the edges and keyboard navigation, adding simple swipe and animations is not a big deal if we really need it (see side drawer)

right, we already have the arrow buttons on the edges and keyboard navigation, adding simple swipe and animations is not a big deal if we really need it (see side drawer)
Member

fancy dragging/gestures and animations are bloat :rokalife:

i vote no dependencies for carousel, implement it ourselves only what we need. Remember: we are not apple and not want to be like them, so no need to make fancypants physics based animations for gallery swiping

fancy dragging/gestures and animations are bloat :rokalife: i vote no dependencies for carousel, implement it ourselves only what we need. Remember: we are not apple and not want to be like them, so no need to make fancypants physics based animations for gallery swiping
Author
Member

Make sense, let me implement it without dependencies then. Will come back with another MR

Make sense, let me implement it without dependencies then. Will come back with another MR

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!1870
No description provided.