pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

Only connect to chat upon authenticating #1936

Closed
slice wants to merge 0 commits from gitlab-mr-iid-666 into develop
pull from: gitlab-mr-iid-666
merge into: pleroma:develop
Conversation 3 Commits - Files changed -
slice commented 2019-03-10 10:26:21 +00:00
Member
Copy link

hello! this is my first time contributing to pleroma, so please be aware

something i noticed while using pleroma is that if you are logged out, then cryptic websocket errors get outputted to the console (as outlined in #403). (this only happens with pleroma instances that have chat enabled.)

while checking the code, it appears that p-fe makes a connection to the chat channel if chat is enabled, even if we aren't logged in. this patch adds a secondary condition that enforces the existence of a websocket token before attempting to connect to chat. this patch only creates a connection to the chat channel upon authenticating. the websocket token is only set upon verifying credentials, so:

this means that only logged in users are ever able to see chat, but i'm sure that's the intended behavior... right?

hello! this is my first time contributing to pleroma, so please be aware something i noticed while using pleroma is that if you are logged out, then cryptic websocket errors get outputted to the console (as outlined in #403). (this only happens with pleroma instances that have chat enabled.) while checking the code, it appears that p-fe makes a connection to the chat channel if chat is enabled, even if we aren't logged in. ~~this patch adds a secondary condition that enforces the existence of a websocket token before attempting to connect to chat.~~ this patch only creates a connection to the chat channel upon authenticating. the websocket token is only set upon verifying credentials, so: this means that only logged in users are ever able to see chat, but i'm sure that's the intended behavior... right?
hj commented 2019-03-10 11:21:30 +00:00
Member
Copy link

nice MR number

nice MR number
hj commented 2019-03-10 11:24:24 +00:00
Member
Copy link

yes, however this will probably just disable chat even if it's enabled since this part of code only executed once. I'd move the whole store.dispatch('initializeSocket') into place that gets executed when user logs in (or after credentials are being verified, same thing)

yes, however this will probably just disable chat even if it's enabled since this part of code only executed once. I'd move the whole `store.dispatch('initializeSocket')` into place that gets executed when user logs in (or after credentials are being verified, same thing)
slice commented 2019-03-10 18:15:14 +00:00
Author
Member
Copy link

okay, but that will require extra logic to tear down the chat socket when logging out. this is because the current behavior is to create the socket upon page load. when creating upon login, it's possible to "duplicate" the channel by logging out and logging back in

okay, but that will require extra logic to tear down the chat socket when logging out. this is because the current behavior is to create the socket upon page load. when creating upon login, it's possible to "duplicate" the channel by logging out and logging back in

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!1936
No description provided.