pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Transition to MastoAPI: user profile settings #1952

Closed
tae wants to merge 0 commits from gitlab-mr-iid-682 into develop
pull from: gitlab-mr-iid-682
merge into: pleroma:develop
Conversation 30 Commits - Files changed -
tae commented 2019-03-13 18:11:16 +00:00
Member
Copy link

Closes #437

This is blocked until the API (/api/v1/accounts/update_credentials) supports these properties

default_scope,
no_rich_text,
hide_follows,
hide_followers,
show_role
Closes #437 ~~This is blocked until the API (`/api/v1/accounts/update_credentials`) supports these properties~~ ``` default_scope, no_rich_text, hide_follows, hide_followers, show_role ```
hj commented 2019-03-13 18:15:51 +00:00
Owner
Copy link

what about display name and bio?

what about display name and bio?
tae commented 2019-03-14 01:00:42 +00:00
Author
Member
Copy link

well, when clicking the Submit button, they are updated along with the other profile options (except images) altogether. not really needed to make 2 different api calls...

well, when clicking the `Submit` button, they are updated along with the other profile options (except images) altogether. not really needed to make 2 different api calls...
hj commented 2019-03-14 14:37:38 +00:00
Owner
Copy link

yeah but, like, you're still using /api/account/update_profile.json

yeah but, like, you're still using `/api/account/update_profile.json`
hj commented 2019-03-14 14:37:53 +00:00
Owner
Copy link

also i don't understand the whole refactoring going on there

also i don't understand the whole refactoring going on there
tae commented 2019-03-14 15:22:43 +00:00
Author
Member
Copy link

yeah but, like, you're still using /api/account/update_profile.json

What do you mean by this?

> yeah but, like, you're still using `/api/account/update_profile.json` What do you mean by this?
tae commented 2019-03-14 15:41:02 +00:00
Author
Member
Copy link

also i don't understand the whole refactoring going on there

because the data format for images which the mastoAPI accepts is different than the one the legacy API accepts.

  • the legacy API accepts data url (e.g, the result of canvas.toDataURL)
  • the mastoAPI accepts file or blob (e.g, the result of canvas.toBlob)
> also i don't understand the whole refactoring going on there because the data format for images which the mastoAPI accepts is different than the one the legacy API accepts. - the legacy API accepts data url (e.g, the result of `canvas.toDataURL`) - the mastoAPI accepts file or blob (e.g, the result of `canvas.toBlob`)
hj commented 2019-03-14 15:45:05 +00:00
Owner
Copy link

What do you mean by this?

Issue is about transitioning all profile editing stuff to MastoAPI. Nickname, bio, avatar, banner, background and other options like "hide my followers". This MR only changes avatar and banner update, doesn't handle updating bio and nickname.

>What do you mean by this? Issue is about transitioning all profile editing stuff to MastoAPI. Nickname, bio, avatar, banner, background and other options like "hide my followers". This MR only changes avatar and banner update, doesn't handle updating bio and nickname.
tae commented 2019-03-14 15:57:13 +00:00
Author
Member
Copy link

doesn't handle updating bio and nickname.

as I mentioned before, they are updated along with the other profile options (e.g, no_rich_text) altogether triggered by only one user action (i.e, clicking the submit button).

isn't it an overkill to send two API calls to handle one user action regardless we can do it using one call?

> doesn't handle updating bio and nickname. as I mentioned before, they are updated along with the other profile options (e.g, `no_rich_text`) altogether triggered by only one user action (i.e, clicking the submit button). isn't it an overkill to send two API calls to handle one user action regardless we can do it using one call?
hj commented 2019-03-14 16:03:04 +00:00
Owner
Copy link

Then remove the

const PROFILE_UPDATE_URL = '/api/account/update_profile.json'
Then remove the ```js const PROFILE_UPDATE_URL = '/api/account/update_profile.json' ```
tae commented 2019-03-14 16:09:32 +00:00
Author
Member
Copy link

sorry! that's what we still need to use.

sorry! that's what we still need to use.
tae commented 2019-03-14 16:10:23 +00:00
Author
Member
Copy link

there is no mastoapi equivalent to that

which accepts all options of that

there is no mastoapi equivalent to that which accepts all options of that
hj commented 2019-03-14 16:13:01 +00:00
Owner
Copy link

Pass options that are accepted and pester BE folk to add missing ones! It's already mentioned in pleroma#674 too

Pass options that are accepted and pester BE folk to add missing ones! It's already mentioned in pleroma#674 too
hj commented 2019-04-27 15:29:40 +00:00
Owner
Copy link

@tae take a look at this: pleroma/pleroma#674

can't confirm if it's in develop version of BE tho. Another thing is that default_scope should be in source.privacy - https://docs.joinmastodon.org/api/rest/accounts/#patch-api-v1-accounts-update-credentials

@tae take a look at this: https://git.pleroma.social/pleroma/pleroma/issues/674#note_25875 can't confirm if it's in develop version of BE tho. Another thing is that default_scope should be in `source.privacy` - https://docs.joinmastodon.org/api/rest/accounts/#patch-api-v1-accounts-update-credentials
rinpatch commented 2019-04-27 15:33:52 +00:00
Member
Copy link

can't confirm if it's in develop version of BE tho

We don't mark tasks as completed before the solution is in develop

> can't confirm if it's in develop version of BE tho We don't mark tasks as completed before the solution is in develop
hj commented 2019-04-27 15:41:40 +00:00
Owner
Copy link

i meant i couldn't find MR and didn't update BE and checked if it's actually working :)

no offense, just extra verification.

i meant i couldn't find MR and didn't update BE and checked if it's actually working :) no offense, just extra verification.
tae commented 2019-04-27 17:05:29 +00:00
Author
Member
Copy link

Thanks!

Thanks!
tae commented 2019-04-27 18:29:26 +00:00
Author
Member
Copy link

everything works great except updating source[privacy].
@rinpatch could you check why source[privacy] is not updating?

everything works great except updating `source[privacy]`. @rinpatch could you check why `source[privacy]` is not updating?
rinpatch commented 2019-04-27 19:49:35 +00:00
Member
Copy link

When updating it should be default_scope, but when recieving it should be source[privacy]

When updating it should be `default_scope`, but when recieving it should be `source[privacy]`
tae commented 2019-04-27 20:08:40 +00:00
Author
Member
Copy link

thanks, I will try right away.

thanks, I will try right away.
tae commented 2019-04-27 20:13:48 +00:00
Author
Member
Copy link

hmm, it is not working.

  • request payload

Screenshot_at_Apr_27_16-07-26

  • response

Screenshot_at_Apr_27_16-07-50

btw, my instance is up to date.

hmm, it is not working. - request payload ![Screenshot_at_Apr_27_16-07-26](/attachments/8c6ecc9e-21b1-4a34-89b2-cd5ec394f23c) - response ![Screenshot_at_Apr_27_16-07-50](/attachments/f56622a1-8a18-42e6-a680-11eb552a264e) btw, my instance is up to date.
Screenshot_at_Apr_27_16-07-50.png
318 KiB
Screenshot_at_Apr_27_16-07-26.png
317 KiB
rinpatch commented 2019-04-27 20:57:53 +00:00
Member
Copy link

Oh sorry, it really was a mistake on my end. Fixed in pleroma!1100

Oh sorry, it really was a mistake on my end. Fixed in pleroma!1100
tae commented 2019-04-28 01:50:10 +00:00
Author
Member
Copy link

thanks 😄

thanks :smile:
rinpatch commented 2019-04-29 06:45:49 +00:00
Member
Copy link

@tae should be fixed now

@tae should be fixed now
tae commented 2019-04-29 18:17:00 +00:00
Author
Member
Copy link

this is done

this is done
hj commented 2019-04-29 18:34:54 +00:00
Owner
Copy link

not sure you need to wrap it in a promise...

not sure you need to wrap it in a promise...
tae commented 2019-04-29 18:41:24 +00:00
Author
Member
Copy link

because ImageCropper component accepts submitHandler which returns a promise

because `ImageCropper` component accepts submitHandler which returns a promise
hj commented 2019-04-29 18:58:54 +00:00
Owner
Copy link

yeah but you can do just

return that.$store.state.api.backendInteractor.updateAvatar({ avatar })
  .then(...)
  .catch(...)

since .then and .catch return promise.

not sure what's the better approach with .catch though, you could retrow or you could return Promise.reject() or something like it.

yeah but you can do just ```js return that.$store.state.api.backendInteractor.updateAvatar({ avatar }) .then(...) .catch(...) ``` since `.then` and `.catch` return promise. not sure what's the better approach with `.catch` though, you could retrow or you could return `Promise.reject()` or something like it.
hj commented 2019-04-29 18:59:30 +00:00
Owner
Copy link

seems to be working fine.

seems to be working fine.
tae commented 2019-04-29 19:05:21 +00:00
Author
Member
Copy link

that pattern doesn't work due to this 3665c86d70/src/components/user_settings/user_settings.js (L169)

that pattern doesn't work due to this https://git.pleroma.social/pleroma/pleroma-fe/blob/3665c86d709f3a04ae3471d09b84a69c8a8c9172/src/components/user_settings/user_settings.js#L169
hj commented 2019-04-30 06:05:36 +00:00
Owner
Copy link

ok, fair enough

ok, fair enough

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1952
No description provided.