pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

#459 - add feature to preview status before submitting #1999

Closed
jaredr wants to merge 8 commits from gitlab-mr-iid-729 into develop
pull from: gitlab-mr-iid-729
merge into: pleroma:develop
Conversation 22 Commits 8 Files changed 7 +186 -99
jaredr commented 2019-04-03 21:17:48 +00:00
Member
Copy link

Closes #459

Closes #459
jaredr commented 2019-04-03 21:18:42 +00:00
Author
Member
Copy link

Here are the screenshots

Updated layout

image

Preview mode

image

Submitted

image

**Here are the screenshots** Updated layout ![image](/attachments/4b34bc55-6c69-433a-881b-49826983c171) Preview mode ![image](/attachments/f66b6538-3dd3-47d2-acca-4a1c3dbdf341) Submitted ![image](/attachments/fee230cb-b8a8-4c75-84c8-5756f5129d49)
image.png
25 KiB
image.png
17 KiB
image.png
31 KiB
rinpatch commented 2019-04-04 16:22:37 +00:00
Member
Copy link

custom emojis do not seem to enforce size limits 2019-04-04-1921352019-04-04-192140

custom emojis do not seem to enforce size limits ![2019-04-04-192135](/attachments/93316e3a-c014-45f5-b43a-f0010cd578c3)![2019-04-04-192140](/attachments/aa893bd1-a4f3-4565-8e69-4573f607c126)
2019-04-04-192135.png
88 KiB
2019-04-04-192140.png
112 KiB
hj commented 2019-04-04 16:31:34 +00:00
Member
Copy link

I'm thinking live preview next to input field might be better since we're probably be doing "This DM will be sent to..." which should be live-updated anyway.

I'm thinking live preview next to input field might be better since we're probably be doing "This DM will be sent to..." which should be live-updated anyway.
rinpatch commented 2019-04-04 18:31:45 +00:00
Member
Copy link

the input field height gets reset after preview has been triggered

2019-04-04-2130282019-04-04-2130362019-04-04-213041

the input field height gets reset after preview has been triggered ![2019-04-04-213028](/attachments/4acdd8fc-cf27-4036-9ec0-7cc768e59bf0)![2019-04-04-213036](/attachments/f09e87b9-6984-4c92-bb2c-b07f1249b129)![2019-04-04-213041](/attachments/ab680831-b698-4f46-9b4b-b0829371363f)
2019-04-04-213036.png
165 KiB
2019-04-04-213041.png
158 KiB
2019-04-04-213028.png
212 KiB
jaredr commented 2019-04-04 18:32:40 +00:00
Author
Member
Copy link

@rinpatch Nice catch. I will check again.

@rinpatch Nice catch. I will check again.
hj commented 2019-04-04 18:34:01 +00:00
Member
Copy link

can we do it side-by-side tho?
image

can we do it side-by-side tho? ![image](/attachments/836b3574-4f17-44a3-ae0f-a9a4a28a5728)
image.png
264 KiB
jaredr commented 2019-04-04 18:35:12 +00:00
Author
Member
Copy link

@hj There's no space in the sidebar to make it side by side.

@hj There's no space in the sidebar to make it side by side.
shpuld commented 2019-04-04 19:31:07 +00:00
Member
Copy link

I don't think side-by-side is necessary and it would mean making 2 versions when taking mobile in account too. I would change the "Done" button to "Edit".

I don't think side-by-side is necessary and it would mean making 2 versions when taking mobile in account too. I would change the "Done" button to "Edit".
hj commented 2019-04-04 20:16:39 +00:00
Member
Copy link

could be over/under reddit-style as well

could be over/under reddit-style as well
hj commented 2019-04-04 20:17:28 +00:00
Member
Copy link

the idea is that switching preview and text back-and-forth isn't very convenient and that we need live preview for DM mentions anyways

the idea is that switching preview and text back-and-forth isn't very convenient and that we need live preview for DM mentions anyways
hj commented 2019-04-04 20:17:58 +00:00
Member
Copy link

@jaredr you can make it popup

@jaredr you can make it popup
jaredr commented 2019-04-05 01:21:23 +00:00
Author
Member
Copy link

@rinpatch input field height after preview issue is fixed now.

@rinpatch input field height after preview issue is fixed now.
jaredr commented 2019-04-05 01:21:49 +00:00
Author
Member
Copy link

@shpuld I updated the button text to Edit as you suggested.

@shpuld I updated the button text to `Edit` as you suggested.
jaredr commented 2019-04-05 01:31:59 +00:00
Author
Member
Copy link

@hj I couldn't find the preview feature before submitting on Reddit.

And as for the real-time preview, it's not realistic since sometimes it takes a few seconds to post status and get preview data.

And currently sidebar has overflow: hidden;, and we need to refactor this to show the popup out of the sidebar area.

Also as @shpuld mentioned we need to consider mobile size as well. On mobile, where should be place the preview popup?

@hj I couldn't find the preview feature before submitting on Reddit. And as for the real-time preview, it's not realistic since sometimes it takes a few seconds to post status and get preview data. And currently sidebar has `overflow: hidden;`, and we need to refactor this to show the popup out of the sidebar area. Also as @shpuld mentioned we need to consider mobile size as well. On mobile, where should be place the preview popup?
hj commented 2019-04-05 05:14:57 +00:00
Member
Copy link

It's realistic, it's throttled sure but it's better.

Also we do have popper.js don't we?

It's realistic, it's throttled sure but it's better. Also we do have popper.js don't we?
hj commented 2019-04-05 07:54:08 +00:00
Member
Copy link

Ok, sorry it was Reddit Enhancement Suite feature, not vanilla reddit.

image

Ok, sorry it was Reddit Enhancement Suite feature, not vanilla reddit. ![image](/attachments/96c47bfa-269c-4cac-97b6-da622258a8d9)
image.png
17 KiB
shpuld commented 2019-04-05 13:57:52 +00:00
Member
Copy link

I think floating it on the side would be really ugly and would be desktop specific only, and would cover part of the timeline when showing preview. if we really need live preview I'd place it above or below instead without needing any overlap anywhere, but I'm not convinced why we'd need live previews for dm mentions? preview should always need toggling on to not always waste space (I know I don't want it in 99% of my usage), and if it's necessary for dms you would have to have it in/as a confirmation dialog or something.

I think floating it on the side would be really ugly and would be desktop specific only, and would cover part of the timeline when showing preview. if we really need live preview I'd place it above or below instead without needing any overlap anywhere, but I'm not convinced why we'd need live previews for dm mentions? preview should always need toggling on to not always waste space (I know I don't want it in 99% of my usage), and if it's necessary for dms you would have to have it in/as a confirmation dialog or something.
jaredr commented 2019-04-05 14:03:03 +00:00
Author
Member
Copy link

Sorry, by mistake, I clicked the close button.

Sorry, by mistake, I clicked the `close` button.
jaredr commented 2019-04-05 14:04:42 +00:00
Author
Member
Copy link

And we really need to follow the mobile first approach these days. Live preview on popper will be annoying on mobile devices.

In case we really need a live preview, I think the best place is below the submit button from my point of view.

And we really need to follow the mobile first approach these days. Live preview on popper will be annoying on mobile devices. In case we really need a live preview, I think the best place is below the submit button from my point of view.
feld commented 2019-04-05 14:17:19 +00:00
Owner
Copy link

My only question is the buttons on preview: Done and Submit. That's confusing. Shouldn't it be something like Back and Submit ?

Done has no clear meaning here.

edit: or maybe Edit and Submit?

My only question is the buttons on preview: `Done` and `Submit`. That's confusing. Shouldn't it be something like `Back` and `Submit` ? `Done` has no clear meaning here. edit: or maybe `Edit` and `Submit`?
jaredr commented 2019-04-05 14:18:10 +00:00
Author
Member
Copy link

It's already Edit & Submit now. It's updated already.

It's already `Edit` & `Submit` now. It's updated already.
jaredr commented 2019-04-05 14:52:44 +00:00
Author
Member
Copy link

Created another MR[#2002] with clean up and rebase since safe_dm part was added by accident in this MR.

Closing this MR...

Created another MR[https://git.pleroma.social/pleroma/pleroma-fe/pulls/2002] with clean up and rebase since `safe_dm` part was added by accident in this MR. Closing this MR...

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!1999
No description provided.