pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

#479 - clicking anywhere should open conversation #2011

Closed
Dave wants to merge 6 commits from gitlab-mr-iid-741 into develop
pull from: gitlab-mr-iid-741
merge into: pleroma:develop
Conversation 7 Commits 6 Files changed 11 +88 -31
Dave commented 2019-04-09 18:11:26 +00:00
Member
Copy link

Closes #479

Closes #479
shpuld commented 2019-04-09 19:16:41 +00:00
Owner
Copy link

Few things (also see my post on the issue):

  • should be optional in current state, as it can really destroy the usage of existing users
  • should not open the conversation page but expand the conversation instead, @feld must have made a mistake when referring to timestamp and not the expand button
  • feels very inconsistent when trying to use it, cursor has the pointer icon and the status is highlighted, but clicking does nothing as it's over text.
Few things (also see my post on the issue): - should be optional in current state, as it can really destroy the usage of existing users - should not open the conversation page but expand the conversation instead, @feld must have made a mistake when referring to timestamp and not the expand button - feels very inconsistent when trying to use it, cursor has the pointer icon and the status is highlighted, but clicking does nothing as it's over text.
hj commented 2019-04-25 13:05:56 +00:00
Owner
Copy link

expand, not open a different page

expand, not open a different page
hj commented 2019-04-25 13:07:34 +00:00
Owner
Copy link

please no irrelevant formatting changes

please no irrelevant formatting changes
hj commented 2019-04-25 13:09:56 +00:00
Owner
Copy link

no, current layout is intended one.

no, current layout is intended one.
hj commented 2019-04-25 13:10:11 +00:00
Owner
Copy link

i don't think it should be always like that even if it's not clickable

i don't think it should be always like that even if it's not clickable
hj commented 2019-04-25 13:11:25 +00:00
Owner
Copy link

even if it's clickable i don't think we should always show pointer cursor since it makes harder to "feel" links' hitboxes. Will clicking here open status or open link? We may never know.

even if it's clickable i don't think we should always show pointer cursor since it makes harder to "feel" links' hitboxes. Will clicking *here* open status or open link? We may never know.
lambadalambda commented 2020-06-09 15:21:45 +00:00
Owner
Copy link

Closing this, stale for a year and the discussion on what to actually do is still ongoing in the issue.

Closing this, stale for a year and the discussion on what to actually do is still ongoing in the issue.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2011
No description provided.