Resolve "Add Bookmarks to FE" #2021

Closed
jaredr wants to merge 13 commits from gitlab-mr-iid-752 into develop
Member

Closes #472

Closes #472
Member

I think it might be better to put it on the nav panel, there shouldn't really be a reason for the user to go to his own profile to see his bookmarks, and it's more important than favorites which makes some sense on the user profile.

I think it might be better to put it on the nav panel, there shouldn't really be a reason for the user to go to his own profile to see his bookmarks, and it's more important than favorites which makes some sense on the user profile.
Member

This function is (and was) confusing, why does "remove status" take an userId? one would think it only takes a status and a timeline if it removes a status. some renaming and splitting the userId/statusId variants might be a good idea

This function is (and was) confusing, why does "remove status" take an userId? one would think it only takes a status and a timeline if it removes a status. some renaming and splitting the userId/statusId variants might be a good idea
Member

red isn't a very good color, usually indicating danger, blue or green is probably better. Alternative would be just using text color

red isn't a very good color, usually indicating danger, blue or green is probably better. Alternative would be just using text color
Author
Member

@hj @shpuld This is ready. Please review again.

@hj @shpuld This is ready. Please review again.
Member

lgtm

lgtm
Member

Is this MR out-of-date?

Is this MR out-of-date?
Member

there are merge conflicts and i think author yeeted out of pleroma-fe development but it's probably salvageable

there are merge conflicts and i think author yeeted out of pleroma-fe development but it's probably salvageable
Member

Superceded by #2170.

Superceded by #2170.

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2021
No description provided.