pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

EmojiInput refactoring #2093

Closed
hj wants to merge 0 commits from gitlab-mr-iid-824 into develop
pull from: gitlab-mr-iid-824
merge into: pleroma:develop
Conversation 20 Commits - Files changed -
hj commented 2019-06-06 21:23:23 +00:00
Member
Copy link

Closes #565

  • Reimplemented emoji-input as a component that enhances existing element via slots.
  • Replaced copy-paste suggetsions in post status form
  • Standardized format for autocomplete suggestions
  • Switched to PopperJS popper-vue sucks
  • Made suggestor async by default? for the next time
  • Fixed bugs
  • Rename emoji-input?
Closes #565 * [x] Reimplemented emoji-input as a component that enhances existing element via slots. * [x] Replaced copy-paste suggetsions in post status form * [x] Standardized format for autocomplete suggestions * ~~Switched to PopperJS~~ popper-vue sucks * ~~Made suggestor async by default?~~ for the next time * [x] Fixed bugs * [ ] Rename emoji-input?
hj commented 2019-06-09 22:02:48 +00:00
Author
Member
Copy link

remove leftovers

remove leftovers
hj commented 2019-06-09 22:06:40 +00:00
Author
Member
Copy link

remove value it's unused anymore

remove `value` it's unused anymore
hj commented 2019-06-09 22:09:19 +00:00
Author
Member
Copy link

needs better documentation

needs better documentation
hj commented 2019-06-10 18:23:43 +00:00
Author
Member
Copy link

found a bug - mention replacement doens't put a space at the end

found a bug - mention replacement doens't put a space at the end
hj commented 2019-06-11 12:51:39 +00:00
Author
Member
Copy link

another bug - clicking doesn't work for some reason again.... ugh

another bug - clicking doesn't work for some reason again.... ugh
hj commented 2019-06-11 21:30:25 +00:00
Author
Member
Copy link

mentioned bugs fixed + added more documentation

mentioned bugs fixed + added more documentation
shpuld commented 2019-06-18 17:41:31 +00:00
Member
Copy link

resize doesn't take arguments

resize doesn't take arguments
shpuld commented 2019-06-18 17:41:54 +00:00
Member
Copy link

does passing an event here work correctly?

does passing an event here work correctly?
shpuld commented 2019-06-18 17:44:45 +00:00
Member
Copy link

ternary might be clearer here I think aScore += a.imageUrl ? 10 : 0

ternary might be clearer here I think `aScore += a.imageUrl ? 10 : 0`
hj commented 2019-06-18 17:47:58 +00:00
Author
Member
Copy link

it does. neither of those do anything to event, just another opportunity to sync state.

it does. neither of those do anything to event, just another opportunity to sync state.
shpuld commented 2019-06-18 17:49:08 +00:00
Member
Copy link

for curried functions like this use arrow syntax, const suggestEmoji = emojis => input => { ... }

for curried functions like this use arrow syntax, `const suggestEmoji = emojis => input => { ... }`
shpuld commented 2019-06-18 17:50:38 +00:00
Member
Copy link

Suggest exporting everything to enable unit tests for every function, even if it's not actually done here

Suggest exporting everything to enable unit tests for every function, even if it's not actually done here
shpuld commented 2019-06-18 17:52:54 +00:00
Member
Copy link

(bScore - aScore) * 10

(bScore - aScore) * 10
shpuld commented 2019-06-18 17:55:51 +00:00
Member
Copy link

Would prefer the old one here, nice to be able to tell apart our custom components from others

Would prefer the old one here, nice to be able to tell apart our custom components from others
shpuld commented 2019-06-18 17:57:12 +00:00
Member
Copy link

it's just an event coming from a different source which is always a bit spooky, but if it works it works

it's just an event coming from a different source which is always a bit spooky, but if it works it works
hj commented 2019-06-18 18:32:04 +00:00
Author
Member
Copy link

fixed

fixed
hj commented 2019-06-18 18:32:59 +00:00
Author
Member
Copy link

fixed and also in other places like

--score += boolean
++score += boolean ? 1 : 0

for clarity

fixed and also in other places like ```diff --score += boolean ++score += boolean ? 1 : 0 ``` for clarity
shpuld commented 2019-06-18 18:37:17 +00:00
Member
Copy link

small whoops: <emoji-input> </EmojiInput>

small whoops: `<emoji-input> </EmojiInput>`
shpuld commented 2019-06-18 18:39:01 +00:00
Member
Copy link

is it some style thing to () a single argument? I've left the parens out if not needed. I don't mind too much either way but now we have 2 different styles on the same line w

is it some style thing to () a single argument? I've left the parens out if not needed. I don't mind too much either way but now we have 2 different styles on the same line w
shpuld commented 2019-06-18 18:39:35 +00:00
Member
Copy link

yeah LGTM all in all

yeah LGTM all in all

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2093
No description provided.