pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

WIP: Dokku review instance support #2094

Closed
lambadalambda wants to merge 6 commits from gitlab-mr-iid-825 into develop
pull from: gitlab-mr-iid-825
merge into: pleroma:develop
Conversation 16 Commits 6 Files changed 4 +53 -2
lambadalambda commented 2019-06-11 10:29:50 +00:00
Owner
Copy link
No description provided.
lambadalambda commented 2019-06-11 11:25:51 +00:00
Author
Owner
Copy link

This kind of works, but the login goes to localhost:4040 instead of /api/v1/apps or https://pleroma.soykaf.com. What did I forget to set?

btw, the instance is only set to soykaf for testing, long term it should be possible to set this, but that's a different MR i'd say.

This kind of works, but the login goes to localhost:4040 instead of `/api/v1/apps` or `https://pleroma.soykaf.com`. What did I forget to set? btw, the instance is only set to soykaf for testing, long term it should be possible to set this, but that's a different MR i'd say.
lambadalambda commented 2019-06-11 11:26:16 +00:00
Author
Owner
Copy link

@shpuld @hj ping :)

@shpuld @hj ping :)
hj commented 2019-06-11 11:49:49 +00:00
Member
Copy link

i think you can just yarn dev

i think you can just `yarn dev`
hj commented 2019-06-11 11:50:06 +00:00
Member
Copy link

do we have to use alpine?

do we have to use alpine?
hj commented 2019-06-11 11:57:21 +00:00
Member
Copy link

well you said that login shouldn't be proxied not should use relative paths, so i don't know

I've seen sgsgb glitch out with localhost as instance once, probably some problem related to config fetching or BE bug, idk.

otherwise i have no idea what the hell this whole thing is so you probably know better. My idea of review app was just spawning a simple nginx instance serving static files taken from build step

well you said that login shouldn't be proxied not should use relative paths, so i don't know I've seen sgsgb glitch out with localhost as instance once, probably some problem related to config fetching or BE bug, idk. otherwise i have no idea what the hell this whole thing is so you probably know better. My idea of review app was just spawning a simple nginx instance serving static files taken from build step
hj commented 2019-06-11 11:59:39 +00:00
Member
Copy link

also can we point it at another instance that has open registrations or at least one where both me and @shpuld have accounts? soykaf is completely useless to me.

also can we point it at another instance that has open registrations or at least one where both me and @shpuld have accounts? soykaf is completely useless to me.
rinpatch commented 2019-06-11 12:24:37 +00:00
Member
Copy link

this task only sends commands to the remote server to create an app and pushes the repo to it, so why not?

this task only sends commands to the remote server to create an app and pushes the repo to it, so why not?
hj commented 2019-06-11 12:26:09 +00:00
Member
Copy link

mostly because i'm not familiar with it and wouldn't really want to learn it if something goes wrong

mostly because i'm not familiar with it and wouldn't really want to learn it if something goes wrong
lambadalambda commented 2019-06-11 12:31:25 +00:00
Author
Owner
Copy link

TIL

TIL
lambadalambda commented 2019-06-11 12:31:58 +00:00
Author
Owner
Copy link

Sure, it can point to anything. This was really just set for testing, as I mentioned above.

Sure, it can point to anything. This was really just set for testing, as I mentioned above.
lambadalambda commented 2019-06-11 12:32:33 +00:00
Author
Owner
Copy link

This isn't what's being run on the server, it's just what's being run to push the git repo to the dokku server (dokku = self hosted heroku)

This isn't what's being run on the server, it's just what's being run to push the git repo to the dokku server (dokku = self hosted heroku)
hj commented 2019-06-11 12:36:09 +00:00
Member
Copy link

my point still stands tho

my point still stands tho
hj commented 2019-06-11 12:36:35 +00:00
Member
Copy link

yeah, and i can't really test it if it's pointing at soykaf :)

yeah, and i can't really test it if it's pointing at soykaf :)
hj commented 2019-06-11 12:37:36 +00:00
Member
Copy link

still, running a dev server as a review app is a bit of an overkill

still, running a dev server as a review app is a bit of an overkill
lambadalambda commented 2019-06-11 12:43:37 +00:00
Author
Owner
Copy link

Well, there's nothing to learn here. It's just a container for git and ssh, alpine is just one of the smallest images for that.

Well, there's nothing to learn here. It's just a container for git and ssh, alpine is just one of the smallest images for that.
hj commented 2019-06-11 12:45:59 +00:00
Member
Copy link

i'm talking about alpine itself since it's not even debian-based but whatever, have it your way.

i'm talking about alpine itself since it's not even debian-based but whatever, have it your way.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2094
No description provided.