New search #2101

Closed
eugenijm wants to merge 2 commits from gitlab-mr-iid-832 into develop
Member

Screenshots:

Video

Screenshots: - [desktop](/attachments/7ce44d17-cf9e-4d89-ba50-4d9722a2c017) - [mobile](/attachments/f7a3bbd4-52a1-432b-9e99-d90d68826c21) [Video](/attachments/f162d97d-56a3-485e-9bc0-05317dc4eaa4)
Member

Bit of a nitpick but maybe this could be called "Search" instead of this?

Bit of a nitpick but maybe this could be called "Search" instead of this?
Member

Oh wait nevermind, I didn't notice there was another component called just that. SearchBar ? I don't know,

Oh wait nevermind, I didn't notice there was another component called just that. SearchBar ? I don't know,
Member

Formatting, space out the objects to not create even more eslint warnings, there's plenty of other examples of this in this review so not going to comment on all of them

Formatting, space out the objects to not create even more eslint warnings, there's plenty of other examples of this in this review so not going to comment on all of them
Author
Member

SearchBar sounds good, updated

SearchBar sounds good, updated
Member

Sorry for the delays, I think it works great, but there's a problem with the size of the icon, for some reason the search icon on the top is larger than the rest.

edit: found the reason and commented

Sorry for the delays, I think it works great, but there's a problem with the size of the icon, for some reason the search icon on the top is larger than the rest. edit: found the reason and commented
Member

having "button-icon" here means that the icon will get 1.2em twice, becoming too large

having "button-icon" here means that the icon will get 1.2em twice, becoming too large
Member

I also think the X button for the search pointer needs cursor: pointer;

I also think the X button for the search pointer needs `cursor: pointer;`
Member

Can the hashtag links be made into router links?

Can the hashtag links be made into router links?
Author
Member

Thanks, updated it

search1
search2

Thanks, updated it ![search1](/attachments/3a0278a7-c633-43f4-b5a9-a0722793eac2) ![search2](/attachments/40b90bdc-7f2f-4b0f-b3de-b621e6f6831c)
Author
Member

Done

Done

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2101
No description provided.