pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

Mastoapi login and config fixes #2102

Closed
hj wants to merge 0 commits from gitlab-mr-iid-833 into develop
pull from: gitlab-mr-iid-833
merge into: pleroma:develop
Conversation 8 Commits - Files changed -
hj commented 2019-06-16 17:21:16 +00:00
Member
Copy link
  • Remove formattingOptionsEnabled because it doesn't stop one from using formatting options, what stops is list of available post content types, added display of post content type as a label if there's only one available.
  • Removed background-image hack, added support for MastoAPI background image and chat token fetching, moved background image setting to MastoAPI.
* Remove `formattingOptionsEnabled` because it doesn't stop one from using formatting options, what stops is list of available post content types, added display of post content type as a label if there's only one available. * Removed background-image hack, added support for MastoAPI background image and chat token fetching, moved background image setting to MastoAPI.
lambadalambda commented 2019-06-17 08:07:46 +00:00
Owner
Copy link

what's the relation between backgroundpreview and background here, why could all this be removed?

what's the relation between backgroundpreview and background here, why could all this be removed?
hj commented 2019-06-17 08:18:19 +00:00
Author
Member
Copy link

The whole thing should be refactored IMO, but the thing is that there's uploadFile() which sets {slot} and {slot}Preview, i.e. for background it would be background and backgroundPreview, the preview is used to display it in the UI as a preview and it's a data: URI, the just background is file itself, just raw data IIRC.

If I understand correctly the old code and QvitterAPI was expecting the data: uri with some crop options which weren't implemented and instead image's own dimensions were determined client-side and passed as parameters, probably GNU/Social or original Qvitter actually did some cropping? idk. Meanwhile MastoAPI doesn't support anything and expects raw data for image data.

All that I can say is that it worked for me this way and not the other way.

The whole thing should be refactored IMO, but the thing is that there's uploadFile() which sets `{slot}` and `{slot}Preview`, i.e. for background it would be `background` and `backgroundPreview`, the preview is used to display it in the UI as a preview and it's a `data:` URI, the just `background` is file itself, just raw data IIRC. If I understand correctly the old code and QvitterAPI was expecting the `data:` uri with some crop options which weren't implemented and instead image's own dimensions were determined client-side and passed as parameters, probably GNU/Social or original Qvitter actually did some cropping? idk. Meanwhile MastoAPI doesn't support anything and expects raw data for image data. All that I can say is that it worked for me this way and not the other way.
hj commented 2019-06-17 08:19:55 +00:00
Author
Member
Copy link
  form.append('pleroma_background_image', background)
```suggestion:+1 form.append('pleroma_background_image', background) ```
lambadalambda commented 2019-06-17 08:20:17 +00:00
Owner
Copy link

ah right, qvitter did this weird cropping.

ah right, qvitter did this weird cropping.
shpuld commented 2019-06-17 19:07:45 +00:00
Member
Copy link

would keep the object notation spaced out as eslint demands, already spaced out the rest in polls MR so there might be a conflict regarding this file where it will be changed to fit the rest most likely

would keep the object notation spaced out as eslint demands, already spaced out the rest in polls MR so there might be a conflict regarding this file where it will be changed to fit the rest most likely
shpuld commented 2019-06-17 19:09:26 +00:00
Member
Copy link

LGTM

LGTM
shpuld commented 2019-06-17 19:10:00 +00:00
Member
Copy link

Yes, qvitter was pain in this regard, I'm happy if it works this way.

Yes, qvitter was pain in this regard, I'm happy if it works this way.
hj commented 2019-06-17 20:12:08 +00:00
Author
Member
Copy link
  const updateBg = ({ background }) => apiService.updateBg({ credentials, background })
```suggestion const updateBg = ({ background }) => apiService.updateBg({ credentials, background }) ```

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2102
No description provided.