pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

Fix broken token authentication #2113

Closed
tae wants to merge 0 commits from gitlab-mr-iid-846 into develop
pull from: gitlab-mr-iid-846
merge into: pleroma:develop
Conversation 5 Commits - Files changed -
tae commented 2019-06-20 03:42:08 +00:00
Member
Copy link
No description provided.
hj commented 2019-06-20 09:25:04 +00:00
Member
Copy link

there's no state.token and appToken should probably not be cleared

there's no `state.token` and `appToken` should probably not be cleared
tae commented 2019-06-20 11:45:08 +00:00
Author
Member
Copy link

c21ed4e9cb/src/modules/oauth.js (L33-35)

    getToken: state => () => {
      // state.token is userToken with older name, coming from persistent state
      // added here for smoother transition, otherwise user will be logged out
      return state.userToken || state.token || state.appToken
    },
    getUserToken: state => () => {
      // state.token is userToken with older name, coming from persistent state
      // added here for smoother transition, otherwise user will be logged out
      return state.userToken || state.token
    }

state.token is still being used as a fallback. It should be cleared as well.

https://git.pleroma.social/pleroma/pleroma-fe/blob/c21ed4e9cb780165bae2e4fda8ddeb2558c1fa8e/src/modules/oauth.js#L33-35 ``` getToken: state => () => { // state.token is userToken with older name, coming from persistent state // added here for smoother transition, otherwise user will be logged out return state.userToken || state.token || state.appToken }, getUserToken: state => () => { // state.token is userToken with older name, coming from persistent state // added here for smoother transition, otherwise user will be logged out return state.userToken || state.token } ``` `state.token` is still being used as a fallback. It should be cleared as well.
hj commented 2019-06-20 11:58:52 +00:00
Member
Copy link

then clear it properly then?

i.e. delete the property? just do it properly with vuex

and add a comment that we are clearing the fallback

then clear it properly then? i.e. delete the property? just do it properly with vuex and add a comment that we are clearing the fallback
tae commented 2019-06-20 15:50:37 +00:00
Author
Member
Copy link

sure, updated. 👍

sure, updated. :thumbsup:
tae commented 2019-06-21 15:53:33 +00:00
Author
Member
Copy link

@hj bump

@hj bump

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2113
No description provided.