timeline-skip-fix #2117

Closed
wyatt777 wants to merge 0 commits from gitlab-mr-iid-850 into develop
Member

fetchPinnedStatuses is resetting the min and max id for the whole timeline. This changes the api query to get the timeline by date, which results in posts being skipped #553 .

Fix: Ignore resetting the ids when fetching pinned statuses.

fetchPinnedStatuses is resetting the min and max id for the whole timeline. This changes the api query to get the timeline by date, which results in posts being skipped #553 . Fix: Ignore resetting the ids when fetching pinned statuses.
Member

Thanks, this is a bit of an embarrassing bug we haven't had the time to tackle yet. I think you could change the isPinned use into just using noIdUpdate when calling showNewStatuses, it's there for these situations when you don't want the timeline min/max id to update, no need for a new param

Thanks, this is a bit of an embarrassing bug we haven't had the time to tackle yet. I think you could change the `isPinned` use into just using `noIdUpdate` when calling showNewStatuses, it's there for these situations when you don't want the timeline min/max id to update, no need for a new param
Author
Member

Great! :) I made the change to that variable. @shpuld

Great! :) I made the change to that variable. @shpuld

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2117
No description provided.