Fix popper issues using another popper library #2148

Closed
tae wants to merge 0 commits from gitlab-mr-iid-881 into develop
Member

closes #609, closes #612

  • fixed popper not closing bug if tap outside the menu
  • fixed popper floating bug from timeline streaming
closes #609, closes #612 - fixed popper not closing bug if tap outside the menu - fixed popper floating bug from timeline streaming
Member

that's one hell of a "fix", can you elaborate? is v-tooltip better or something?

that's one hell of a "fix", can you elaborate? is v-tooltip better or something?
Author
Member

I dunno how to compare two libraries.
basically, both are based on popper.js library. but v-tooltip supports a more convenient way to use. and the most important thing is that it doesn't have the bug popper not closing if tap outside of the menu in iPhone.

I dunno how to compare two libraries. basically, both are based on popper.js library. but v-tooltip supports a more convenient way to use. and the most important thing is that it doesn't have the bug popper not closing if tap outside of the menu in iPhone.
Member

I don't notice the weird performance issues with this one compared the the other one we had, so in that regard this one is much better.

I don't notice the weird performance issues with this one compared the the other one we had, so in that regard this one is much better.
Author
Member

@shpuld 👏 👍

@shpuld :clap: :thumbsup:
Author
Member

can we merge this, please?

can we merge this, please?
Member

edit: i'm a dumbass

edit: i'm a dumbass

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2148
No description provided.