Ability to enlarge profile picture in profile page #2157

Closed
tae wants to merge 0 commits from gitlab-mr-iid-890 into develop
Member

closes #618

Screenshot_at_Jul_25_16-01-24

closes #618 ![Screenshot_at_Jul_25_16-01-24](/attachments/f519e9d1-1185-4047-ad32-0812ce8d3a3c)
Member

Might as well compare profileRoute directly with $route using the deep equals? or is there some other differences that require name and params comparing separately?

Might as well compare profileRoute directly with $route using the deep equals? or is there some other differences that require name and params comparing separately?
Member

I think this approach confuses things even more when it comes to what clicking on an avatar does. it can a) open a user card, b) navigate to profile, c) enlarge an avatar

On the other hand, once I get around to doing user tooltips, then a) is eliminated and user cards would only appear on profile pages, which would simplify things much more, so in that regard I think this is ok.

I'll think about it a bit more, but code seemed to look ok.

I think this approach confuses things even more when it comes to what clicking on an avatar does. it can a) open a user card, b) navigate to profile, c) enlarge an avatar On the other hand, once I get around to doing user tooltips, then a) is eliminated and user cards would only appear on profile pages, which would simplify things much more, so in that regard I think this is ok. I'll think about it a bit more, but code seemed to look ok.
Author
Member

We can't compare them directly since $route has more properties than profileRoute.

We can't compare them directly since `$route` has more properties than `profileRoute`.
Member

and i feel it's a bad idea overall to compare deeply tbh.

hold on, i need to review this, this is weird

and i feel it's a bad idea overall to compare deeply tbh. hold on, i need to review this, this is weird
Member

i think adding a little overlay with a magnifying glass over avatar (or next to it) would be enough indication

i think adding a little overlay with a magnifying glass over avatar (or next to it) would be enough indication
Member

ok, i don't think the whole thing is needed, we can probably add a parameter or use one of existing ones and pass it from user_profile.vue instead.

the less global weird dependencies the better

ok, i don't think the whole thing is needed, we can probably add a parameter or use one of existing ones and pass it from `user_profile.vue` instead. the less global weird dependencies the better
Author
Member

I thought about that approach before. That is a very clear and good approach if we want to enlarge when clicking avatar in the profile panel header only.
Screenshot_at_Jul_24_11-44-00

However, the current solution allows us to do that by clicking avatars in multiple places.
Screenshot_at_Jul_24_11-30-34

Do we need this feature in only one place or multiple places? Open to suggestions.

I thought about that approach before. That is a very clear and good approach if we want to enlarge when clicking avatar in the profile panel header only. ![Screenshot_at_Jul_24_11-44-00](/attachments/d133440b-600f-407d-a7d2-2c16b8b125fb) However, the current solution allows us to do that by clicking avatars in multiple places. ![Screenshot_at_Jul_24_11-30-34](/attachments/984cd9fe-d814-4572-a134-5f94692bd515) Do we need this feature in only one place or multiple places? Open to suggestions.
Author
Member

I agree.

I agree.
Member

i'd say only avatar in the profile page's header should enlarge it, i.e. the first one screenshot. Second one is too weird and feels like a bug.

i'd say only avatar in the profile page's header should enlarge it, i.e. the first one screenshot. Second one is too weird and feels like a bug.
Author
Member

updated

updated
Author
Member

added.

added.
Author
Member

updated @hj

updated @hj

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2157
No description provided.