WIP: Converse.js XMPP chat integration #2164

Closed
tae wants to merge 14 commits from gitlab-mr-iid-897 into develop
Member
ref: https://git.pleroma.social/pleroma/pleroma/pulls/4873
Member

not a fan of idea of integrating it upstream, shouldn't it be pluggable like just add script tag? What about themes?

not a fan of idea of integrating it upstream, shouldn't it be pluggable like just add script tag? What about themes?
Member

that sounds bad, like if XMPP doesn't work fall back to old way? what if xmpp will never work? what if chat is disabled? what if admin wants old chat?

that sounds bad, like if XMPP doesn't work fall back to old way? what if xmpp will never work? what if chat is disabled? what if admin wants old chat?
Member

configurable?

configurable?
Member

environment-dependent?

environment-dependent?
Member

can we cache it?

can we cache it?
Author
Member

this is WIP.

this is WIP.
Author
Member

this will work only if admin configured XMPP integration at the server-side, so if the admin wants the old chat or something is not working with XMPP, the admin just can disable XMPP integration at the server-side.

this will work only if admin configured XMPP integration at the server-side, so if the admin wants the old chat or something is not working with XMPP, the admin just can disable XMPP integration at the server-side.
Author
Member

yes, we can make these params configurable upon request slowly. atm, we want to integrate it quickly and verify that it is functional.

yes, we can make these params configurable upon request slowly. atm, we want to integrate it quickly and verify that it is functional.
Author
Member

@chvanikoff does /xmpp/conndata api return same response? if yes, per instance or per user/session? kindly let me know.

@chvanikoff does `/xmpp/conndata` api return same response? if yes, per instance or per user/session? kindly let me know.
Author
Member

fyi, we are testing this using a dev instance integrated with XMPP now. until we finish it, this is WIP.

fyi, we are testing this using a dev instance integrated with XMPP now. until we finish it, this is WIP.
Member

it is unique per user

it is unique per user

I don't see this getting done anytime soon, and the use case overlaps a lot with #2286, so closing for now.

I don't see this getting done anytime soon, and the use case overlaps a lot with #2286, so closing for now.

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2164
No description provided.