pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Fix #617 again #2187

Closed
raven wants to merge 1 commit from gitlab-mr-iid-920 into develop
pull from: gitlab-mr-iid-920
merge into: pleroma:develop
Conversation 8 Commits 1 Files changed 1 +3
raven commented 2019-08-17 03:59:52 +00:00
Member
Copy link

Sometime after I did the original fix for #617, error.error also became a JSON string, and it that was causing an exception.

Closes #617. (Hopefully for real)

Sometime after I did the original fix for #617, `error.error` also became a JSON string, and it that was causing an exception. Closes #617. (Hopefully for real)
shpuld commented 2019-08-17 07:34:06 +00:00
Owner
Copy link

My question is why on earth does BE return errors formatted differently for the same request? @lambadalambda @rinpatch

For username already taken: "{\"error\":\"{\\\"ap_id\\\":[\\\"has already been taken\\\"]}\"}"

For captcha: {"error":"{\"captcha\":[\"Invalid CAPTCHA\"]}"}

I think this should be fixed in BE side

My question is why on earth does BE return errors formatted differently for the same request? @lambadalambda @rinpatch For username already taken: `"{\"error\":\"{\\\"ap_id\\\":[\\\"has already been taken\\\"]}\"}"` For captcha: `{"error":"{\"captcha\":[\"Invalid CAPTCHA\"]}"}` I think this should be fixed in BE side
hj commented 2019-08-17 09:22:24 +00:00
Owner
Copy link

it should probably just output error data without the { error: _ } object, just have a correct status code is enough

it should probably just output error data without the `{ error: _ }` object, just have a correct status code is enough
rinpatch commented 2019-08-18 20:21:21 +00:00
Member
Copy link

{ error: "string" } is mastoapi representation for errors

`{ error: "string" }` is mastoapi representation for errors
rinpatch commented 2019-08-18 20:22:32 +00:00
Member
Copy link

I agree, error should be a string

I agree, `error` should be a string
shpuld commented 2019-08-19 05:15:23 +00:00
Owner
Copy link

the problem is the outer quotes, which are missing in the captcha error

the problem is the outer quotes, which are missing in the captcha error
raven commented 2019-08-25 06:01:40 +00:00
Author
Member
Copy link

Is "string" just a plain string, or is it an object serialized as a string?

Is `"string"` just a plain string, or is it an object serialized as a string?
raven commented 2019-08-29 01:41:21 +00:00
Author
Member
Copy link

Also, besides pleroma-fe, are there any known clients that use the existing registration endpoint?

Also, besides pleroma-fe, are there any known clients that use the existing registration endpoint?
kaniini commented 2019-11-08 02:16:54 +00:00
Member
Copy link

This was resolved on the BE side.

This was resolved on the BE side.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2187
No description provided.