pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

[Feature] Redirect remote user to internal ID #2188

Closed
hakabahitoyo wants to merge 16 commits from gitlab-mr-iid-921 into develop
pull from: gitlab-mr-iid-921
merge into: pleroma:develop
Conversation 21 Commits 16 Files changed 4 +67
hakabahitoyo commented 2019-08-19 08:25:43 +00:00
Member
Copy link

Resolve remote user's host name and user name into internal ID, and redirect to that.

  • /remote-users/:username@:hostname -> /users/:id
  • /remote-users/@:username@:hostname -> /users/:id
  • /remote-users/:hostname/:username -> /users/:id

Usecase

Some implementations of decentralized social network, such as Misskey, have no explicit remote follow feature on their standard web UI. In case of following from Pleroma (e. g. pleroma.example.com) to Misskey (e. g. exampleuser@misskey.io), first we can open the URL https://pleroma.example.com/remote-user/@exampleuser@misskey.io, redirected into https://pleroma.example.com/users/INTERNAL_ID, and we can push the follow button.

Resolve remote user's host name and user name into internal ID, and redirect to that. * `/remote-users/:username@:hostname` -> `/users/:id` * `/remote-users/@:username@:hostname` -> `/users/:id` * `/remote-users/:hostname/:username` -> `/users/:id` ### Usecase Some implementations of decentralized social network, such as Misskey, have no explicit remote follow feature on their standard web UI. In case of following from Pleroma (e. g. `pleroma.example.com`) to Misskey (e. g. `exampleuser@misskey.io`), first we can open the URL `https://pleroma.example.com/remote-user/@exampleuser@misskey.io`, redirected into `https://pleroma.example.com/users/INTERNAL_ID`, and we can push the *follow* button.
hakabahitoyo commented 2019-08-24 15:13:52 +00:00
Author
Member
Copy link

I believe that this MR is ready to merge.

I believe that this MR is ready to merge.
hj commented 2019-08-24 18:01:01 +00:00
Member
Copy link

Not sure why, you can just use user search to find remote user.

On top of that we shouldn't redirect internal users, and whole thing is buggy enough already, this will need intense testing before merge.

Not sure why, you can just use user search to find remote user. On top of that we shouldn't redirect internal users, and whole thing is buggy enough already, this will need intense testing before merge.
shpuld commented 2019-08-26 11:18:37 +00:00
Member
Copy link

I think this is a good idea, search can be fiddly sometimes. This doesn't seem to change how internal users work either.

I think this is a good idea, search can be fiddly sometimes. This doesn't seem to change how internal users work either.
rinpatch commented 2019-08-27 05:12:03 +00:00
Member
Copy link

plz don't depend on qvitterapi for new features

plz don't depend on qvitterapi for new features
hj commented 2019-08-27 06:27:54 +00:00
Member
Copy link

????

????
shpuld commented 2019-08-27 06:31:05 +00:00
Member
Copy link

I guess this.$store.state.api.backendInteractor.externalProfile(acct) is qvitterApi?

can we have something similar of our own if qvitterapi is not ok?

I guess `this.$store.state.api.backendInteractor.externalProfile(acct)` is qvitterApi? can we have something similar of our own if qvitterapi is not ok?
rinpatch commented 2019-08-27 08:24:06 +00:00
Member
Copy link

I guess this.$store.state.api.backendInteractor.externalProfile(acct) is qvitterApi?

Yes

can we have something similar of our own if qvitterapi is not ok?

Yes, filed pleroma#1222

> I guess `this.$store.state.api.backendInteractor.externalProfile(acct)` is qvitterApi? Yes > can we have something similar of our own if qvitterapi is not ok? Yes, filed pleroma#1222
hj commented 2019-08-27 08:26:21 +00:00
Member
Copy link

oh yeah, that unmaintained bit of code. I thought there's already mastoapi analogue for it?

oh yeah, that unmaintained bit of code. I thought there's already mastoapi analogue for it?
rinpatch commented 2019-08-27 08:31:18 +00:00
Member
Copy link

We extended /api/v1/accounts/:id to support nicknames, but remote nicknames don't work because of a bug

We extended `/api/v1/accounts/:id` to support nicknames, but remote nicknames don't work because of a bug
hj commented 2019-10-15 16:05:10 +00:00
Member
Copy link
              params: { id }
```suggestion:-0+0 params: { id } ```
hj commented 2019-10-15 16:14:31 +00:00
Member
Copy link

errors aren't handled at all, at least showing a bar with error would be nice

errors aren't handled at all, at least showing a bar with error would be nice
hj commented 2019-10-15 16:14:59 +00:00
Member
Copy link

"Searching for @user@instance" would be nicer

"Searching for @user@instance" would be nicer
hj commented 2019-10-15 16:17:06 +00:00
Member
Copy link

maybe call it RemoteUserResolver or RemoteUserSearch, since there's no actual profile in it and it might be confusing since we have UserProfile which is used for both remote and local profiles.

maybe call it `RemoteUserResolver` or `RemoteUserSearch`, since there's no actual profile in it and it might be confusing since we have `UserProfile` which is used for both remote and local profiles.
hakabahitoyo commented 2019-10-26 12:20:12 +00:00
Author
Member
Copy link

OK.

OK.
hakabahitoyo commented 2019-10-26 12:20:23 +00:00
Author
Member
Copy link

Done. Thanks.

Done. Thanks.
hakabahitoyo commented 2019-10-26 12:20:35 +00:00
Author
Member
Copy link

Done. Thanks.

Done. Thanks.
kaniini commented 2019-11-08 01:19:22 +00:00
Member
Copy link

@rinpatch is the MastoAPI issue for this fixed?

@rinpatch is the MastoAPI issue for this fixed?
rinpatch commented 2019-11-08 11:07:10 +00:00
Member
Copy link

Yes, pleroma#1222

Yes, pleroma#1222
hj commented 2019-11-08 11:16:48 +00:00
Member
Copy link

i'll test it once again today and merge

i'll test it once again today and merge
hj commented 2019-11-08 11:17:10 +00:00
Member
Copy link

it worked last time, at least

it worked last time, at least
hj commented 2019-11-08 22:27:16 +00:00
Member
Copy link

on of the routes doesn't work properly with dev server but it's fine i guess.

on of the routes doesn't work properly with dev server but it's fine i guess.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2188
No description provided.