pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

Support Native Lazy-Loading #2198

Closed
tae wants to merge 1 commit from gitlab-mr-iid-931 into develop
pull from: gitlab-mr-iid-931
merge into: pleroma:develop
Conversation 9 Commits 1 Files changed 1 +1
tae commented 2019-08-27 18:55:44 +00:00
Member
Copy link

According to the release announcement, starting with Chrome 76, we'll be able to use the new loading attribute to lazy-load resources without the need to write custom lazy-loading code or use a separate JavaScript library. We can now lazy-load images without

  • Using any external library,
  • Writing custom lazy-loading codes or
  • Loading JavaScript on the Frontend

NOTE: This works only in Chrome atm. The other browsers will just ignore this.

ref: https://scotch.io/bar-talk/native-lazy-loading-launched-on-chrome-76

According to the release announcement, starting with Chrome 76, we'll be able to use the new `loading` attribute to lazy-load resources without the need to write custom lazy-loading code or use a separate JavaScript library. We can now lazy-load images without - Using any external library, - Writing custom lazy-loading codes or - Loading JavaScript on the Frontend **NOTE:** This works only in Chrome atm. The other browsers will just ignore this. ref: https://scotch.io/bar-talk/native-lazy-loading-launched-on-chrome-76
hj commented 2019-08-27 21:42:50 +00:00
Member
Copy link

not a big fan of supporting browser-exclusive stuff, but sure. Just need to test it first.

not a big fan of supporting browser-exclusive stuff, but sure. Just need to test it first.
shpuld commented 2019-08-29 17:13:40 +00:00
Member
Copy link

it's still free

more on topic: I still don't get what the big difference is in lazy loading for us, we don't tend to load that many statuses with visible attachments, the biggest save comes when you decide not to scroll to see all the posts you loaded and only view half of them. it's a pretty much useless save compared to the downside of visible pop-in all the time everywhere :/

it's still free more on topic: I still don't get what the big difference is in lazy loading for us, we don't tend to load that many statuses with visible attachments, the biggest save comes when you decide not to scroll to see all the posts you loaded and only view half of them. it's a pretty much useless save compared to the downside of visible pop-in all the time everywhere :/
feld commented 2019-08-29 22:26:12 +00:00
Owner
Copy link

Yeah I'd like to see some benchmarks and a deeper dive into this. Biggest win, really, is on mobileFE where you can get crushed just by loading a timeline on a slow-ish mobile connection. Or how about when you load someone's profile and in the background it fetches the media tab and then is downloading images in the background (right? it seems to be doing this for me, but i haven't verified)

Yeah I'd like to see some benchmarks and a deeper dive into this. Biggest win, really, is on mobileFE where you can get crushed just by loading a timeline on a slow-ish mobile connection. Or how about when you load someone's profile and in the background it fetches the media tab and then is downloading images in the background (right? it seems to be doing this for me, but i haven't verified)
shpuld commented 2019-08-30 06:51:41 +00:00
Member
Copy link

While opening a profile it does load the statuses in all the timelines, but I don't think the images get downloaded before the statuses are being rendered. Gotta test it out a bit. I guess the benefit comes from better ordering the download order, with lazy loading it always loads stuff in viewport and not all at once, even if in the end it does download everything as you scroll downa bit.

While opening a profile it does load the statuses in all the timelines, but I don't think the images get downloaded before the statuses are being rendered. Gotta test it out a bit. I guess the benefit comes from better ordering the download order, with lazy loading it always loads stuff in viewport and not all at once, even if in the end it does download everything as you scroll downa bit.
hj commented 2019-08-31 19:09:41 +00:00
Member
Copy link

IIRC browser does not fetch images that are not visible, unless of course it's some retarded "browser" like safari

IIRC browser does **not** fetch images that are not visible, unless of course it's some retarded "browser" like safari
kaniini commented 2019-11-08 02:22:44 +00:00
Member
Copy link

I tested this on Chrome 78 and did not notice any notable memory or CPU use difference. Do we really need this?

I tested this on Chrome 78 and did not notice any notable memory or CPU use difference. Do we really need this?
feld commented 2019-11-08 21:09:01 +00:00
Owner
Copy link

we might lose all benefits of this with garbage collection anyway

we might lose all benefits of this with garbage collection anyway
hj commented 2019-11-08 22:01:49 +00:00
Member
Copy link

i don't think those two are related in any way

i don't think those two are related in any way
feld commented 2019-12-13 17:05:41 +00:00
Owner
Copy link

Gonna kill this effort for now.

Gonna kill this effort for now.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2198
No description provided.