pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

[#664] implementes to hide/show reblogs from a specific user. #2223

Closed
parallel588 wants to merge 0 commits from gitlab-mr-iid-956 into develop
pull from: gitlab-mr-iid-956
merge into: pleroma:develop
Conversation 42 Commits - Files changed -
parallel588 commented 2019-09-21 18:31:26 +00:00
Member
Copy link

pleroma/pleroma#1073

https://git.pleroma.social/pleroma/pleroma/issues/1073
hj commented 2019-09-22 09:06:44 +00:00
Member
Copy link
  1. Please use "repeats" instead of boosts for consistency.
  2. Is from {user} really necessary? I feel like "Hide repeats" might be enough, if not "Hide repeats from this user" could also be acceptable.
1. Please use "repeats" instead of boosts for consistency. 2. Is `from {user}` really necessary? I feel like "Hide repeats" might be enough, if not "Hide repeats from this user" could also be acceptable.
parallel588 commented 2019-09-22 11:42:54 +00:00
Author
Member
Copy link

fixed.

Is from {user} really necessary? I feel like "Hide repeats" might be enough, if not "Hide repeats from this user" could also be acceptable.

I took it from https://mastodon.social/. we can remove it

fixed. > Is from {user} really necessary? I feel like "Hide repeats" might be enough, if not "Hide repeats from this user" could also be acceptable. I took it from https://mastodon.social/. we can remove it
shpuld commented 2019-09-25 07:08:06 +00:00
Member
Copy link

it's very nice to finally get this feature, but the way it's in the UI just doesn't seem right. maybe we should start putting options into a dropdown instead on the user profile.

it's very nice to finally get this feature, but the way it's in the UI just doesn't seem right. maybe we should start putting options into a dropdown instead on the user profile.
hj commented 2019-09-25 15:05:01 +00:00
Member
Copy link

yeah, should probably make an issue about that already

yeah, should probably make an issue about that already
parallel588 commented 2019-09-25 19:30:13 +00:00
Author
Member
Copy link

I agree.
I'll add dropdown list with options: subscribe/unsubscribe, hide/show repeats, mute, block, report.

I agree. I'll add dropdown list with options: subscribe/unsubscribe, hide/show repeats, mute, block, report.
parallel588 commented 2019-09-30 18:00:46 +00:00
Author
Member
Copy link

@shpuld @hj Could you please review it again?

@shpuld @hj Could you please review it again?
parallel588 commented 2019-09-30 18:03:56 +00:00
Author
Member
Copy link

I added dropdown list with actionsScreenshot_from_2019-09-30_21-01-25

I added dropdown list with actions![Screenshot_from_2019-09-30_21-01-25](/attachments/79c3fa14-219e-4a42-bad7-66b72cc09fdc)
Screenshot_from_2019-09-30_21-01-25.png
31 KiB
hj commented 2019-09-30 18:17:53 +00:00
Member
Copy link

will check out tomorrow

will check out tomorrow
hj commented 2019-10-03 17:33:11 +00:00
Member
Copy link
  1. Shouldn't be completely right-aligned, follow button should be on the left side.
  2. I think it's better to leave "Subscribe" button where it was and also keep "Mute" button out of menu.
  3. If it's button then it's probably better to have text like "Other..." or "Actions" on it, if it's three-dots menu it should be where user settings or open external profile icon is:
    image
    personally i think icon would be better, and it should be always the rightmost icon (unless it's your own profile where it's hidden) so that it doesn't jump around depending if it's external user or local
1. Shouldn't be completely right-aligned, follow button should be on the left side. 2. I think it's better to leave "Subscribe" button where it was and also keep "Mute" button out of menu. 3. If it's button then it's probably better to have text like "Other..." or "Actions" on it, if it's three-dots menu it should be where user settings or open external profile icon is: ![image](/attachments/48802611-9084-4b33-992e-60036ca04230) personally i think icon would be better, and it should be always the rightmost icon (unless it's your own profile where it's hidden) so that it doesn't jump around depending if it's external user or local
image.png
103 KiB
hj commented 2019-10-03 17:39:13 +00:00
Member
Copy link

why !important;???

why `!important;`???
hj commented 2019-10-03 17:39:35 +00:00
Member
Copy link

no need for px

no need for `px`
hj commented 2019-10-03 17:43:07 +00:00
Member
Copy link

seems a bit unnecessary

seems a bit unnecessary
hj commented 2019-10-03 17:44:15 +00:00
Member
Copy link

why is it different from title ()?

why is it different from `title ()`?
hj commented 2019-10-03 17:44:49 +00:00
Member
Copy link

follow_progress went MIA, also you can do i18n on the spot here instead of in template

`follow_progress` went MIA, also you can do i18n on the spot here instead of in template
hj commented 2019-10-03 17:45:28 +00:00
Member
Copy link

maybe onClick?

maybe `onClick`?
hj commented 2019-10-03 17:46:56 +00:00
Member
Copy link

i think some browsers do not understand flex-end well, at least i remember having such problem before.

also flex-end is a bad choice

i think some browsers do not understand `flex-end` well, at least i remember having such problem before. also flex-end is a bad choice
hj commented 2019-10-03 17:48:01 +00:00
Member
Copy link

can't you use JSON?

can't you use JSON?
hj commented 2019-10-03 17:49:25 +00:00
Member
Copy link

good god MastoAPI is atrocious...

good god MastoAPI is atrocious...
hj commented 2019-10-03 17:54:47 +00:00
Member
Copy link

Following button is kinda fucked
image

Following button is kinda fucked ![image](/attachments/d0b26155-7061-435a-8fae-ce24889d7d44)
image.png
12 KiB
hj commented 2019-10-03 17:55:19 +00:00
Member
Copy link

Show repeats is always greyed out for some reason
image

Show repeats is always greyed out for some reason ![image](/attachments/7075fe99-5cd9-4fef-8703-5ef9862be44b)
image.png
18 KiB
hj commented 2019-10-03 17:56:07 +00:00
Member
Copy link

pressed makes it look greyed-out

`pressed` makes it look greyed-out
parallel588 commented 2019-10-08 14:39:34 +00:00
Author
Member
Copy link

@hj could you please review it again? Screenshot_from_2019-10-08_17-35-19

@hj could you please review it again? ![Screenshot_from_2019-10-08_17-35-19](/attachments/612275bc-5621-4c31-9a9f-29b572ffae60)
Screenshot_from_2019-10-08_17-35-19.png
76 KiB
hj commented 2019-10-08 18:48:01 +00:00
Member
Copy link

i can say just from the screenshot:

  • previous icon was more fitting
  • buttons should have minimal width or at least horizontal padding
  • "Blocked!" should say "Unblock"
i can say just from the screenshot: * previous icon was more fitting * buttons should have minimal width or at least horizontal padding * "Blocked!" should say "Unblock"
hj commented 2019-10-08 18:49:29 +00:00
Member
Copy link

meant for moderation tools but unused here

meant for moderation tools but unused here
hj commented 2019-10-08 19:01:48 +00:00
Member
Copy link

image

  • those icons are waaaaaaaay too close to each other
  • their hitboxes are too small
  • "burger" menu (again, it should be dots) doesn't have pointer cursor on hover, also probably good opportunity to make those icon change color on hover
![image](/attachments/25518c71-9d06-487a-ad57-6212c0eb246f) * those icons are waaaaaaaay too close to each other * their hitboxes are too small * "burger" menu (again, it should be dots) doesn't have pointer cursor on hover, also probably good opportunity to make those icon change color on hover
image.png
18 KiB
parallel588 commented 2019-10-09 12:57:02 +00:00
Author
Member
Copy link

Screenshot_from_2019-10-09_15-45-41

@hj this updated. Could you please check it?

![Screenshot_from_2019-10-09_15-45-41](/attachments/a357bd8b-6084-4b32-ac72-57c7f9939225) @hj this updated. Could you please check it?
Screenshot_from_2019-10-09_15-45-41.png
149 KiB
hj commented 2019-10-09 13:09:25 +00:00
Member
Copy link

doesn't seem to be used anywhere else? it just sets that property to it on show/hide and that's it? Or am I missing something?

doesn't seem to be used anywhere else? it just sets that property to it on show/hide and that's it? Or am I missing something?
hj commented 2019-10-09 13:12:09 +00:00
Member
Copy link

looks better, will check it out in-depth/test later today. Meanwhile there's still unresolved/unanswered comments since first review.

looks better, will check it out in-depth/test later today. Meanwhile there's still unresolved/unanswered comments since first review.
parallel588 commented 2019-10-09 13:22:21 +00:00
Author
Member
Copy link

yes, I missed it. removed

yes, I missed it. removed
parallel588 commented 2019-10-09 13:36:33 +00:00
Author
Member
Copy link

the 'title' use as hint of button. the 'label' use as action of button.
and they has different values depend on the 'user.following'

I moved these label\title from user_card.vue. maybe we need to chnage label\title of this button. but I noticed similar button in follow_card.vue and this button also has different title\label of button.

the 'title' use as hint of button. the 'label' use as action of button. and they has different values depend on the 'user.following' I moved these label\title from user_card.vue. maybe we need to chnage label\title of this button. but I noticed similar button in follow_card.vue and this button also has different title\label of button.
hj commented 2019-10-09 18:36:32 +00:00
Member
Copy link

image
image

order is still wrong - makes three dots jump when switching between local and remote user - it should stay in place.

![image](/attachments/7eb08f56-8df3-41b3-af0a-565267f80d33) ![image](/attachments/cdc30612-30a5-4187-985c-6794125bda2a) order is still wrong - makes three dots jump when switching between local and remote user - it should stay in place.
image.png
136 KiB
image.png
44 KiB
hj commented 2019-10-09 18:39:29 +00:00
Member
Copy link

ok, let's leave it as is for now

ok, let's leave it as is for now
parallel588 commented 2019-10-11 11:34:07 +00:00
Author
Member
Copy link

@hj . I fixed position of dots. Could you please look it?

@hj . I fixed position of dots. Could you please look it?
hj commented 2019-10-11 11:39:53 +00:00
Member
Copy link

????

????
hj commented 2019-10-11 11:42:36 +00:00
Member
Copy link

you have flex .card-action container - no need to make its elements absolute. give them correct order:

you have flex `.card-action` container - no need to make its elements absolute. give them correct `order: `
hj commented 2019-10-11 11:43:06 +00:00
Member
Copy link

no need to set fixed width, give its items some padding and margin

no need to set fixed width, give its items some `padding` and `margin`
parallel588 commented 2019-10-11 13:57:24 +00:00
Author
Member
Copy link

I didn't notice that the eslint changed this. returned as it was

I didn't notice that the eslint changed this. returned as it was
parallel588 commented 2019-10-11 13:58:45 +00:00
Author
Member
Copy link

do you mean that AccountActions must be last, after link(tatusnet_profile_url), right?

do you mean that AccountActions must be last, after link(tatusnet_profile_url), right?
parallel588 commented 2019-10-14 06:41:28 +00:00
Author
Member
Copy link

user_card
is it correct?

![user_card](/attachments/2a4be522-eab6-4842-b3f3-ddaa49b2647b) is it correct?
user_card.png
45 KiB
hj commented 2019-10-14 07:17:46 +00:00
Member
Copy link

that's correct but i was talking bout how you're using position: absolute without any need for it

that's correct but i was talking bout how you're using `position: absolute` without any need for it
parallel588 commented 2019-10-14 08:21:23 +00:00
Author
Member
Copy link

yes, I did it withot positionL absolute.
Could you please check last commit?

yes, I did it withot `positionL absolute`. Could you please check last commit?
parallel588 commented 2019-10-14 08:22:47 +00:00
Author
Member
Copy link

.card-action container - also removed

`.card-action` container - also removed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2223
No description provided.