Settings refactor #2227

Closed
hj wants to merge 0 commits from gitlab-mr-iid-960 into develop
Member
  • Greatly decreased overall verbosity of settings/config
    • New getter: mergedConfig - combines user config with instance-default config, no more need for instance.thing !== undefined ? instance.thing : user.thing
    • Settings page now automatically creates all needed computed properties with setters - no more need for optionSettingLocal and relevant watchers - only thing needed is to define settings in module.
  • Replaced most trivial checkboxes with <Checkbox> component, decreasing overall verbosity in user-settings/settings templates, streamlining other checkboxes.
    • Other checkboxes are deemed non-trivial and probably will be replaced later.
* Greatly decreased overall verbosity of settings/config * New getter: `mergedConfig` - combines user config with instance-default config, no more need for `instance.thing !== undefined ? instance.thing : user.thing` * Settings page now automatically creates all needed computed properties with setters - no more need for `optionSettingLocal` and relevant watchers - only thing needed is to define settings in module. * Replaced most trivial checkboxes with `<Checkbox>` component, decreasing overall verbosity in user-settings/settings templates, streamlining other checkboxes. * Other checkboxes are deemed non-trivial and probably will be replaced later.
Author
Member

seems to be working fine so far.

seems to be working fine so far.
Member

aren't the ending > supposed to be on the same indent as the beginning <?

aren't the ending `>` supposed to be on the same indent as the beginning `<`?
Member

Looks good, only nitpicks about wrong > indent in a few places

Looks good, only nitpicks about wrong > indent in a few places

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2227
No description provided.