pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Profile fields setting #2264

Closed
kphrx wants to merge 0 commits from gitlab-mr-iid-997 into develop
pull from: gitlab-mr-iid-997
merge into: pleroma:develop
Conversation 29 Commits - Files changed -
kphrx commented 2019-11-14 19:09:47 +00:00
Member
Copy link

Add profile fields to User Settings.

refs #149

  • Rebasing after merge the #2262.
Add profile fields to User Settings. refs #149 * [x] Rebasing after merge the #2262.
rinpatch commented 2019-11-14 19:35:05 +00:00
Member
Copy link

The limit is configurable. For some reason it's not currently reported in nodeinfo though, could you open a backend MR about that?

The limit is configurable. For some reason it's not currently reported in nodeinfo though, could you open a backend MR about that?
rinpatch commented 2019-11-14 19:38:21 +00:00
Member
Copy link

This is wrong. fields contains html values for fields, you don't want to present that for editing. Instead you should use source.fields, which contains raw field values

This is wrong. `fields` contains html values for fields, you don't want to present that for editing. Instead you should use `source.fields`, which contains raw field values
kphrx commented 2019-11-14 20:34:38 +00:00
Author
Member
Copy link

currentUser.fields is already normalized to use source.fields with this change #2262/diffs

`currentUser.fields` is already normalized to use `source.fields` with this change https://git.pleroma.social/pleroma/pleroma-fe/pulls/2262/diffs?commit_id=920e746b17655a2973737b28a1810ba7341d50b6#31ffa7ec4281d31ca048ed7bc96e69d90b4d03a2_98_106
kphrx commented 2019-11-14 20:44:00 +00:00
Author
Member
Copy link

When deleting fields, the fields to be deleted remain in currentUser.fields

When deleting fields, the fields to be deleted remain in `currentUser.fields`
hj commented 2019-11-14 20:45:56 +00:00
Owner
Copy link

@kPherox your changes from #2262 are here as well, do you want that MR closed or..?

@kPherox your changes from #2262 are here as well, do you want that MR closed or..?
hj commented 2019-11-14 20:47:20 +00:00
Owner
Copy link

don't override same field with different data, it should be more consistent what it represents

don't override same field with different data, it should be more consistent what it represents
kphrx commented 2019-11-14 21:12:23 +00:00
Author
Member
Copy link

@hj need currentUser.fields of #2262 so I was set to base. I was thinking about rebase or merge when merged

@hj need `currentUser.fields` of #2262 so I was set to base. I was thinking about rebase or merge when merged
kphrx commented 2019-11-15 09:56:39 +00:00
Author
Member
Copy link

Opened pleroma/pleroma#5361

Opened pleroma/pleroma#5361
kphrx commented 2019-11-18 10:12:53 +00:00
Author
Member
Copy link

Fixed c6ad4ab1

Fixed c6ad4ab1
shpuld commented 2019-12-02 11:53:21 +00:00
Owner
Copy link

Maybe just setField is alright? like setField(index, { name, value }), or is it easier to do things the way you already did it?

Maybe just setField is alright? like `setField(index, { name, value })`, or is it easier to do things the way you already did it?
shpuld commented 2019-12-02 11:54:59 +00:00
Owner
Copy link

seems like something is wrong if you have to manually do - 1 in each of the calls

seems like something is wrong if you have to manually do - 1 in each of the calls
hj commented 2019-12-02 12:25:37 +00:00
Owner
Copy link

unfortunately this is the way EmojiInput works right now - it has to have same events as underlying inputbox/textarea

unfortunately this is the way EmojiInput works right now - it has to have same events as underlying inputbox/textarea
kphrx commented 2019-12-02 12:36:32 +00:00
Author
Member
Copy link

In Vue.js v2, v-for="i in 10" starts with 1 and ends with 10, so the value used for index is - 1.

In Vue.js v2, `v-for="i in 10"` starts with 1 and ends with 10, so the value used for index is - 1.
kphrx commented 2019-12-02 14:15:18 +00:00
Author
Member
Copy link

If you change by only inserting field with empty name, the value will not change after the update.

If you change by only inserting field with empty name, the value will not change after the update.
kphrx commented 2019-12-02 14:36:22 +00:00
Author
Member
Copy link

Fixed e5321e10

Fixed e5321e10
kphrx commented 2019-12-02 14:37:38 +00:00
Author
Member
Copy link

Is it like 6c7921dc?

Is it like 6c7921dc?
kphrx commented 2019-12-05 14:53:26 +00:00
Author
Member
Copy link

Use index instead of v-for's range value. a6def0bd

Use index instead of v-for's range value. a6def0bd
shpuld commented 2020-03-11 17:21:49 +00:00
Owner
Copy link

Works, right now makes the user settings look even more of a mess though, form shouldn't have places for all the fields by default, they should be added like poll options

Works, right now makes the user settings look even more of a mess though, form shouldn't have places for all the fields by default, they should be added like poll options
kphrx commented 2020-03-26 11:26:23 +00:00
Author
Member
Copy link

changed 65128de8

changed 65128de8
gitlab-ghost-3733 commented 2020-06-14 04:42:09 +00:00
Member
Copy link

What is the status on this?

What is the status on this?
hj commented 2020-06-14 12:54:26 +00:00
Owner
Copy link

needs testing i think

needs testing i think
lanodan commented 2020-06-16 17:54:12 +00:00
Owner
Copy link

Merged it to my branch and it looks like you can add fields but not delete the last one.

screen

Merged it to my branch and it looks like you can add fields but not delete the last one. ![screen](/attachments/e9197c09-dbdf-4451-99a7-84d1feeb4ec8)
screen.png
5.3 KiB
shpuld commented 2020-06-17 15:33:02 +00:00
Owner
Copy link

I can set fields using text and links which work fine, but there's no emoji picker and custom emoji don't work (not sure if they are supported in fields)

I can set fields using text and links which work fine, but there's no emoji picker and custom emoji don't work (not sure if they are supported in fields)
kphrx commented 2020-06-17 17:14:46 +00:00
Author
Member
Copy link

Mastodon can use custom emoji in profile fields. However, currently pleroma don't add emojis to the user when use emoji in profile fields. So I set hide-emoji-button and unset enable-emoji-picker to EmojiInput component.

Mastodon can use custom emoji in profile fields. However, currently pleroma don't add emojis to the user when use emoji in profile fields. So I set `hide-emoji-button` and unset `enable-emoji-picker` to `EmojiInput` component.
shpuld commented 2020-06-17 17:22:08 +00:00
Owner
Copy link

oh I see, should create an issue for it then on BE

oh I see, should create an issue for it then on BE
shpuld commented 2020-06-19 10:14:21 +00:00
Owner
Copy link

one problem though, console gets lots of errors when you open settings they come from the picklerless fields I think. seems like a bug in emojiInput. should it really use emojiInput at all if it doesn't do any sort of completion?

one problem though, console gets lots of errors when you open settings they come from the picklerless fields I think. seems like a bug in emojiInput. should it really use emojiInput at all if it doesn't do any sort of completion?
kphrx commented 2020-06-19 10:31:18 +00:00
Author
Member
Copy link

ah, I forgot cherry-pick to fix emoji input (7d2cef9e) when I rebased to develop

ah, I forgot cherry-pick to fix emoji input (7d2cef9e) when I rebased to develop
kphrx commented 2020-06-19 12:16:44 +00:00
Author
Member
Copy link

(I had forgotten about that) can use username beginning with '@', so I'll temporarily implement user suggestor and enable picker.

(I had forgotten about that) can use username beginning with '@', so I'll temporarily implement user suggestor and enable picker.
lambadalambda commented 2020-06-27 09:45:13 +00:00
Owner
Copy link

nice!

nice!

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
7 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2264
No description provided.