pleroma/pleroma-fe
pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 12
Code Issues 345 Pull requests 20 Projects Releases 5 Packages 1 Wiki Activity

WIP: Localforage Replacement #2406

Draft
lambadalambda wants to merge 2 commits from gitlab-mr-iid-1139 into develop
pull from: gitlab-mr-iid-1139
merge into: pleroma:develop
Conversation 13 Commits 2 Files changed 3 +79 -11
lambadalambda commented 2020-06-10 14:32:32 +00:00
Owner
Copy link

A localforage compatible indexeddb-only key value store.

It can use the old database, but by default it will use a new one. See the comment for how to enable usage of the existing db.

File size is 5kb vs 90kb

A localforage compatible indexeddb-only key value store. It can use the old database, but by default it will use a new one. See the comment for how to enable usage of the existing db. File size is 5kb vs 90kb
lambadalambda commented 2020-06-12 12:43:27 +00:00
Author
Owner
Copy link

This now also supports localstorage fallback, tested with chrome which for some reason only gives me indexeddb in an incognito window ????

This now also supports localstorage fallback, tested with chrome which for some reason only gives me indexeddb in an incognito window ????
lambadalambda commented 2020-06-13 10:24:37 +00:00
Author
Owner
Copy link

Adding WIP again because while this works, if we actually merge it it should default to the old localforage stuff so people's stuff doesn't get reset.

Adding WIP again because while this works, if we actually merge it it should default to the old localforage stuff so people's stuff doesn't get reset.
shpuld commented 2020-06-15 08:51:47 +00:00
Member
Copy link

I'm having trouble parsing this, so you get localstorage normally in chrome or you always get indexeddb regardless of incognito? if latter, then it's normal afaik

I'm having trouble parsing this, so you get localstorage normally in chrome or you always get indexeddb regardless of incognito? if latter, then it's normal afaik
shpuld commented 2020-06-15 08:58:52 +00:00
Member
Copy link

I don't think we should ever change name of the database, the point was to switch the layer in between the database and the application so it's all seamless, not to create a new database

I don't think we should ever change name of the database, the point was to switch the layer in between the database and the application so it's all seamless, not to create a new database
lambadalambda commented 2020-06-15 08:59:28 +00:00
Author
Owner
Copy link

Sorry, I have this behavior in chrome:

  1. Normal window: Indexeddb doesn't work, i only get localstorage.
  2. Incognito window: Indexeddb does work.

Weird, but made it easy to test if the localstorage fallback works :)

Sorry, I have this behavior in chrome: 1. Normal window: Indexeddb doesn't work, i only get localstorage. 2. Incognito window: Indexeddb does work. Weird, but made it easy to test if the localstorage fallback works :)
lambadalambda commented 2020-06-15 09:00:13 +00:00
Author
Owner
Copy link

This was just to not overwrite stuff during testing, before un-WIPing this should be changed to the localforage defaults.

This was just to not overwrite stuff during testing, before un-WIPing this should be changed to the localforage defaults.
shpuld commented 2020-06-15 09:04:22 +00:00
Member
Copy link

I hope you test in localhost where it doesn't matter and not by deploying ;)

I hope you test in localhost where it doesn't matter and not by deploying ;)
shpuld commented 2020-06-15 09:05:12 +00:00
Member
Copy link

yeah that's kinda weird but fine then

it's also easy to test it by making the indexeddb files read only in your file system (something I learned at old job)

yeah that's kinda weird but fine then it's also easy to test it by making the indexeddb files read only in your file system (something I learned at old job)
lambadalambda commented 2020-06-15 09:29:24 +00:00
Author
Owner
Copy link

read only in your file system

maybe that's what happened somehow

> read only in your file system maybe that's what happened somehow
lambadalambda commented 2020-06-15 09:29:45 +00:00
Author
Owner
Copy link

i test by copying it over to soykaf and waiting for complaints

i test by copying it over to soykaf and waiting for complaints
hj commented 2020-06-15 11:00:30 +00:00
Member
Copy link

what if browser has support for indexeddb but also has data in localstorage? I've seen it before with localforage at least.

what if browser has support for indexeddb but also has data in localstorage? I've seen it before with localforage at least.
hj commented 2020-06-15 11:03:16 +00:00
Member
Copy link

I would also test it on shitty mobile browsers like safari/android 4.x, ucbro, as well as shitty desktop browsers like safari/mememoon. Especially with migrations.

I would also test it on shitty mobile browsers like safari/android 4.x, ucbro, as well as shitty desktop browsers like safari/mememoon. **Especially** with migrations.
lambadalambda commented 2020-06-15 11:44:08 +00:00
Author
Owner
Copy link

i can check what localforage does in this case.

i can check what localforage does in this case.
This pull request has changes conflicting with the target branch.
  • src/lib/persisted_state.js
  • src/sw.js
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin gitlab-mr-iid-1139:gitlab-mr-iid-1139
git switch gitlab-mr-iid-1139

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff gitlab-mr-iid-1139
git switch gitlab-mr-iid-1139
git rebase develop
git switch develop
git merge --ff-only gitlab-mr-iid-1139
git switch gitlab-mr-iid-1139
git rebase develop
git switch develop
git merge --no-ff gitlab-mr-iid-1139
git switch develop
git merge --squash gitlab-mr-iid-1139
git switch develop
git merge --ff-only gitlab-mr-iid-1139
git switch develop
git merge gitlab-mr-iid-1139
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2406
No description provided.