StatusContent: Better separate subject from status content. #2417

Closed
lambadalambda wants to merge 0 commits from gitlab-mr-iid-1150 into develop

Closes #812

How it looks:

No subject

Screenshot_2020-06-19_dontbulling_me_1_

First line is the subject

Screenshot_2020-06-19_dontbulling_me

Closes #812 How it looks: ### No subject ![Screenshot_2020-06-19_dontbulling_me_1_](/attachments/94409be7-fe47-4adc-a89e-66194925e64f) ### First line is the subject ![Screenshot_2020-06-19_dontbulling_me](/attachments/de1e2c92-a6a2-451f-96ef-f310d671a09a)
Owner

doing some styling with it, no merge yet

doing some styling with it, no merge yet
Owner

maybe italics instead of bold?

maybe *italics* instead of **bold**?
Owner

breaks long status hiding, fixing

breaks long status hiding, fixing
Owner

This is the kind of styling I'm trying out. also thinking of taking out the show more/show less toggle when the "collapse statuses with subject" option is disabled, don't think it's particularly useful to let people toggle statuses with just a few lines if they already don't want to treat subjects as CWs by having the option disabled.

regular short title

image

longer title that warrants a toggle (especially useful when viewing a thread with a long title in every post when copied)

image

This is the kind of styling I'm trying out. also thinking of taking out the show more/show less toggle when the "collapse statuses with subject" option is disabled, don't think it's particularly useful to let people toggle statuses with just a few lines if they already don't want to treat subjects as CWs by having the option disabled. regular short title ![image](/attachments/f6ecee3d-33aa-4983-a1f9-d179063e1224) longer title that warrants a toggle (especially useful when viewing a thread with a long title in every post when copied) ![image](/attachments/3d9084cd-ae60-4c3b-a8de-dcec00a71271)
Owner

With collapse (treat subjects as CWs) option enabled

short title

image

long title (looks a bit silly but what are you gonna do

image

long title with title and status expanded

image

With collapse (treat subjects as CWs) option enabled short title ![image](/attachments/1536ed9b-439f-430f-80ac-26eb0c3b8686) long title (looks a bit silly but what are you gonna do ![image](/attachments/255a6428-473a-49dd-934d-bf650a56caf4) long title with title and status expanded ![image](/attachments/8e6ed5c5-c893-4a59-bd07-0bf24c3a1c22)
Owner

think it'd be worth it to change the vocab, so "Show more"/"Show less" is reserved only for tall statuses where it fits, and for CW style collapsed posts it'd use "Show content"/"Hide content"

think it'd be worth it to change the vocab, so "Show more"/"Show less" is reserved only for tall statuses where it fits, and for CW style collapsed posts it'd use "Show content"/"Hide content"
Owner

combination of both long subject and tall status

image

combination of both long subject and tall status ![image](/attachments/218f38ea-f1ae-4faf-b12e-24141d27853e)
Author
Owner

Nice, but 'title' should probably be subject.

Nice, but 'title' should probably be subject.
Owner

changing

changing
Owner

just demonstration of how a typical CW use case might look:

hidden:

image

expanded:

image

just demonstration of how a typical CW use case might look: hidden: ![image](/attachments/e7160814-d775-4f0c-85d7-1735cc9ae115) expanded: ![image](/attachments/08ee3dcb-9505-429a-909f-ca5e8c479a6e)
Owner

LGTM 👍

LGTM :+1:
Author
Owner

Looks nice!

Looks nice!
Author
Owner

tested it again, works very nicely. Thank you for taking this further!

tested it again, works very nicely. Thank you for taking this further!

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2417
No description provided.