pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

Status preview #459 #2426

Closed
shpuld wants to merge 0 commits from gitlab-mr-iid-1159 into develop
pull from: gitlab-mr-iid-1159
merge into: pleroma:develop
Conversation 29 Commits - Files changed -
shpuld commented 2020-06-28 09:48:32 +00:00
Member
Copy link

MR #2002 was too outdated, started over.

UPDATED LOOK:

imageimage

VIDEO:
video

OLD STUFF:

Adds "Preview" option above post status form when a rich text format is selected.

imageimage

When server is taking its time to process:

image

A preview with HTML and MD (updates automatically on switch):

imageimage

When the server denies your crap

image

Attachments also work

image

MR #2002 was too outdated, started over. UPDATED LOOK: ![image](/attachments/9902fab4-5d93-4f57-89a8-96d621b3c0de)![image](/attachments/8f91c25a-2e91-481d-a554-1858c52f1444) VIDEO: ![video](https://shpposter.club/media/0db835f4d6e195b58334bc1cb1b5ef65ff824b62fb148a4723da6736ff2723e1.mp4) OLD STUFF: Adds "Preview" option above post status form ~~when a rich text format is selected.~~ ![image](/attachments/f2e9de1e-114b-4014-945d-bff7bf2eac68)![image](/attachments/22c29499-56e3-4f38-922b-9559fdfcf178) When server is taking its time to process: ![image](/attachments/4077256f-85b8-497a-9f15-4b608ac2fb5d) A preview with HTML and MD (updates automatically on switch): ![image](/attachments/5cbb99a5-9c8d-457e-9752-582f4b84e2e4)![image](/attachments/98c4ee2f-fb2e-4adf-bec7-878801264155) When the server denies your crap ![image](/attachments/30013cca-fa48-40d4-99f0-a278b9a4af6f) Attachments also work ![image](/attachments/6da5f21c-3d6b-4e98-b9da-8aa7c038bbab)
image.png
87 KiB
image.png
99 KiB
image.png
216 KiB
image.png
80 KiB
image.png
78 KiB
image.png
79 KiB
image.png
95 KiB
image.png
88 KiB
image.png
87 KiB
shpuld commented 2020-06-28 10:04:32 +00:00
Author
Member
Copy link

This fixes the "Error: [Object Response]" problem we have when status posting goes wrong.

This fixes the "Error: [Object Response]" problem we have when status posting goes wrong.
shpuld commented 2020-06-28 10:10:53 +00:00
Author
Member
Copy link

I saw comment in the issue that this would be useful in plain text, I can change it if we still want it

I saw comment in the issue that this would be useful in plain text, I can change it if we still want it
lambadalambda commented 2020-06-28 10:11:00 +00:00
Owner
Copy link

Very nice! I think some form of auto-updating / live preview would be fine if the refresh is throttled or debounced.

Very nice! I think some form of auto-updating / live preview would be fine if the refresh is throttled or debounced.
lambadalambda commented 2020-06-28 10:11:20 +00:00
Owner
Copy link

it would be useful in plain text for emoji stuff, i think.

it would be useful in plain text for emoji stuff, i think.
shpuld commented 2020-06-28 10:12:53 +00:00
Author
Member
Copy link

could be done too

could be done too
lambadalambda commented 2020-06-28 10:13:27 +00:00
Owner
Copy link

although in that case we'll need to change the backend a bit to make it not trigger the rate limiting

although in that case we'll need to change the backend a bit to make it not trigger the rate limiting
lambadalambda commented 2020-06-28 10:15:46 +00:00
Owner
Copy link

issue at https://git.pleroma.social/pleroma/pleroma/-/issues/1899

issue at https://git.pleroma.social/pleroma/pleroma/-/issues/1899
shpuld commented 2020-06-28 10:23:15 +00:00
Author
Member
Copy link

I'm wondering how the UX will be when the content grows above the input fields pushing the layout down

I'm wondering how the UX will be when the content grows above the input fields pushing the layout down
lambadalambda commented 2020-06-28 10:26:24 +00:00
Owner
Copy link

maybe better put it below, then?

maybe better put it below, then?
shpuld commented 2020-06-28 10:27:04 +00:00
Author
Member
Copy link

it'd be very awkward under the attachments

it'd be very awkward under the attachments
hj commented 2020-06-28 11:19:36 +00:00
Member
Copy link

it is awkward that textbox is being pushed downwards, also previews the long post detector, not sure if it's good or not

image

it is awkward that textbox is being pushed downwards, also previews the long post detector, not sure if it's good or not ![image](/attachments/73ef0299-710b-4874-831e-9c6db933825a)
image.png
206 KiB
hj commented 2020-06-28 11:20:49 +00:00
Member
Copy link

however it should scroll textbox into view as you type

however it should scroll textbox into view as you type
shpuld commented 2020-06-28 11:23:10 +00:00
Author
Member
Copy link

oh yeah I didn't test on mobile. might be quite fucky.

having it treat long posts as long posts is fine imo, same with treating subjects the same way as they'd appear on your timeline

oh yeah I didn't test on mobile. might be quite fucky. having it treat long posts as long posts is fine imo, same with treating subjects the same way as they'd appear on your timeline
hj commented 2020-06-28 11:24:00 +00:00
Member
Copy link

image

"Preview" on the right side makes some weird spacing on the left side in modal post form and reply post form. Looks a bit out of place with link coloring but that's just habit i guess.

I'd change "Preview" to "Preview post" just for clarity and move it to the left side.

![image](/attachments/1897ce3b-cf02-487b-907b-0bd36a4b9506) "Preview" on the right side makes some weird spacing on the left side in modal post form and reply post form. Looks a bit out of place with link coloring but that's just habit i guess. I'd change "Preview" to "Preview post" just for clarity and move it to the left side.
image.png
40 KiB
hj commented 2020-06-28 11:31:26 +00:00
Member
Copy link

more stylistic problems:

  • spacing between preview and post form != spacing between "preview" link
  • One-line post has different height between "Loading..." and actual post content
  • close icon's hitbox is a bit too small vertically
more stylistic problems: * spacing between preview and post form != spacing between "preview" link * One-line post has different height between "Loading..." and actual post content * close icon's hitbox is a bit too small vertically
shpuld commented 2020-06-28 11:45:12 +00:00
Author
Member
Copy link

first one is intentional, you want a gap between the actual preview and the editables, it's a bit cluttered with the 1em gap already too. You don't really want that gap with just the button to open it.

the other two I can tweak but 1 liner size change isn't particularly important if you ask me

first one is intentional, you want a gap between the actual preview and the editables, it's a bit cluttered with the 1em gap already too. You don't really want that gap with just the button to open it. the other two I can tweak but 1 liner size change isn't particularly important if you ask me
hj commented 2020-06-28 11:47:44 +00:00
Member
Copy link

it's annoying and makes interface more jumpy than it should be

it's annoying and makes interface more jumpy than it should be
shpuld commented 2020-06-28 11:50:34 +00:00
Author
Member
Copy link

it's gonna jump a lot anyway, the alternatives are worse, if you refer to first one

it's gonna jump a lot anyway, the alternatives are worse, if you refer to first one
shpuld commented 2020-06-28 12:14:22 +00:00
Author
Member
Copy link

added automatic updates, it actually feels surprisingly fine. I'll experiment with positioning

added automatic updates, it actually feels surprisingly fine. I'll experiment with positioning
shpuld commented 2020-06-28 12:25:31 +00:00
Author
Member
Copy link

I tried adding polls to the preview, it doesn't work well and while it would be cool to see if your options look the way you wanted I think it's still more weird than useful. maybe I should take out the media files as well from the preview? I mean you see the media below the form already.

I tried adding polls to the preview, it doesn't work well and while it would be cool to see if your options look the way you wanted I think it's still more weird than useful. maybe I should take out the media files as well from the preview? I mean you see the media below the form already.
hj commented 2020-06-28 12:37:10 +00:00
Member
Copy link

yeah i didn't quite understand why attachments are there too, i vote to remove them.

I mean the only reason why you would want that is to check how it will arrange everything inside, which may not be correct because of different column width

yeah i didn't quite understand why attachments are there too, i vote to remove them. I mean the only reason why you would want that is to check how it will arrange everything inside, which may not be correct because of different column width
shpuld commented 2020-06-28 13:41:30 +00:00
Author
Member
Copy link

fixed the loading and error message line heights to match status, removed the X button in favor of unified show/hide toggle

fixed the loading and error message line heights to match status, removed the X button in favor of unified show/hide toggle
shpuld commented 2020-06-28 13:41:58 +00:00
Author
Member
Copy link

changed the heading to be a toggle instead of X show button and X button:

imageimage

changed the heading to be a toggle instead of X show button and X button: ![image](/attachments/5fca4c00-604d-4cc5-9d50-0093702f1189)![image](/attachments/87b01cb4-d50b-4669-9703-74a548964fd1)
image.png
87 KiB
image.png
80 KiB
shpuld commented 2020-06-28 14:01:41 +00:00
Author
Member
Copy link

Live previews in action

https://shpposter.club/media/0db835f4d6e195b58334bc1cb1b5ef65ff824b62fb148a4723da6736ff2723e1.mp4

Live previews in action https://shpposter.club/media/0db835f4d6e195b58334bc1cb1b5ef65ff824b62fb148a4723da6736ff2723e1.mp4
hj commented 2020-07-04 22:14:55 +00:00
Member
Copy link

Changing the subject line doesn't trigger the update

Changing the subject line doesn't trigger the update
hj commented 2020-07-04 22:24:02 +00:00
Member
Copy link

otherwise lgtm

otherwise lgtm
hj commented 2020-07-06 08:22:01 +00:00
Member
Copy link

also wanted to note that i would prefer preview not closing on posting in main post form, or at least have an option for that. not necessary for this MR tho

also wanted to note that i would prefer preview not closing on posting in main post form, or at least have an option for that. not necessary for this MR tho
shpuld commented 2020-07-06 08:27:28 +00:00
Author
Member
Copy link

I was just thinking the same, I'll change it, no need for an option imo

I was just thinking the same, I'll change it, no need for an option imo
shpuld commented 2020-07-06 08:29:46 +00:00
Author
Member
Copy link

lol something else to fix before merging

image

lol something else to fix before merging ![image](/attachments/90fb0c1b-a8e3-4e25-bc84-9a41e5dd56c5)
image.png
94 KiB

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2426
No description provided.