pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

Image description authoring (rebased) #2427

Closed
xenofem wants to merge 0 commits from gitlab-mr-iid-1160 into develop
pull from: gitlab-mr-iid-1160
merge into: pleroma:develop
Conversation 26 Commits - Files changed -
xenofem commented 2020-06-28 17:05:20 +00:00
Member
Copy link

Rebased version of #1864 with a couple of syntax/style fixes to make Vue happy. There was some mention of #1864 needing UX enhancement, I'm pretty happy with the current UX and feel like getting this long-overdue feature out there in any form should be the priority, unless there are any glaring usability issues that need fixing. I've got this patch deployed on my personal instance and haven't run into any problems yet.

Rebased version of #1864 with a couple of syntax/style fixes to make Vue happy. There was some mention of #1864 needing UX enhancement, I'm pretty happy with the current UX and feel like getting this long-overdue feature out there in any form should be the priority, unless there are any glaring usability issues that need fixing. I've got this patch deployed on my personal instance and haven't run into any problems yet.
shpuld commented 2020-06-28 18:06:44 +00:00
Member
Copy link

the UI for entering the description is pretty nice imo, but I can't see the description when I mouseover the image I posted

edit: ok it worked on the png I posted but not the gif I posted

edit2: tested again, a gif and a jpg, both are showing their filename instead of the description I wrote, I wonder if that's a BE issue

the UI for entering the description is pretty nice imo, but I can't see the description when I mouseover the image I posted edit: ok it worked on the png I posted but not the gif I posted edit2: tested again, a gif and a jpg, both are showing their filename instead of the description I wrote, I wonder if that's a BE issue
shpuld commented 2020-06-28 18:11:54 +00:00
Member
Copy link

hitting enter when entering description posts, need to prevent that

hitting enter when entering description posts, need to prevent that
xenofem commented 2020-06-28 18:23:19 +00:00
Author
Member
Copy link

Do you think we should make the input element into a multi-line text field, so that problem is sidestepped and also it's easier to write longer descriptions? Or should it stay a single-line field but just suppress that event handler?

Do you think we should make the input element into a multi-line text field, so that problem is sidestepped and also it's easier to write longer descriptions? Or should it stay a single-line field but just suppress that event handler?
shpuld commented 2020-06-28 18:24:02 +00:00
Member
Copy link

single-line is just fine imo, just suppress the event

single-line is just fine imo, just suppress the event
shpuld commented 2020-06-28 18:34:35 +00:00
Member
Copy link

ok @lambadalambda you might be interested, I post where the image descrption is given like this "muumit"

image

but the mouseover shows the filename "moominbowl.jpg"

ok @lambadalambda you might be interested, I post where the image descrption is given like this "muumit" ![image](/attachments/b4c77bf7-31fe-45b1-b959-265df3ce16f5) but the mouseover shows the filename "moominbowl.jpg"
image.png
70 KiB
xenofem commented 2020-06-28 18:39:09 +00:00
Author
Member
Copy link

What do you think of this approach, adding a hidden disabled submit button at the top of the form so that the default submit action triggered by hitting Enter is a no-op: https://stackoverflow.com/questions/895171/prevent-users-from-submitting-a-form-by-hitting-enter/51507806#51507806 ? It'll also fix the same bug on the subject input field.

What do you think of this approach, adding a hidden disabled submit button at the top of the form so that the default submit action triggered by hitting Enter is a no-op: https://stackoverflow.com/questions/895171/prevent-users-from-submitting-a-form-by-hitting-enter/51507806#51507806 ? It'll also fix the same bug on the subject input field.
shpuld commented 2020-06-28 18:48:25 +00:00
Member
Copy link

you should just add @keydown.prevent.enter="" to the description input

you should just add @keydown.prevent.enter="" to the description input
xenofem commented 2020-06-28 20:15:30 +00:00
Author
Member
Copy link

Huh, can't reproduce this on backend 2.0.7-stable. PNGs, JPGs, and static GIFs are all showing the descriptions I give them when I mouseover.

Huh, can't reproduce this on backend 2.0.7-stable. PNGs, JPGs, and static GIFs are all showing the descriptions I give them when I mouseover.
shpuld commented 2020-06-28 20:40:47 +00:00
Member
Copy link

this was on dontbulling.me

this was on dontbulling.me
xenofem commented 2020-06-28 21:00:28 +00:00
Author
Member
Copy link

sent you a status with an image description from my instance so we can debug further, try sending me one back?

sent you a status with an image description from my instance so we can debug further, try sending me one back?
shpuld commented 2020-06-29 05:21:09 +00:00
Member
Copy link

ok the UI can get quite awkward sometimes too, I think it needs some attention, I can take a look at it and play around

image

ok the UI can get quite awkward sometimes too, I think it needs some attention, I can take a look at it and play around ![image](/attachments/3d204f9b-dc52-429c-a061-a6c78aa607e9)
image.png
189 KiB
shpuld commented 2020-06-29 09:01:44 +00:00
Member
Copy link

I made some minor visual adjustments and got around some code debt by making the upload previews use the attachment component, so you can actually expand the images now

image

I made some minor visual adjustments and got around some code debt by making the upload previews use the attachment component, so you can actually expand the images now ![image](/attachments/03b4c18c-d3fc-4f67-84a4-14bdea40bc37)
image.png
374 KiB
hj commented 2020-06-29 09:21:11 +00:00
Member
Copy link

hey, that's mildly adequate :DDDD

hey, that's mildly adequate :DDDD
shpuld commented 2020-06-29 09:24:28 +00:00
Member
Copy link

there's still some issues I need to iron out, then I'll push back to this branch, or do new MR, depending on which is easier

there's still some issues I need to iron out, then I'll push back to this branch, or do new MR, depending on which is easier
shpuld commented 2020-06-29 10:05:41 +00:00
Member
Copy link

getting carried away with fixing existing issues with attachments, like the not useful [UNKNOWN] placeholder link, as well as trying to open non-images/videos in modal image

getting carried away with fixing existing issues with attachments, like the not useful [UNKNOWN] placeholder link, as well as trying to open non-images/videos in modal ![image](/attachments/02cc1940-1536-4868-a492-59cff5a57c50)
image.png
20 KiB
shpuld commented 2020-06-29 10:07:52 +00:00
Member
Copy link

still need a way for mobile to actually see the descriptions, thinking of making modal always display it under the image, not sure what to do with video

although I don't want to scope creep this particular MR more than that, so maybe do that later

still need a way for mobile to actually see the descriptions, thinking of making modal always display it under the image, not sure what to do with video although I don't want to scope creep this particular MR more than that, so maybe do that later
shpuld commented 2020-06-29 10:15:20 +00:00
Member
Copy link

can confirm that the descriptions work correctly on older version, on shpposter.club it works right, but on dontbulling.me it doesn't.

can confirm that the descriptions work correctly on older version, on shpposter.club it works right, but on dontbulling.me it doesn't.
lambadalambda commented 2020-06-29 10:20:52 +00:00
Owner
Copy link

the unknown -> filename thing is great! I agree with the scope creep though, this already seems useful and is long overdue.

the unknown -> filename thing is great! I agree with the scope creep though, this already seems useful and is long overdue.
shpuld commented 2020-06-29 10:22:06 +00:00
Member
Copy link

(more exactly unknown -> description so people can still trick others to download crazyfrog.mp3.exe

(more exactly unknown -> description so people can still trick others to download crazyfrog.mp3.exe
hj commented 2020-06-29 11:16:52 +00:00
Member
Copy link

the unknown -> filename thing is great!

wait i thought filenames were bad???????

image

>the unknown -> filename thing is great! wait i thought filenames were bad??????? ![image](/attachments/3f52ea68-d436-41b8-bf61-dfd581da04c5)
image.png
486 KiB
shpuld commented 2020-06-29 11:17:52 +00:00
Member
Copy link

it's description, gives user the ability to change it to whatever, instead of leaking filename

changed the rest of the placeholder style attachments

image

it's description, gives user the ability to change it to whatever, instead of leaking filename changed the rest of the placeholder style attachments ![image](/attachments/dfe59ef8-823c-4304-afd3-7361c6e7f2e6)
image.png
30 KiB
hj commented 2020-06-29 11:19:17 +00:00
Member
Copy link

OFFTOPIC: will we ever get actual filename support in addition to description?

**OFFTOPIC:** will we ever get actual filename support in addition to description?
shpuld commented 2020-06-29 11:33:49 +00:00
Member
Copy link

some tweaks, + examples of NSFW and no-description image
image

some tweaks, + examples of NSFW and no-description image ![image](/attachments/0a8717b5-b9f0-4fc5-a3aa-a55da7152574)
image.png
85 KiB
lambadalambda commented 2020-06-29 11:37:33 +00:00
Owner
Copy link

@hj please stop with the sarcasm, it's not funny to me and actually insulting, which i have told you multiple times.

@hj please stop with the sarcasm, it's not funny to me and actually insulting, which i have told you multiple times.
hj commented 2020-06-29 11:46:23 +00:00
Member
Copy link

it wasn't sarcasm, i just want my filenames back

it wasn't sarcasm, i just want my filenames back
shpuld commented 2020-06-29 12:05:21 +00:00
Member
Copy link

looks like I can't push to the remote branch, I guess I'll just make another MR lol

looks like I can't push to the remote branch, I guess I'll just make another MR lol

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2427
No description provided.